viewvcs: die on tmpfile() errors

[public-inbox.git] / lib / PublicInbox / ViewVCS.pm

diff --git a/lib/PublicInbox/ViewVCS.pm b/lib/PublicInbox/ViewVCS.pm
index 6365f04547bca74359c611ea307a9b4f8f2f10be..3cbc363b9d113b4b811af9d1acc121e03ad9f5cd 100644 (file)
--- a/lib/PublicInbox/ViewVCS.pm
+++ b/lib/PublicInbox/ViewVCS.pm
@@ -54,7 +54,7 @@ sub stream_blob_parse_hdr { # {parse_hdr} for Qspawn
                                'text/plain; charset=UTF-8', @cl ] ];
                }
                if ($r == 0) {
-                       warn "premature EOF on $oid $$logref\n";
+                       warn "premature EOF on $oid $$logref";
                        return html_page($ctx, 500, $logref);
                }
                @$ctx{qw(-res -logref)} = ($res, $logref);
@@ -111,7 +111,7 @@ sub solve_result {
        my ($log, $hints, $fn) = delete @$ctx{qw(log hints fn)};
 
        unless (seek($log, 0, 0)) {
-               $ctx->{env}->{'psgi.errors'}->print("seek(log): $!\n");
+               warn "seek(log): $!";
                return html_page($ctx, 500, \'seek error');
        }
        $log = do { local $/; <$log> };
@@ -138,7 +138,7 @@ sub solve_result {
        my $blob = $git->cat_file($oid);
        if (!$blob) { # WTF?
                my $e = "Failed to retrieve generated blob ($oid)";
-               $ctx->{env}->{'psgi.errors'}->print("$e ($git->{git_dir})\n");
+               warn "$e ($git->{git_dir})";
                $log = "<pre><b>$e</b></pre>" . $log;
                return html_page($ctx, 500, \$log);
        }
@@ -194,7 +194,7 @@ sub show ($$;$) {
                $hints->{$to} = $v if $v ne '';
        }
 
-       $ctx->{'log'} = tmpfile("solve.$oid_b");
+       $ctx->{'log'} = tmpfile("solve.$oid_b") // die "tmpfile: $!";
        $ctx->{fn} = $fn;
        my $solver = PublicInbox::SolverGit->new($ctx->{ibx},
                                                \&solve_result, $ctx);