get rid of unnecessary bytes::length usage

[public-inbox.git] / lib / PublicInbox / ViewVCS.pm

diff --git a/lib/PublicInbox/ViewVCS.pm b/lib/PublicInbox/ViewVCS.pm
index 2f8e1c4f6531413e8bec34b5929678bdf8f86ab8..6365f04547bca74359c611ea307a9b4f8f2f10be 100644 (file)
--- a/lib/PublicInbox/ViewVCS.pm
+++ b/lib/PublicInbox/ViewVCS.pm
@@ -1,4 +1,4 @@
-# Copyright (C) 2019-2020 all contributors <meta@public-inbox.org>
+# Copyright (C) 2019-2021 all contributors <meta@public-inbox.org>
 # License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
 
 # show any VCS object, similar to "git show"
@@ -15,10 +15,9 @@
 
 package PublicInbox::ViewVCS;
 use strict;
-use warnings;
-use bytes (); # only for bytes::length
+use v5.10.1;
 use PublicInbox::SolverGit;
-use PublicInbox::WwwStream;
+use PublicInbox::WwwStream qw(html_oneshot);
 use PublicInbox::Linkify;
 use PublicInbox::Tmpfile;
 use PublicInbox::Hval qw(ascii_html to_filename);
@@ -27,21 +26,15 @@ my $hl = eval {
        PublicInbox::HlMod->new;
 };
 
-my %QP_MAP = ( A => 'oid_a', B => 'oid_b', a => 'path_a', b => 'path_b' );
+my %QP_MAP = ( A => 'oid_a', a => 'path_a', b => 'path_b' );
 our $MAX_SIZE = 1024 * 1024; # TODO: configurable
 my $BIN_DETECT = 8000; # same as git
 
-sub html_i { # WwwStream::getline callback
-       my ($nr, $ctx) =  @_;
-       $nr == 1 ? ${delete $ctx->{obuf}} : undef;
-}
-
 sub html_page ($$$) {
        my ($ctx, $code, $strref) = @_;
        my $wcb = delete $ctx->{-wcb};
        $ctx->{-upfx} = '../../'; # from "/$INBOX/$OID/s/"
-       $ctx->{obuf} = $strref;
-       my $res = PublicInbox::WwwStream->response($ctx, $code, \&html_i);
+       my $res = html_oneshot($ctx, $code, $strref);
        $wcb ? $wcb->($res) : $res;
 }
 
@@ -55,7 +48,7 @@ sub stream_blob_parse_hdr { # {parse_hdr} for Qspawn
        } elsif (index($$bref, "\0") >= 0) {
                [200, [qw(Content-Type application/octet-stream), @cl] ];
        } else {
-               my $n = bytes::length($$bref);
+               my $n = length($$bref);
                if ($n >= $BIN_DETECT || $n == $size) {
                        return [200, [ 'Content-Type',
                                'text/plain; charset=UTF-8', @cl ] ];
@@ -64,6 +57,7 @@ sub stream_blob_parse_hdr { # {parse_hdr} for Qspawn
                        warn "premature EOF on $oid $$logref\n";
                        return html_page($ctx, 500, $logref);
                }
+               @$ctx{qw(-res -logref)} = ($res, $logref);
                undef; # bref keeps growing
        }
 }
@@ -132,7 +126,7 @@ sub solve_result {
 
        my ($git, $oid, $type, $size, $di) = @$res;
        return show_other($ctx, $res, \$log, $fn) if $type ne 'blob';
-       my $path = to_filename($di->{path_b} || $hints->{path_b} || 'blob');
+       my $path = to_filename($di->{path_b} // $hints->{path_b} // 'blob');
        my $raw_link = "(<a\nhref=$path>raw</a>)";
        if ($size > $MAX_SIZE) {
                return stream_large_blob($ctx, $res, \$log, $fn) if defined $fn;
@@ -189,18 +183,20 @@ sub solve_result {
        html_page($ctx, 200, \$log);
 }
 
+# GET /$INBOX/$GIT_OBJECT_ID/s/
+# GET /$INBOX/$GIT_OBJECT_ID/s/$FILENAME
 sub show ($$;$) {
        my ($ctx, $oid_b, $fn) = @_;
        my $qp = $ctx->{qp};
        my $hints = $ctx->{hints} = {};
        while (my ($from, $to) = each %QP_MAP) {
                defined(my $v = $qp->{$from}) or next;
-               $hints->{$to} = $v;
+               $hints->{$to} = $v if $v ne '';
        }
 
        $ctx->{'log'} = tmpfile("solve.$oid_b");
        $ctx->{fn} = $fn;
-       my $solver = PublicInbox::SolverGit->new($ctx->{-inbox},
+       my $solver = PublicInbox::SolverGit->new($ctx->{ibx},
                                                \&solve_result, $ctx);
        # PSGI server will call this immediately and give us a callback (-wcb)
        sub {