spawn (and thus popen_rd) die on failure

[public-inbox.git] / lib / PublicInbox / WwwListing.pm

diff --git a/lib/PublicInbox/WwwListing.pm b/lib/PublicInbox/WwwListing.pm
index 4f076b7d24041f17cced038d802414cc27a6dc0a..8d6100375e65df772fbe7f0733716b51ddfa5dab 100644 (file)
--- a/lib/PublicInbox/WwwListing.pm
+++ b/lib/PublicInbox/WwwListing.pm
@@ -6,7 +6,7 @@
 package PublicInbox::WwwListing;
 use strict;
 use warnings;
-use PublicInbox::Hval qw(ascii_html);
+use PublicInbox::Hval qw(ascii_html prurl);
 use PublicInbox::Linkify;
 use PublicInbox::View;
 use PublicInbox::Inbox;
@@ -84,13 +84,13 @@ sub new {
 sub ibx_entry {
        my ($mtime, $ibx, $env) = @_;
        my $ts = PublicInbox::View::fmt_ts($mtime);
-       my $url = PublicInbox::Hval::prurl($env, $ibx->{url});
+       my $url = prurl($env, $ibx->{url});
        my $tmp = <<"";
 * $ts - $url
   ${\$ibx->description}
 
        if (defined(my $info_url = $ibx->{infourl})) {
-               $tmp .= '  ' . PublicInbox::Hval::prurl($env, $info_url) . "\n";
+               $tmp .= '  ' . prurl($env, $info_url) . "\n";
        }
        $tmp;
 }
@@ -136,9 +136,7 @@ sub fingerprint ($) {
        my ($git) = @_;
        # TODO: convert to qspawn for fairness when there's
        # thousands of repos
-       my ($fh, $pid) = $git->popen('show-ref') or
-               die "popen($git->{git_dir} show-ref) failed: $!";
-
+       my ($fh, $pid) = $git->popen('show-ref');
        my $dig = Digest::SHA->new(1);
        while (read($fh, my $buf, 65536)) {
                $dig->add($buf);