convert: shift @ARGV explicitly

[public-inbox.git] / script / public-inbox-convert

diff --git a/script/public-inbox-convert b/script/public-inbox-convert
index 8ac111a26cd98add4a0baa59b6b81ae94105b399..281313e02873fb7bd7aa27ba8fcc5dbd0e2c188f 100755 (executable)
--- a/script/public-inbox-convert
+++ b/script/public-inbox-convert
@@ -19,8 +19,8 @@ my %opts = (
        '--index!' => \$index,
 );
 GetOptions(%opts) or die "bad command-line args\n$usage";
-my $old_dir = shift or die $usage;
-my $new_dir = shift or die $usage;
+my $old_dir = shift(@ARGV) or die $usage;
+my $new_dir = shift(@ARGV) or die $usage;
 die "$new_dir exists\n" if -d $new_dir;
 die "$old_dir not a directory\n" unless -d $old_dir;
 my $config = eval { PublicInbox::Config->new };
@@ -87,7 +87,6 @@ $clone may not be valid after migrating to v2, not copying
        }
 });
 my $state = '';
-my ($prev, $from);
 my $head = $old->{ref_head} || 'HEAD';
 my ($rd, $pid) = $old->git->popen(qw(fast-export --use-done-feature), $head);
 $v2w->idx_init;
@@ -132,11 +131,6 @@ while (<$rd>) {
                        $last = 'd';
                        next;
                }
-               if (m{^from (:[0-9]+)}) {
-                       $prev = $from;
-                       $from = $1;
-                       # no next
-               }
        }
        last if $_ eq "done\n";
        $w->print($_) or $im->wfail;