favor `do {}' over `eval {}' for localized slurp

[public-inbox.git] / script / public-inbox-learn

diff --git a/script/public-inbox-learn b/script/public-inbox-learn
index 3073294a18bb526138d24e6898325157726c9586..4c10b68b994506bd4949e197028bd7caa2d8a7f1 100644 (file)
--- a/script/public-inbox-learn
+++ b/script/public-inbox-learn
@@ -1,5 +1,5 @@
 #!/usr/bin/perl -w
-# Copyright (C) 2014-2019 all contributors <meta@public-inbox.org>
+# Copyright (C) 2014-2020 all contributors <meta@public-inbox.org>
 # License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
 #
 # Used for training spam (via SpamAssassin) and removing messages from a
@@ -20,9 +20,9 @@ if ($train !~ /\A(?:ham|spam|rm)\z/) {
 my $spamc = PublicInbox::Spamcheck::Spamc->new;
 my $pi_config = PublicInbox::Config->new;
 my $err;
-my $mime = PublicInbox::MIME->new(eval {
+my $mime = PublicInbox::MIME->new(do{
        local $/;
-       my $data = scalar <STDIN>;
+       my $data = <STDIN>;
        $data =~ s/\A[\r\n]*From [^\r\n]*\r?\n//s;
 
        if ($train ne 'rm') {
@@ -36,11 +36,11 @@ my $mime = PublicInbox::MIME->new(eval {
                };
                $err = $@;
        }
-       $data
+       \$data
 });
 
-sub remove_or_add ($$$) {
-       my ($ibx, $train, $addr) = @_;
+sub remove_or_add ($$$$) {
+       my ($ibx, $train, $mime, $addr) = @_;
 
        # We do not touch GIT_COMMITTER_* env here so we can track
        # who trained the message.
@@ -93,12 +93,12 @@ if ($train eq 'spam') {
        while (my ($addr, $ibx) = each %dests) {
                next unless ref($ibx); # $ibx may be 0
                next if $seen{"$ibx"}++;
-               remove_or_add($ibx, $train, $addr);
+               remove_or_add($ibx, $train, $mime, $addr);
        }
        my $dests = PublicInbox::MDA->inboxes_for_list_id($pi_config, $mime);
        for my $ibx (@$dests) {
                next if !$seen{"$ibx"}++;
-               remove_or_add($ibx, $train, $ibx->{-primary_address});
+               remove_or_add($ibx, $train, $mime, $ibx->{-primary_address});
        }
 }