t/config: test --get-urlmatch for git <2.26

[public-inbox.git] / t / config.t

diff --git a/t/config.t b/t/config.t
index 0866f264e151bffcabda1f9d1bb9055bdc48d33f..204fc79024f10f7da15d254f654adccaae7150ac 100644 (file)
--- a/t/config.t
+++ b/t/config.t
@@ -1,21 +1,32 @@
-# Copyright (C) 2014-2019 all contributors <meta@public-inbox.org>
+# Copyright (C) 2014-2020 all contributors <meta@public-inbox.org>
 # License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
 use strict;
 use warnings;
 use Test::More;
 use PublicInbox::Config;
-use File::Temp qw/tempdir/;
-my $tmpdir = tempdir('pi-config-XXXXXX', TMPDIR => 1, CLEANUP => 1);
+use PublicInbox::TestCommon;
+use PublicInbox::Import;
+my ($tmpdir, $for_destroy) = tmpdir();
 
 {
-       is(system(qw(git init -q --bare), $tmpdir), 0, "git init successful");
-       my @cmd = ('git', "--git-dir=$tmpdir", qw(config foo.bar), "hi\nhi");
-       is(system(@cmd), 0, "set config");
+       PublicInbox::Import::init_bare($tmpdir);
+       my $inboxdir = "$tmpdir/new\nline";
+       my @cmd = ('git', "--git-dir=$tmpdir",
+               qw(config publicinbox.foo.inboxdir), $inboxdir);
+       is(xsys(@cmd), 0, "set config");
 
        my $tmp = PublicInbox::Config->new("$tmpdir/config");
 
-       is("hi\nhi", $tmp->{"foo.bar"}, "config read correctly");
-       is("true", $tmp->{"core.bare"}, "used --bare repo");
+       is($tmp->{'publicinbox.foo.inboxdir'}, $inboxdir,
+               'config read correctly');
+       is($tmp->{'core.bare'}, 'true', 'init used --bare repo');
+
+       my @warn;
+       local $SIG{__WARN__} = sub { push @warn, @_ };
+       $tmp = PublicInbox::Config->new("$tmpdir/config");
+       is($tmp->lookup_name('foo'), undef, 'reject invalid inboxdir');
+       like("@warn", qr/^E:.*must not contain `\\n'/sm,
+               'warned about newline');
 }
 
 {
@@ -27,7 +38,7 @@ my $tmpdir = tempdir('pi-config-XXXXXX', TMPDIR => 1, CLEANUP => 1);
                'inboxdir' => '/home/pi/meta-main.git',
                'address' => [ 'meta@public-inbox.org' ],
                'domain' => 'public-inbox.org',
-               'url' => 'http://example.com/meta',
+               'url' => [ 'http://example.com/meta' ],
                -primary_address => 'meta@public-inbox.org',
                'name' => 'meta',
                feedmax => 25,
@@ -48,7 +59,7 @@ my $tmpdir = tempdir('pi-config-XXXXXX', TMPDIR => 1, CLEANUP => 1);
                'domain' => 'public-inbox.org',
                'name' => 'test',
                feedmax => 25,
-               'url' => 'http://example.com/test',
+               'url' => [ 'http://example.com/test' ],
                -httpbackend_limiter => undef,
                nntpserver => undef,
        }, "lookup matches expected output for test");
@@ -208,23 +219,39 @@ EOF
 }
 
 {
-       my $check_git = !!$ENV{CHECK_GIT_BOOL};
        for my $t (qw(TRUE true yes on 1 +1 -1 13 0x1 0x12 0X5)) {
-               is(PublicInbox::Config::_git_config_bool($t), 1, "$t is true");
-               if ($check_git) {
-                       is(`git -c test.val=$t config --bool test.val`,
-                               "true\n", "$t matches git-config behavior");
-               }
+               is(PublicInbox::Config::git_bool($t), 1, "$t is true");
+               is(xqx([qw(git -c), "test.val=$t",
+                       qw(config --bool test.val)]),
+                       "true\n", "$t matches git-config behavior");
        }
        for my $f (qw(FALSE false no off 0 +0 +000 00 0x00 0X0)) {
-               is(PublicInbox::Config::_git_config_bool($f), 0, "$f is false");
-               if ($check_git) {
-                       is(`git -c test.val=$f config --bool test.val`,
-                               "false\n", "$f matches git-config behavior");
-               }
+               is(PublicInbox::Config::git_bool($f), 0, "$f is false");
+               is(xqx([qw(git -c), "test.val=$f",
+                       qw(config --bool test.val)]),
+                       "false\n", "$f matches git-config behavior");
        }
-       is(PublicInbox::Config::_git_config_bool('bogus'), undef,
+       is(PublicInbox::Config::git_bool('bogus'), undef,
                'bogus is undef');
 }
 
+SKIP: {
+       # XXX wildcard match requires git 2.26+
+       require_git('1.8.5', 2) or
+               skip 'git 1.8.5+ required for --url-match', 2;
+       my $f = "$tmpdir/urlmatch";
+       open my $fh, '>', $f or BAIL_OUT $!;
+       print $fh <<EOF or BAIL_OUT $!;
+[imap "imap://mail.example.com"]
+       pollInterval = 9
+EOF
+       close $fh or BAIL_OUT;
+       local $ENV{PI_CONFIG} = $f;
+       my $cfg = PublicInbox::Config->new;
+       my $url = 'imap://mail.example.com/INBOX';
+       is($cfg->urlmatch('imap.pollInterval', $url), 9, 'urlmatch hit');
+       is($cfg->urlmatch('imap.idleInterval', $url), undef, 'urlmatch miss');
+};
+
+
 done_testing();