testcommon: spawn-aware system() and qx[] workalikes

[public-inbox.git] / t / edit.t

diff --git a/t/edit.t b/t/edit.t
index 122aa19f0b745d6d1dcd50632b57f718300553b8..d8833f9c64a1d01f2b81e72d809a692bfe3d75a8 100644 (file)
--- a/t/edit.t
+++ b/t/edit.t
@@ -1,22 +1,17 @@
-# Copyright (C) 2019 all contributors <meta@public-inbox.org>
+# Copyright (C) 2019-2020 all contributors <meta@public-inbox.org>
 # License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
 # edit frontend behavior test (t/replace.t for backend)
 use strict;
 use warnings;
 use Test::More;
-require './t/common.perl';
+use PublicInbox::TestCommon;
 require_git(2.6);
 require PublicInbox::Inbox;
 require PublicInbox::InboxWritable;
 require PublicInbox::Config;
 use PublicInbox::MID qw(mid_clean);
 
-my @mods = qw(DBI DBD::SQLite);
-foreach my $mod (@mods) {
-       eval "require $mod";
-       plan skip_all => "missing $mod for $0" if $@;
-};
-
+require_mods('DBD::SQLite');
 my ($tmpdir, $for_destroy) = tmpdir();
 my $inboxdir = "$tmpdir/v2";
 my $ibx = PublicInbox::Inbox->new({
@@ -123,7 +118,7 @@ $t = 'non-interactive editor failure'; {
 
 $t = 'mailEditor set in config'; {
        $in = $out = $err = '';
-       my $rc = system(qw(git config), "--file=$cfgfile",
+       my $rc = xsys(qw(git config), "--file=$cfgfile",
                        'publicinbox.maileditor',
                        "$^X -i -p -e 's/boolean prefix/bool pfx/'");
        is($rc, 0, 'set publicinbox.mailEditor');