#!perl -w
-# Copyright (C) 2020 all contributors <meta@public-inbox.org>
+# Copyright (C) 2020-2021 all contributors <meta@public-inbox.org>
# License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
use strict;
use Test::More;
my @classes = qw(PublicInbox::Eml);
SKIP: {
require_mods('Email::MIME', 1);
+ # TODO: Email::MIME behavior is not consistent in newer versions
+ # we need to evaluate and possibly adjust our behavior to decide
+ # between DWIM-ness with historical mail...
push @classes, 'PublicInbox::MIME';
};
use_ok $_ for @classes;
+sub mime_load ($) {
+ my ($path) = @_;
+ open(my $fh, '<', $path) or die "open $path: $!";
+ PublicInbox::MIME->new(\(do { local $/; <$fh> }));
+}
+
{
my $eml = PublicInbox::Eml->new(\(my $str = "a: b\n\nhi\n"));
is($str, "hi\n", '->new modified body like Email::Simple');
is($eml->body, "hi\n", '->body works');
is($eml->as_string, "a: b\n\nhi\n", '->as_string');
+ my $empty = PublicInbox::Eml->new("\n\n");
+ is($empty->as_string, "\n\n", 'empty message');
}
for my $cls (@classes) {
$eml->header_str_set('Subject', "\x{100}");
like($eml->header_raw('Subject'), qr/utf-8\?B\?/i,
'MIME-B encoded UTF-8 Subject');
- is_deeply([$eml->header_str('Subject')], [ "\x{100}" ],
+ is_deeply([$eml->header('Subject')], [ "\x{100}" ],
'got wide character back');
}
'', 'each_part can clobber body');
}
+if ('descend into message/rfc822') {
+ my $eml = eml_load 't/data/message_embed.eml';
+ my @parts;
+ $eml->each_part(sub {
+ my ($part, $level, @ex) = @{$_[0]};
+ push @parts, [ $part, $level, @ex ];
+ });
+ is(scalar(@parts), 6, 'got all parts');
+ like($parts[0]->[0]->body, qr/^testing embedded message harder\n/sm,
+ 'first part found');
+ is_deeply([ @{$parts[0]}[1..2] ], [ 1, '1' ],
+ 'got expected depth and level for part #0');
+ is($parts[1]->[0]->filename, 'embed2x.eml',
+ 'attachment filename found');
+ is_deeply([ @{$parts[1]}[1..2] ], [ 1, '2' ],
+ 'got expected depth and level for part #1');
+ is_deeply([ @{$parts[2]}[1..2] ], [ 2, '2.1' ],
+ 'got expected depth and level for part #2');
+ is_deeply([ @{$parts[3]}[1..2] ], [ 3, '2.1.1' ],
+ 'got expected depth and level for part #3');
+ is_deeply([ @{$parts[4]}[1..2] ], [ 3, '2.1.2' ],
+ 'got expected depth and level for part #4');
+ is($parts[4]->[0]->filename, 'test.eml',
+ 'another attachment filename found');
+ is_deeply([ @{$parts[5]}[1..2] ], [ 4, '2.1.2.1' ],
+ 'got expected depth and level for part #5');
+}
+
# body-less, boundary-less
for my $cls (@classes) {
my $call = 0;
is(scalar(@tmp), 1, 'got one part even w/o boundary');
is($tmp[0]->[0]->[0]->body, "hello world\n", 'body preserved');
is($tmp[0]->[0]->[1], 0, '$depth is zero');
- is($tmp[0]->[0]->[2], 0, '@idx is zero');
+ is($tmp[0]->[0]->[2], 1, '@idx is one');
}
# I guess the following only worked in PI::M because of a happy accident
is($eml->body, "");
}
+if ('body only') {
+ my $str = <<EOM;
+--- a/lib/PublicInbox/Eml.pm
++++ b/lib/PublicInbox/Eml.pm
+@@ -122,9 +122,10 @@ sub new {
+\x20
+EOM
+ my $eml = PublicInbox::Eml->new($str);
+ is($eml->body, $str, 'body-only accepted');
+}
+
for my $cls (@classes) { # XXX: matching E::M, but not sure about this
my $s = <<EOF;
Content-Type: multipart/mixed; boundary="b"
}
for my $cls (@classes) {
+SKIP: {
+ skip 'newer Email::MIME behavior inconsistent', 1 if
+ $cls eq 'PublicInbox::MIME';
my $s = <<EOF; # buggy git-send-email versions, again?
Content-Type: text/plain; =?ISO-8859-1?Q?=20charset=3D=1BOF?=
Content-Transfer-Encoding: 8bit
EOF
my $eml = $cls->new(\$s);
my ($str, $err) = msg_part_text($eml, $eml->content_type);
- is($str, "\x{100}\n", "got wide character by assuming utf-8");
+ is($str, "\x{100}\n", "got wide character by assuming utf-8 ($cls)");
+} # SKIP
}
if ('we differ from Email::MIME with final "\n" on missing epilogue') {
'final "\n" preserved on missing epilogue');
}
+if ('header_size_limit stolen from postfix') {
+ local $PublicInbox::Eml::header_size_limit = 4;
+ my @w;
+ local $SIG{__WARN__} = sub { push @w, @_ };
+ my $eml = PublicInbox::Eml->new("a:b\na:d\n\nzz");
+ is_deeply([$eml->header('a')], ['b'], 'no overrun header');
+ is($eml->body_raw, 'zz', 'body not damaged');
+ is($eml->header_obj->as_string, "a:b\n", 'header truncated');
+ is(grep(/truncated/, @w), 1, 'truncation warned');
+
+ $eml = PublicInbox::Eml->new("a:b\na:d\n");
+ is_deeply([$eml->header('a')], ['b'], 'no overrun header w/o body');
+
+ local $PublicInbox::Eml::header_size_limit = 5;
+ $eml = PublicInbox::Eml->new("a:b\r\na:d\r\n\nzz");
+ is_deeply([$eml->header('a')], ['b'], 'no overrun header on CRLF');
+ is($eml->body_raw, 'zz', 'body not damaged');
+
+ @w = ();
+ $eml = PublicInbox::Eml->new("too:long\n");
+ $eml = PublicInbox::Eml->new("too:long\n\n");
+ $eml = PublicInbox::Eml->new("too:long\r\n\r\n");
+ is(grep(/ignored/, @w), 3, 'ignored header warned');
+}
+
if ('maxparts is a feature unique to us') {
my $eml = eml_load 't/psgi_attach.eml';
my @orig;
$eml->each_part(sub { push @orig, $_[0]->[0] });
- local $PublicInbox::Eml::MAXPARTS = scalar(@orig);
+ local $PublicInbox::Eml::mime_parts_limit = scalar(@orig);
my $i = 0;
$eml->each_part(sub {
my $cur = $_[0]->[0];
is($cur->body_raw, $prv->body_raw, "part #$i matches");
});
is($i, scalar(@orig), 'maxparts honored');
- $PublicInbox::Eml::MAXPARTS--;
+ $PublicInbox::Eml::mime_parts_limit--;
my @ltd;
$eml->each_part(sub { push @ltd, $_[0]->[0] });
for ($i = 0; $i <= $#ltd; $i++) {
$msg->parts_set([$old[-1]]);
is(scalar $msg->subparts, 1, 'only last remains');
}
- is($eml->as_string, $mime->as_string,
- 'as_string matches after parts_set');
+
+ # some versions of Email::MIME or Email::MIME::* will drop
+ # unnecessary ", while PublicInbox::Eml will preserve the original
+ my $exp = $mime->as_string;
+ $exp =~ s/; boundary=b\b/; boundary="b"/;
+ is($eml->as_string, $exp, 'as_string matches after parts_set');
}
for my $cls (@classes) {
Content-Disposition: attachment; filename="=?utf-8?q?vtpm-makefile.patch?="
EOF
- is($cls->new($s)->filename, 'vtpm-makefile.patch', 'filename decoded');
+ is($cls->new($s)->filename, 'vtpm-makefile.patch',
+ "filename decoded ($cls)") if $cls ne 'PublicInbox::MIME';
$s =~ s/^Content-Disposition:.*$//sm;
- is($cls->new($s)->filename, 'vtpm-fakefile.patch', 'filename fallback');
+ is($cls->new($s)->filename, 'vtpm-fakefile.patch',
+ "filename fallback ($cls)") if $cls ne 'PublicInbox::MIME';
is($cls->new($s)->content_type,
'text/x-patch; name="vtpm-fakefile.patch"',
- 'matches Email::MIME output, "correct" or not');
+ qq[matches Email::MIME output, "correct" or not ($cls)]);
$s = <<'EOF';
Content-Type: multipart/foo; boundary=b
b
--b--
EOF
- my @tmp;
- $cls->new($s)->each_part(sub { push @tmp, $_[0]->[0]->filename });
- is_deeply(['vtpm-makefile.patch', 'vtpm-fakefile.patch'], \@tmp,
- 'got filename for both attachments');
+ SKIP: {
+ skip 'newer Email::MIME is inconsistent here', 1
+ if $cls eq 'PublicInbox::MIME';
+ my @x;
+ $cls->new($s)->each_part(sub { push @x, $_[0]->[0]->filename });
+ is_deeply(['vtpm-makefile.patch', 'vtpm-fakefile.patch'], \@x,
+ "got filename for both attachments ($cls)");
+ }
}
done_testing;