t/cmd_ipc: allow extra errors and add diagnostics

[public-inbox.git] / t / git.t

diff --git a/t/git.t b/t/git.t
index 2cfff248a01e6f51a3d838c01e9d17c3cff793a1..844e0111f367fe10e6a037126ac9f0e7be1bd2f4 100644 (file)
--- a/t/git.t
+++ b/t/git.t
@@ -1,12 +1,11 @@
-# Copyright (C) 2015-2020 all contributors <meta@public-inbox.org>
+# Copyright (C) 2015-2021 all contributors <meta@public-inbox.org>
 # License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
 use strict;
-use warnings;
 use Test::More;
 use PublicInbox::TestCommon;
 my ($dir, $for_destroy) = tmpdir();
-use PublicInbox::Spawn qw(popen_rd);
 use PublicInbox::Import;
+use POSIX qw(strftime);
 
 use_ok 'PublicInbox::Git';
 
@@ -19,6 +18,20 @@ use_ok 'PublicInbox::Git';
        xsys([qw(git fast-import --quiet)], { GIT_DIR => $dir }, $rdr);
        is($?, 0, 'fast-import succeeded');
 }
+{
+       my $git = PublicInbox::Git->new($dir);
+       my @s = $git->date_parse('1970-01-01T00:00:00Z');
+       is($s[0], 0, 'parsed epoch');
+       local $ENV{TZ} = 'UTC';
+       @s = $git->date_parse('1993-10-02 01:02:09', '2010-10-02 01:03:04');
+       is(strftime('%Y-%m-%dT%H:%M:%SZ', gmtime($s[0])),
+               '1993-10-02T01:02:09Z', 'round trips');
+       is(strftime('%Y-%m-%dT%H:%M:%SZ', gmtime($s[1])),
+               '2010-10-02T01:03:04Z', '2nd arg round trips');
+       @s = $git->date_parse('1993-10-02');
+       is(strftime('%Y-%m-%d', gmtime($s[0])), '1993-10-02',
+               'round trips date-only');
+}
 
 {
        my $gcf = PublicInbox::Git->new($dir);
@@ -70,10 +83,10 @@ if (1) {
        chomp $buf;
 
        my $gcf = PublicInbox::Git->new($dir);
-       my $rsize;
-       my $x = $gcf->cat_file($buf, \$rsize);
-       is($rsize, $size, 'got correct size ref on big file');
-       is(length($$x), $size, 'read correct number of bytes');
+       my @x = $gcf->cat_file($buf);
+       is($x[2], 'blob', 'got blob on wantarray');
+       is($x[3], $size, 'got correct size ref on big file');
+       is(length(${$x[0]}), $size, 'read correct number of bytes');
 
        my $ref = $gcf->qx(qw(cat-file blob), $buf);
        is($?, 0, 'no error on scalar success');
@@ -85,8 +98,10 @@ if (1) {
 
        $gcf->qx(qw(repack -adq));
        ok($gcf->packed_bytes > 0, 'packed size is positive');
-       $gcf->qx(qw(rev-parse --verify bogus));
-       isnt($?, 0, '$? set on failure'.$?);
+       my $rdr;
+       open $rdr->{2}, '+>', '/dev/null' or xbail "open $!";
+       $gcf->qx([qw(rev-parse --verify bogus)], undef, $rdr);
+       isnt($?, 0, '$? set on failure: '.$?);
 }
 
 SKIP: {
@@ -155,5 +170,7 @@ is(git_quote($s = "Eléanor"), '"El\\303\\251anor"', 'quoted octal');
 is(git_quote($s = "hello\"world"), '"hello\"world"', 'quoted dq');
 is(git_quote($s = "hello\\world"), '"hello\\\\world"', 'quoted backslash');
 is(git_quote($s = "hello\nworld"), '"hello\\nworld"', 'quoted LF');
+is(git_quote($s = "hello\x06world"), '"hello\\006world"', 'quoted \\x06');
+is(git_unquote($s = '"hello\\006world"'), "hello\x06world", 'unquoted \\x06');
 
 done_testing();