t/httpd-corner: check for leaking FDs and pipes

[public-inbox.git] / t / httpd-corner.t

diff --git a/t/httpd-corner.t b/t/httpd-corner.t
index 13befcf1decf5c7651ad2591d7cdb29daaf91bd9..af838628717d94ca2e70e750ca7cc3def718bda1 100644 (file)
--- a/t/httpd-corner.t
+++ b/t/httpd-corner.t
@@ -18,7 +18,7 @@ use File::Temp qw/tempdir/;
 use IO::Socket;
 use IO::Socket::UNIX;
 use Fcntl qw(:seek);
-use Socket qw(IPPROTO_TCP TCP_NODELAY);
+use Socket qw(IPPROTO_TCP TCP_NODELAY SOL_SOCKET);
 use POSIX qw(mkfifo);
 require './t/common.perl';
 my $tmpdir = tempdir('httpd-corner-XXXXXX', TMPDIR => 1, CLEANUP => 1);
@@ -28,15 +28,11 @@ my $err = "$tmpdir/stderr.log";
 my $out = "$tmpdir/stdout.log";
 my $httpd = 'blib/script/public-inbox-httpd';
 my $psgi = "./t/httpd-corner.psgi";
-my %opts = (
-       LocalAddr => '127.0.0.1',
-       ReuseAddr => 1,
-       Proto => 'tcp',
-       Type => SOCK_STREAM,
-       Listen => 1024,
-);
-my $sock = IO::Socket::INET->new(%opts);
-my $defer_accept_val;
+my $sock = tcp_server();
+
+# Make sure we don't clobber socket options set by systemd or similar
+# using socket activation:
+my ($defer_accept_val, $accf_arg);
 if ($^O eq 'linux') {
        setsockopt($sock, IPPROTO_TCP, Socket::TCP_DEFER_ACCEPT(), 5) or die;
        my $x = getsockopt($sock, IPPROTO_TCP, Socket::TCP_DEFER_ACCEPT());
@@ -45,14 +41,15 @@ if ($^O eq 'linux') {
        if ($defer_accept_val <= 0) {
                die "unexpected TCP_DEFER_ACCEPT value: $defer_accept_val";
        }
+} elsif ($^O eq 'freebsd' && system('kldstat -m accf_data >/dev/null') == 0) {
+       require PublicInbox::Daemon;
+       my $var = PublicInbox::Daemon::SO_ACCEPTFILTER();
+       $accf_arg = pack('a16a240', 'dataready', '');
+       setsockopt($sock, SOL_SOCKET, $var, $accf_arg) or die "setsockopt: $!";
 }
 
 my $upath = "$tmpdir/s";
-my $unix = IO::Socket::UNIX->new(
-       Listen => 1024,
-       Type => SOCK_STREAM,
-       Local => $upath
-);
+my $unix = unix_server($upath);
 ok($unix, 'UNIX socket created');
 my $pid;
 END { kill 'TERM', $pid if defined $pid };
@@ -100,7 +97,7 @@ my $spawn_httpd = sub {
        is(scalar(grep(/CLOSE FAIL/, @$after)), 1, 'body->close not called');
 }
 
-{
+SKIP: {
        my $conn = conn_for($sock, 'excessive header');
        $SIG{PIPE} = 'IGNORE';
        $conn->write("GET /callback HTTP/1.0\r\n");
@@ -160,14 +157,9 @@ my $spawn_httpd = sub {
 }
 
 sub conn_for {
-       my ($sock, $msg) = @_;
-       my $conn = IO::Socket::INET->new(
-                               PeerAddr => $sock->sockhost,
-                               PeerPort => $sock->sockport,
-                               Proto => 'tcp',
-                               Type => SOCK_STREAM);
+       my ($dest, $msg) = @_;
+       my $conn = tcp_connect($dest);
        ok($conn, "connected for $msg");
-       $conn->autoflush(1);
        setsockopt($conn, IPPROTO_TCP, TCP_NODELAY, 1);
        return $conn;
 }
@@ -254,9 +246,10 @@ SKIP: {
                $have_curl = 1;
                last;
        }
-       my $ntest = 2;
+       my $ntest = 4;
        $have_curl or skip('curl(1) missing', $ntest);
-       my $url = 'http://' . $sock->sockhost . ':' . $sock->sockport . '/sha1';
+       my $base = 'http://' . $sock->sockhost . ':' . $sock->sockport;
+       my $url = "$base/sha1";
        my ($r, $w);
        pipe($r, $w) or die "pipe: $!";
        my $cmd = [qw(curl --tcp-nodelay --no-buffer -T- -HExpect: -sS), $url];
@@ -273,6 +266,17 @@ SKIP: {
        is($?, 0, 'curl exited successfully');
        is($err, '', 'no errors from curl');
        is($out, sha1_hex($str), 'read expected body');
+
+       open my $fh, '-|', qw(curl -sS), "$base/async-big" or die $!;
+       my $n = 0;
+       my $non_zero = 0;
+       while (1) {
+               my $r = sysread($fh, my $buf, 4096) or last;
+               $n += $r;
+               $buf =~ /\A\0+\z/ or $non_zero++;
+       }
+       is($n, 30 * 1024 * 1024, 'got expected output from curl');
+       is($non_zero, 0, 'read all zeros');
 }
 
 {
@@ -515,6 +519,21 @@ SKIP: {
        is(unpack('i', $x), $defer_accept_val,
                'TCP_DEFER_ACCEPT unchanged if previously set');
 };
+SKIP: {
+       skip 'SO_ACCEPTFILTER is FreeBSD-only', 1 if $^O ne 'freebsd';
+       skip 'accf_data not loaded: kldload accf_data' if !defined $accf_arg;
+       my $var = PublicInbox::Daemon::SO_ACCEPTFILTER();
+       defined(my $x = getsockopt($sock, SOL_SOCKET, $var)) or die;
+       is($x, $accf_arg, 'SO_ACCEPTFILTER unchanged if previously set');
+};
+SKIP: {
+       use PublicInbox::Spawn qw(which);
+       skip 'only testing lsof(8) output on Linux', 1 if $^O ne 'linux';
+       skip 'no lsof in PATH', 1 unless which('lsof');
+       my @lsof = `lsof -p $pid`;
+       is_deeply([grep(/\bdeleted\b/, @lsof)], [], 'no lingering deleted inputs');
+       is_deeply([grep(/\bpipe\b/, @lsof)], [], 'no extra pipes with -W0');
+};
 
 done_testing();