remove most internal Email::MIME usage

[public-inbox.git] / t / import.t

diff --git a/t/import.t b/t/import.t
index e7733638f023fd4852963fe6d88b85da9f85e842..3f308299148f4e20ff8b947fc17bc68b4808ecf6 100644 (file)
--- a/t/import.t
+++ b/t/import.t
@@ -1,61 +1,58 @@
-# Copyright (C) 2016-2018 all contributors <meta@public-inbox.org>
+# Copyright (C) 2016-2020 all contributors <meta@public-inbox.org>
 # License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
 use strict;
 use warnings;
 use Test::More;
-use PublicInbox::MIME;
+use PublicInbox::Eml;
 use PublicInbox::Git;
 use PublicInbox::Import;
 use PublicInbox::Spawn qw(spawn);
-use IO::File;
-use Fcntl qw(:DEFAULT);
-use File::Temp qw/tempdir tempfile/;
-my $dir = tempdir('pi-import-XXXXXX', TMPDIR => 1, CLEANUP => 1);
-require './t/common.perl';
+use Fcntl qw(:DEFAULT SEEK_SET);
+use File::Temp qw/tempfile/;
+use PublicInbox::TestCommon;
+my ($dir, $for_destroy) = tmpdir();
 
-is(system(qw(git init -q --bare), $dir), 0, 'git init successful');
 my $git = PublicInbox::Git->new($dir);
-
 my $im = PublicInbox::Import->new($git, 'testbox', 'test@example');
-my $mime = PublicInbox::MIME->create(
-       header => [
-               From => 'a@example.com',
-               To => 'b@example.com',
-               'Content-Type' => 'text/plain',
-               Subject => 'this is a subject',
-               'Message-ID' => '<a@example.com>',
-               Date => 'Fri, 02 Oct 1993 00:00:00 +0000',
-       ],
-       body => "hello world\n",
-);
-my $v2 = require_git(2.6, 1);
+$im->init_bare;
+my $mime = PublicInbox::Eml->new(<<'EOF');
+From: a@example.com
+To: b@example.com
+Subject: this is a subject
+Message-ID: <a@example.com>
+Date: Fri, 02 Oct 1993 00:00:00 +0000
+
+hello world
+EOF
 
-$im->{want_object_info} = 1 if $v2;
-like($im->add($mime), qr/\A:\d+\z/, 'added one message');
+my $v2 = require_git(2.6, 1);
+my $smsg = {} if $v2;
+like($im->add($mime, undef, $smsg), qr/\A:[0-9]+\z/, 'added one message');
 
 if ($v2) {
-       my $info = $im->{last_object};
-       like($info->[0], qr/\A[a-f0-9]{40}\z/, 'got last object_id');
-       is($mime->as_string, ${$info->[2]}, 'string matches');
-       is($info->[1], length(${$info->[2]}), 'length matches');
+       like($smsg->{blob}, qr/\A[a-f0-9]{40}\z/, 'got last object_id');
+       is($mime->as_string, ${$smsg->{-raw_email}}, 'string matches');
+       is($smsg->{bytes}, length(${$smsg->{-raw_email}}), 'length matches');
        my @cmd = ('git', "--git-dir=$git->{git_dir}", qw(hash-object --stdin));
        my $in = tempfile();
        print $in $mime->as_string or die "write failed: $!";
        $in->flush or die "flush failed: $!";
-       $in->seek(0, SEEK_SET);
+       seek($in, 0, SEEK_SET);
        my $out = tempfile();
-       my $pid = spawn(\@cmd, {}, { 0 => fileno($in), 1 => fileno($out)});
+       my $pid = spawn(\@cmd, {}, { 0 => $in, 1 => $out });
        is(waitpid($pid, 0), $pid, 'waitpid succeeds on hash-object');
        is($?, 0, 'hash-object');
-       $out->seek(0, SEEK_SET);
+       seek($out, 0, SEEK_SET);
        chomp(my $hashed_obj = <$out>);
-       is($hashed_obj, $info->[0], "last object_id matches exp");
+       is($hashed_obj, $smsg->{blob}, "blob object_id matches exp");
 }
 
 $im->done;
 my @revs = $git->qx(qw(rev-list HEAD));
 is(scalar @revs, 1, 'one revision created');
 
+my $odd = '"=?iso-8859-1?Q?J_K=FCpper?= <usenet"@example.de';
+$mime->header_set('From', $odd);
 $mime->header_set('Message-ID', '<b@example.com>');
 $mime->header_set('Subject', 'msg2');
 like($im->add($mime, sub { $mime }), qr/\A:\d+\z/, 'added 2nd message');
@@ -78,7 +75,7 @@ $im->done;
 is(scalar @revs, 26, '26 revisions exist after mass import');
 my ($mark, $msg) = $im->remove($mime);
 like($mark, qr/\A:\d+\z/, 'got mark');
-is(ref($msg), 'PublicInbox::MIME', 'got old message deleted');
+like(ref($msg), qr/\bPublicInbox::(?:Eml|MIME)\b/, 'got old message deleted');
 
 is(undef, $im->remove($mime), 'remove is idempotent');
 
@@ -96,4 +93,12 @@ is(undef, $im->checkpoint, 'checkpoint works before ->done');
 $im->done;
 is(undef, $im->checkpoint, 'checkpoint works after ->done');
 $im->checkpoint;
+
+my $nogit = PublicInbox::Git->new("$dir/non-existent/dir");
+eval {
+       my $nope = PublicInbox::Import->new($nogit, 'nope', 'no@example.com');
+       $nope->add($mime);
+};
+ok($@, 'Import->add fails on non-existent dir');
+
 done_testing();