www: drop --subject from "git send-email" instructions

[public-inbox.git] / t / lei-daemon.t

diff --git a/t/lei-daemon.t b/t/lei-daemon.t
index c30e5ac17edfd814fdafa4cdb1820877d76c13bf..e11105bc7040c080f81483396d1a3d0ff1bbb0fd 100644 (file)
--- a/t/lei-daemon.t
+++ b/t/lei-daemon.t
@@ -1,27 +1,54 @@
 #!perl -w
-# Copyright (C) 2020-2021 all contributors <meta@public-inbox.org>
+# Copyright (C) all contributors <meta@public-inbox.org>
 # License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
 use strict; use v5.10.1; use PublicInbox::TestCommon;
+use Socket qw(AF_UNIX SOCK_SEQPACKET MSG_EOR pack_sockaddr_un);
 
 test_lei({ daemon_only => 1 }, sub {
+       my $send_cmd = PublicInbox::Spawn->can('send_cmd4') // do {
+               require PublicInbox::CmdIPC4;
+               PublicInbox::CmdIPC4->can('send_cmd4');
+       } // do {
+               require PublicInbox::Syscall;
+               PublicInbox::Syscall->can('send_cmd4');
+       };
+       $send_cmd or BAIL_OUT 'started testing lei-daemon w/o send_cmd4!';
+
        my $sock = "$ENV{XDG_RUNTIME_DIR}/lei/5.seq.sock";
        my $err_log = "$ENV{XDG_RUNTIME_DIR}/lei/errors.log";
        lei_ok('daemon-pid');
+       ignore_inline_c_missing($lei_err);
        is($lei_err, '', 'no error from daemon-pid');
        like($lei_out, qr/\A[0-9]+\n\z/s, 'pid returned') or BAIL_OUT;
        chomp(my $pid = $lei_out);
        ok(kill(0, $pid), 'pid is valid');
        ok(-S $sock, 'sock created');
        is(-s $err_log, 0, 'nothing in errors.log');
-       open my $efh, '>>', $err_log or BAIL_OUT $!;
-       print $efh "phail\n" or BAIL_OUT $!;
-       close $efh or BAIL_OUT $!;
-
        lei_ok('daemon-pid');
        chomp(my $pid_again = $lei_out);
        is($pid, $pid_again, 'daemon-pid idempotent');
-       like($lei_err, qr/phail/, 'got mock "phail" error previous run');
 
+       SKIP: {
+               skip 'only testing open files on Linux', 1 if $^O ne 'linux';
+               my $d = "/proc/$pid/fd";
+               skip "no $d on Linux" unless -d $d;
+               my @before = sort(glob("$d/*"));
+               my $addr = pack_sockaddr_un($sock);
+               open my $null, '<', '/dev/null' or BAIL_OUT "/dev/null: $!";
+               my @fds = map { fileno($null) } (0..2);
+               for (0..10) {
+                       socket(my $c, AF_UNIX, SOCK_SEQPACKET, 0) or
+                                                       BAIL_OUT "socket: $!";
+                       connect($c, $addr) or BAIL_OUT "connect: $!";
+                       $send_cmd->($c, \@fds, 'hi',  MSG_EOR);
+               }
+               lei_ok('daemon-pid');
+               chomp($pid = $lei_out);
+               is($pid, $pid_again, 'pid unchanged after failed reqs');
+               my @after = sort(glob("$d/*"));
+               is_deeply(\@before, \@after, 'open files unchanged') or
+                       diag explain([\@before, \@after]);;
+       }
        lei_ok(qw(daemon-kill));
        is($lei_out, '', 'no output from daemon-kill');
        is($lei_err, '', 'no error from daemon-kill');
@@ -44,14 +71,6 @@ test_lei({ daemon_only => 1 }, sub {
        lei_ok('daemon-pid');
        chomp $lei_out;
        is($lei_out, $new_pid, 'PID unchanged after -0/-CHLD');
-
-       if ('socket inaccessible') {
-               chmod 0000, $sock or BAIL_OUT "chmod 0000: $!";
-               lei_ok('help', \'connect fail, one-shot fallback works');
-               like($lei_err, qr/\bconnect\(/, 'connect error noted');
-               like($lei_out, qr/^usage: /, 'help output works');
-               chmod 0700, $sock or BAIL_OUT "chmod 0700: $!";
-       }
        unlink $sock or BAIL_OUT "unlink($sock) $!";
        for (0..100) {
                kill('CHLD', $new_pid) or last;