over: rename ->disconnect to ->dbh_close

[public-inbox.git] / t / over.t

diff --git a/t/over.t b/t/over.t
index 07672aa70a2e56c34ba3e83390f2899b7b3b6da8..41c13872c4e94095cede8b3eddd08e839a7085c7 100644 (file)
--- a/t/over.t
+++ b/t/over.t
@@ -9,7 +9,7 @@ require_mods('DBD::SQLite');
 use_ok 'PublicInbox::OverIdx';
 my ($tmpdir, $for_destroy) = tmpdir();
 my $over = PublicInbox::OverIdx->new("$tmpdir/over.sqlite3");
-$over->connect;
+$over->dbh; # open file
 is($over->max, 0, 'max is zero on new DB (scalar context)');
 is_deeply([$over->max], [0], 'max is zero on new DB (list context)');
 my $x = $over->next_tid;
@@ -23,14 +23,13 @@ $y = $over->sid('hello-WORLD');
 is($y, $x+1, 'sid increases');
 is($over->sid('hello-world'), $x, 'idempotent');
 ok(!$over->{dbh}->{ReadOnly}, 'OverIdx is not ReadOnly');
-$over->disconnect;
+$over->dbh_close;
 
 $over = PublicInbox::Over->new("$tmpdir/over.sqlite3");
-$over->connect;
-ok($over->{dbh}->{ReadOnly}, 'Over is ReadOnly');
+ok($over->dbh->{ReadOnly}, 'Over is ReadOnly');
 
 $over = PublicInbox::OverIdx->new("$tmpdir/over.sqlite3");
-$over->connect;
+$over->dbh;
 is($over->sid('hello-world'), $x, 'idempotent across reopen');
 $over->each_by_mid('never', sub { fail('should not be called') });
 
@@ -65,4 +64,14 @@ isnt($over->max, 0, 'max is non-zero');
 
 $over->rollback_lazy;
 
+# L<perldata/"Version Strings">
+my $v = eval 'v'.$over->{dbh}->{sqlite_version};
+SKIP: {
+       skip("no WAL in SQLite version $v < 3.7.0", 1) if $v lt v3.7.0;
+       $over->{dbh}->do('PRAGMA journal_mode = WAL');
+       $over = PublicInbox::OverIdx->new("$tmpdir/over.sqlite3");
+       is($over->dbh->selectrow_array('PRAGMA journal_mode'), 'wal',
+               'WAL journal_mode not clobbered if manually set');
+}
+
 done_testing();