run update-copyrights from gnulib for 2019

[public-inbox.git] / t / perf-nntpd.t

diff --git a/t/perf-nntpd.t b/t/perf-nntpd.t
index e5021532096e3ed53ae7cf123d6b554d3ce02285..f272e18add0c13c046c8836e9bd5b5ab47a0a151 100644 (file)
--- a/t/perf-nntpd.t
+++ b/t/perf-nntpd.t
@@ -1,4 +1,4 @@
-# Copyright (C) 2018 all contributors <meta@public-inbox.org>
+# Copyright (C) 2018-2019 all contributors <meta@public-inbox.org>
 # License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
 use strict;
 use warnings;
@@ -6,13 +6,13 @@ use Test::More;
 use Benchmark qw(:all :hireswallclock);
 use PublicInbox::Inbox;
 use File::Temp qw/tempdir/;
-use POSIX qw(dup2);
-use Fcntl qw(FD_CLOEXEC F_SETFD F_GETFD);
 use Net::NNTP;
 my $pi_dir = $ENV{GIANT_PI_DIR};
 plan skip_all => "GIANT_PI_DIR not defined for $0" unless $pi_dir;
 eval { require PublicInbox::Search };
 my ($host_port, $group, %opts, $s, $pid);
+require './t/common.perl';
+
 END {
        if ($s) {
                $s->print("QUIT\r\n");
@@ -44,30 +44,10 @@ if (($ENV{NNTP_TEST_URL} || '') =~ m!\Anntp://([^/]+)/([^/]+)\z!) {
                close $fh or die "close($pi_config): $!";
        }
 
-       %opts = (
-               LocalAddr => '127.0.0.1',
-               ReuseAddr => 1,
-               Proto => 'tcp',
-               Listen => 1024,
-       );
-       my $sock = IO::Socket::INET->new(%opts);
-
+       my $sock = tcp_server();
        ok($sock, 'sock created');
-       $! = 0;
-       $pid = fork;
-       if ($pid == 0) {
-               # pretend to be systemd
-               my $fl = fcntl($sock, F_GETFD, 0);
-               dup2(fileno($sock), 3) or die "dup2 failed: $!\n";
-               dup2(1, 2) or die "dup2 failed: $!\n";
-               fcntl($sock, F_SETFD, $fl &= ~FD_CLOEXEC);
-               $ENV{LISTEN_PID} = $$;
-               $ENV{LISTEN_FDS} = 1;
-               $ENV{PI_CONFIG} = $pi_config;
-               exec $nntpd, '-W0';
-               die "FAIL: $!\n";
-       }
-       ok(defined $pid, 'forked nntpd process successfully');
+       my $cmd = [ $nntpd, '-W0' ];
+       $pid = spawn_listener({ PI_CONFIG => $pi_config }, $cmd, [$sock]);
        $host_port = $sock->sockhost . ':' . $sock->sockport;
 }
 %opts = (
@@ -78,7 +58,7 @@ if (($ENV{NNTP_TEST_URL} || '') =~ m!\Anntp://([^/]+)/([^/]+)\z!) {
 $s = IO::Socket::INET->new(%opts);
 $s->autoflush(1);
 my $buf = $s->getline;
-is($buf, "201 server ready - post via email\r\n", 'got greeting');
+like($buf, qr/\A201 .* ready - post via email\r\n/s, 'got greeting');
 
 my $t = timeit(10, sub {
        ok($s->print("GROUP $group\r\n"), 'changed group');
@@ -121,7 +101,7 @@ diag "XHDR From ". timestr($t) . " for $n";
 my $date = $ENV{NEWNEWS_DATE};
 unless ($date) {
        my (undef, undef, undef, $d, $m, $y) = gmtime(time - 30 * 86400);
-       $date = sprintf('%04u%02u%02u', $y + 1900, $m, $d);
+       $date = sprintf('%04u%02u%02u', $y + 1900, $m + 1, $d);
        diag "NEWNEWS_DATE undefined, using $date";
 }
 $t = timeit(1, sub {