www: drop --subject from "git send-email" instructions

[public-inbox.git] / t / psgi_v2.t

diff --git a/t/psgi_v2.t b/t/psgi_v2.t
index 487317b6134046d3a98b80a6caa3f5cf5bb38e8f..7d73b606dbef5f0ad736cc57ddaef5b5d222e4b8 100644 (file)
--- a/t/psgi_v2.t
+++ b/t/psgi_v2.t
@@ -9,7 +9,7 @@ use PublicInbox::Eml;
 use PublicInbox::Config;
 use PublicInbox::MID qw(mids);
 require_mods(qw(DBD::SQLite Search::Xapian HTTP::Request::Common Plack::Test
-               URI::Escape Plack::Builder));
+               URI::Escape Plack::Builder HTTP::Date));
 use_ok($_) for (qw(HTTP::Request::Common Plack::Test));
 use_ok 'PublicInbox::WWW';
 my ($tmpdir, $for_destroy) = tmpdir();
@@ -20,11 +20,12 @@ To: test@example.com
 Subject: this is a subject
 Message-ID: <a-mid@b>
 Date: Fri, 02 Oct 1993 00:00:00 +0000
+Content-Type: text/plain; charset=iso-8859-1
 
 hello world
 EOF
 my $new_mid;
-my $ibx = create_inbox 'v2', version => 2, indexlevel => 'medium',
+my $ibx = create_inbox 'v2-1', version => 2, indexlevel => 'medium',
                        tmpdir => "$tmpdir/v2", sub {
        my ($im, $ibx) = @_;
        $im->add($eml) or BAIL_OUT;
@@ -56,27 +57,6 @@ EOF
        close $fh or BAIL_OUT;
 }
 
-my $run_httpd = sub {
-       my ($client, $skip) = @_;
-       SKIP: {
-               require_mods(qw(Plack::Test::ExternalServer), $skip);
-               my $env = { PI_CONFIG => $cfgpath };
-               my $sock = tcp_server() or die;
-               my ($out, $err) = map { "$tmpdir/std$_.log" } qw(out err);
-               my $cmd = [ qw(-httpd -W0), "--stdout=$out", "--stderr=$err" ];
-               my $td = start_script($cmd, $env, { 3 => $sock });
-               my ($h, $p) = tcp_host_port($sock);
-               local $ENV{PLACK_TEST_EXTERNALSERVER_URI} = "http://$h:$p";
-               Plack::Test::ExternalServer::test_psgi(client => $client);
-               $td->join('TERM');
-               open my $fh, '<', $err or BAIL_OUT $!;
-               my $e = do { local $/; <$fh> };
-               if ($e =~ s/^Plack::Middleware::ReverseProxy missing,\n//gms) {
-                       $e =~ s/^URL generation for redirects .*\n//gms;
-               }
-               is($e, '', 'no errors');
-       }
-};
 my $msg = $ibx->msg_by_mid('a-mid@b');
 like($$msg, qr/\AFrom oldbug/s,
        '"From_" line stored to test old bug workaround');
@@ -89,6 +69,8 @@ my $client0 = sub {
        like($res->content, qr!\$INBOX_DIR/description missing!,
                'got v2 description missing message');
        $res = $cb->(GET('/v2test/a-mid@b/raw'));
+       is($res->header('Content-Type'), 'text/plain; charset=iso-8859-1',
+               'charset from message used');
        $raw = $res->content;
        unlike($raw, qr/^From oldbug/sm, 'buggy "From_" line omitted');
        like($raw, qr/^hello world$/m, 'got first message');
@@ -113,9 +95,15 @@ my $client0 = sub {
        @bodies = ($res->content =~ /^(hello [^<]+)$/mg);
        is_deeply(\@bodies, [ "hello world!\n", "hello world\n" ],
                'new.html ordering is chronological');
+
+       $res = $cb->(GET('/v2test/new.atom'));
+       my @dates = ($res->content =~ m!title><updated>([^<]+)</updated>!g);
+       is_deeply(\@dates, [ "1993-10-02T00:01:00Z", "1993-10-02T00:00:00Z" ],
+               'Date headers made it through');
 };
 test_psgi(sub { $www->call(@_) }, $client0);
-$run_httpd->($client0, 9);
+my $env = { TMPDIR => $tmpdir, PI_CONFIG => $cfgpath };
+test_httpd($env, $client0, 9);
 
 $eml->header_set('Message-ID', 'a-mid@b');
 $eml->body_set("hello ghosts\n");
@@ -133,6 +121,14 @@ $im->done;
 
 my $client1 = sub {
        my ($cb) = @_;
+       $res = $cb->(GET('/v2test/_/text/config/raw'));
+       my $lm = $res->header('Last-Modified');
+       ok($lm, 'Last-Modified set w/ ->mm');
+       $lm = HTTP::Date::str2time($lm);
+       is($lm, $ibx->mm->created_at,
+               'Last-Modified for text/config/raw matches ->created_at');
+       delete $ibx->{mm};
+
        $res = $cb->(GET("/v2test/$third/raw"));
        $raw = $res->content;
        like($raw, qr/^hello ghosts$/m, 'got third message');
@@ -225,7 +221,7 @@ my $client1 = sub {
 };
 
 test_psgi(sub { $www->call(@_) }, $client1);
-$run_httpd->($client1, 38);
+test_httpd($env, $client1, 38);
 
 {
        my $exp = [ qw(<a-mid@b> <reuse@mid>) ];
@@ -267,7 +263,7 @@ my $client2 = sub {
 };
 
 test_psgi(sub { $www->call(@_) }, $client2);
-$run_httpd->($client2, 8);
+test_httpd($env, $client2, 8);
 {
        # ensure conflicted attachments can be resolved
        local $SIG{__WARN__} = sub {};
@@ -298,6 +294,6 @@ my $client3 = sub {
        is_deeply(\@warn, [], 'no warnings on YYYYMMDD only');
 };
 test_psgi(sub { $www->call(@_) }, $client3);
-$run_httpd->($client3, 4);
+test_httpd($env, $client3, 4);
 
 done_testing;