-# Copyright (C) 2015-2021 all contributors <meta@public-inbox.org>
+#!perl -w
+# Copyright (C) all contributors <meta@public-inbox.org>
# License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
-use strict;
-use warnings;
+use v5.12;
use Test::More;
use PublicInbox::Spawn qw(which spawn popen_rd);
-use PublicInbox::Sigfd;
-use Socket qw(AF_UNIX SOCK_STREAM);
-
-SKIP: {
- my $recv_3fds = PublicInbox::Spawn->can('recv_3fds');
- my $send_3fds = PublicInbox::Spawn->can('send_3fds');
- skip 'Inline::C not enabled', 3 unless $send_3fds && $recv_3fds;
- my ($s1, $s2);
- socketpair($s1, $s2, AF_UNIX, SOCK_STREAM, 0) or BAIL_OUT $!;
- pipe(my ($r, $w)) or BAIL_OUT $!;
- my @orig = ($r, $w, $s2);
- my @fd = map { fileno($_) } @orig;
- ok($send_3fds->(fileno($s1), $fd[0], $fd[1], $fd[2]),
- 'FDs sent');
- my (@fds) = $recv_3fds->(fileno($s2));
- is(scalar(@fds), 3, 'got 3 fds');
- use Data::Dumper; diag Dumper(\@fds);
- is(scalar(grep(/\A\d+\z/, @fds)), 3, 'all valid FDs');
- my $i = 0;
- my @cmp = map {
- open my $new, $_, shift(@fds) or BAIL_OUT "open $! $i => $_";
- ($new, shift(@orig), $i++);
- } (qw(<&= >&= +<&=));
- while (my ($new, $old, $fd) = splice(@cmp, 0, 3)) {
- my @new = stat($new);
- my @old = stat($old);
- is("$old[0]\0$old[1]", "$new[0]\0$new[1]",
- "device/inode matches on received FD:$fd");
- }
-}
+require PublicInbox::Sigfd;
+require PublicInbox::DS;
{
my $true = which('true');
is($?, 0, 'true exited successfully');
}
+SKIP: {
+ my $pid = spawn(['true'], undef, { pgid => 0 });
+ ok($pid, 'spawned process with new pgid');
+ is(waitpid($pid, 0), $pid, 'waitpid succeeds on spawned process');
+ is($?, 0, 'true exited successfully');
+ pipe(my ($r, $w)) or BAIL_OUT;
+
+ # Find invalid PID to try to join its process group.
+ my $wrong_pgid = 1;
+ for (my $i=0x7fffffff; $i >= 2; $i--) {
+ if (kill(0, $i) == 0) {
+ $wrong_pgid = $i;
+ last;
+ }
+ }
+
+ # Test spawn behavior when it can't join the requested process group.
+ $pid = eval { spawn(['true'], undef, { pgid => $wrong_pgid, 2 => $w }) };
+ close $w;
+ my $err = do { local $/; <$r> };
+ if (defined $pid) {
+ waitpid($pid, 0);
+ isnt($?, 0, 'child error (pure-Perl)');
+ } else {
+ ok($@, 'exception raised');
+ }
+}
+
{ # ensure waitpid(-1, 0) and SIGCHLD works in spawned process
my $script = <<'EOF';
$| = 1; # unbuffer stdout
select(undef, undef, undef, 0.01) while 1;
}
EOF
- my $oldset = PublicInbox::Sigfd::block_signals();
+ my $oldset = PublicInbox::DS::block_signals();
my $rd = popen_rd([$^X, '-e', $script]);
diag 'waiting for child to reap grandchild...';
chomp(my $line = readline($rd));
- my ($rdy, $pid) = split(' ', $line);
+ my ($rdy, $pid) = split(/ /, $line);
is($rdy, 'RDY', 'got ready signal, waitpid(-1) works in child');
ok(kill('CHLD', $pid), 'sent SIGCHLD to child');
is(readline($rd), "HI\n", '$SIG{CHLD} works in child');
ok(close $rd, 'popen_rd close works');
- PublicInbox::Sigfd::sig_setmask($oldset);
+ PublicInbox::DS::sig_setmask($oldset);
}
{
{
my $fh = popen_rd([qw(printf foo\nbar)]);
ok(fileno($fh) >= 0, 'tied fileno works');
+ my $tfh = (tied *$fh)->{fh};
+ is($tfh->blocking(0), 1, '->blocking was true');
+ is($tfh->blocking, 0, '->blocking is false');
+ is($tfh->blocking(1), 0, '->blocking was true');
+ is($tfh->blocking, 1, '->blocking is true');
my @line = <$fh>;
is_deeply(\@line, [ "foo\n", 'bar' ], 'wantarray works on readline');
}
isnt($?, 0, '$? set properly: '.$?);
}
+{
+ local $ENV{GIT_CONFIG} = '/path/to/this/better/not/exist';
+ my $fh = popen_rd([qw(env)], { GIT_CONFIG => undef });
+ ok(!grep(/^GIT_CONFIG=/, <$fh>), 'GIT_CONFIG clobbered');
+}
+
{ # ->CLOSE vs ->DESTROY waitpid caller distinction
my @c;
- my $fh = popen_rd(['true'], undef, { cb => sub { @c = caller } });
+ my $fh = popen_rd(['true'], undef, { cb_arg => [sub { @c = caller }] });
ok(close($fh), '->CLOSE fired and successful');
ok(scalar(@c), 'callback fired by ->CLOSE');
ok(grep(!m[/PublicInbox/DS\.pm\z], @c), 'callback not invoked by DS');
@c = ();
- $fh = popen_rd(['true'], undef, { cb => sub { @c = caller } });
+ $fh = popen_rd(['true'], undef, { cb_arg => [sub { @c = caller }] });
undef $fh; # ->DESTROY
ok(scalar(@c), 'callback fired by ->DESTROY');
ok(grep(!m[/PublicInbox/ProcessPipe\.pm\z], @c),
{ # children don't wait on siblings
use POSIX qw(_exit);
pipe(my ($r, $w)) or BAIL_OUT $!;
- my $cb = sub { warn "x=$$\n" };
- my $fh = popen_rd(['cat'], undef, { 0 => $r, cb => $cb });
+ my @arg;
+ my $cb = [ sub { @arg = @_; warn "x=$$\n" }, 'hi' ];
+ my $fh = popen_rd(['cat'], undef, { 0 => $r, cb_arg => $cb });
my $pp = tied *$fh;
my $pid = fork // BAIL_OUT $!;
local $SIG{__WARN__} = sub { _exit(1) };
close $w;
close $fh;
is($?, 0, 'cat exited');
+ is(scalar(@arg), 2, 'callback got args');
+ is($arg[1], 'hi', 'passed arg');
+ like($arg[0], qr/\A\d+\z/, 'PID');
is_deeply(\@w, [ "x=$$\n" ], 'callback fired from owner');
}
isnt($?, 0, 'non-zero exit status');
}
-done_testing();
+SKIP: {
+ require PublicInbox::SpawnPP;
+ require File::Temp;
+ my $tmp = File::Temp->newdir('spawnpp-XXXX', TMPDIR => 1);
+ my $cmd = [ qw(/bin/sh -c), 'echo $HI >foo' ];
+ my $env = [ 'HI=hihi' ];
+ my $rlim = [];
+ my $pgid = -1;
+ my $pid = PublicInbox::SpawnPP::pi_fork_exec([], '/bin/sh', $cmd, $env,
+ $rlim, "$tmp", $pgid);
+ is(waitpid($pid, 0), $pid, 'spawned process exited');
+ is($?, 0, 'no error');
+ open my $fh, '<', "$tmp/foo" or die "open: $!";
+ is(readline($fh), "hihi\n", 'env+chdir worked for SpawnPP');
+ close $fh;
+ unlink("$tmp/foo") or die "unlink: $!";
+ {
+ local $ENV{MOD_PERL} = 1;
+ $pid = PublicInbox::SpawnPP::pi_fork_exec([],
+ '/bin/sh', $cmd, $env, $rlim, "$tmp", $pgid);
+ }
+ is(waitpid($pid, 0), $pid, 'spawned process exited');
+ open $fh, '<', "$tmp/foo" or die "open: $!";
+ is(readline($fh), "hihi\n", 'env+chdir SpawnPP under (faked) MOD_PERL');
+}
-1;
+done_testing();