]> Sergey Matveev's repositories - public-inbox.git/blobdiff - t/watch_maildir.t
watch: improve fairness during full rescans
[public-inbox.git] / t / watch_maildir.t
index 6564a8665830f2881d88c83ca6861fc4e98ad3a2..e12e0836b824d3f6b7141d31194f1dd48c9f8429 100644 (file)
@@ -3,11 +3,18 @@
 use Test::More;
 use File::Temp qw/tempdir/;
 use Email::MIME;
+use Cwd;
 use PublicInbox::Config;
+my @mods = qw(Filesys::Notify::Simple);
+foreach my $mod (@mods) {
+       eval "require $mod";
+       plan skip_all => "$mod missing for watch_maildir.t" if $@;
+}
 
 my $tmpdir = tempdir('watch_maildir-XXXXXX', TMPDIR => 1, CLEANUP => 1);
 my $git_dir = "$tmpdir/test.git";
 my $maildir = "$tmpdir/md";
+my $spamdir = "$tmpdir/spam";
 use_ok 'PublicInbox::WatchMaildir';
 use_ok 'PublicInbox::Emergency';
 my $cfgpfx = "publicinbox.test";
@@ -21,19 +28,99 @@ Subject: spam
 Message-Id: <a\@b.com>
 Date: Sat, 18 Jun 2016 00:00:00 +0000
 
-msg
+something
 EOF
 PublicInbox::Emergency->new($maildir)->prepare(\$msg);
+ok(POSIX::mkfifo("$maildir/cur/fifo", 0777));
+my $sem = PublicInbox::Emergency->new($spamdir); # create dirs
 
 my $config = PublicInbox::Config->new({
        "$cfgpfx.address" => $addr,
        "$cfgpfx.mainrepo" => $git_dir,
        "$cfgpfx.watch" => "maildir:$maildir",
+       "$cfgpfx.filter" => 'PublicInbox::Filter::Vger',
+       "publicinboxlearn.watchspam" => "maildir:$spamdir",
 });
 
-PublicInbox::WatchMaildir->new($config)->scan;
+PublicInbox::WatchMaildir->new($config)->scan('full');
 my $git = PublicInbox::Git->new($git_dir);
 my @list = $git->qx(qw(rev-list refs/heads/master));
 is(scalar @list, 1, 'one revision in rev-list');
 
+my $write_spam = sub {
+       is(scalar glob("$spamdir/new/*"), undef, 'no spam existing');
+       $sem->prepare(\$msg);
+       $sem->commit;
+       my @new = glob("$spamdir/new/*");
+       is(scalar @new, 1);
+       my @p = split(m!/+!, $new[0]);
+       ok(link($new[0], "$spamdir/cur/".$p[-1].":2,S"));
+       is(unlink($new[0]), 1);
+};
+$write_spam->();
+is(unlink(glob("$maildir/new/*")), 1, 'unlinked old spam');
+PublicInbox::WatchMaildir->new($config)->scan('full');
+@list = $git->qx(qw(rev-list refs/heads/master));
+is(scalar @list, 2, 'two revisions in rev-list');
+@list = $git->qx(qw(ls-tree -r --name-only refs/heads/master));
+is(scalar @list, 0, 'tree is empty');
+
+# check with scrubbing
+{
+       $msg .= qq(--
+To unsubscribe from this list: send the line "unsubscribe git" in
+the body of a message to majordomo\@vger.kernel.org
+More majordomo info at  http://vger.kernel.org/majordomo-info.html\n);
+       PublicInbox::Emergency->new($maildir)->prepare(\$msg);
+       PublicInbox::WatchMaildir->new($config)->scan('full');
+       @list = $git->qx(qw(ls-tree -r --name-only refs/heads/master));
+       is(scalar @list, 1, 'tree has one file');
+       my $mref = $git->cat_file('HEAD:'.$list[0]);
+       like($$mref, qr/something\n\z/s, 'message scrubbed on import');
+
+       is(unlink(glob("$maildir/new/*")), 1, 'unlinked spam');
+       $write_spam->();
+       PublicInbox::WatchMaildir->new($config)->scan('full');
+       @list = $git->qx(qw(ls-tree -r --name-only refs/heads/master));
+       is(scalar @list, 0, 'tree is empty');
+       @list = $git->qx(qw(rev-list refs/heads/master));
+       is(scalar @list, 4, 'four revisions in rev-list');
+}
+
+{
+       my $fail_bin = getcwd()."/t/fail-bin";
+       ok(-x "$fail_bin/spamc", "mock spamc exists");
+       my $fail_path = "$fail_bin:$ENV{PATH}"; # for spamc ham mock
+       local $ENV{PATH} = $fail_path;
+       PublicInbox::Emergency->new($maildir)->prepare(\$msg);
+       $config->{'publicinboxwatch.spamcheck'} = 'spamc';
+       {
+               local $SIG{__WARN__} = sub {}; # quiet spam check warning
+               PublicInbox::WatchMaildir->new($config)->scan('full');
+       }
+       @list = $git->qx(qw(ls-tree -r --name-only refs/heads/master));
+       is(scalar @list, 0, 'tree has no files spamc checked');
+       is(unlink(glob("$maildir/new/*")), 1);
+}
+
+{
+       my $main_bin = getcwd()."/t/main-bin";
+       ok(-x "$main_bin/spamc", "mock spamc exists");
+       my $main_path = "$main_bin:$ENV{PATH}"; # for spamc ham mock
+       local $ENV{PATH} = $main_path;
+       PublicInbox::Emergency->new($maildir)->prepare(\$msg);
+       $config->{'publicinboxwatch.spamcheck'} = 'spamc';
+       @list = $git->qx(qw(ls-tree -r --name-only refs/heads/master));
+       PublicInbox::WatchMaildir->new($config)->scan('full');
+       @list = $git->qx(qw(ls-tree -r --name-only refs/heads/master));
+       is(scalar @list, 1, 'tree has one file after spamc checked');
+
+       # XXX: workaround some weird caching/memoization in cat-file,
+       # shouldn't be an issue in real-world use, though...
+       $git = PublicInbox::Git->new($git_dir);
+
+       my $mref = $git->cat_file('refs/heads/master:'.$list[0]);
+       like($$mref, qr/something\n\z/s, 'message scrubbed on import');
+}
+
 done_testing;