]> Sergey Matveev's repositories - public-inbox.git/commit
view: escape ampersand in Message-IDs
authorEric Wong <e@yhbt.net>
Sat, 15 Feb 2020 09:46:39 +0000 (09:46 +0000)
committerEric Wong <e@yhbt.net>
Sun, 16 Feb 2020 00:06:48 +0000 (00:06 +0000)
commit1fee6f86d7ee78161cc48a00232654f13a14bb88
tree4bc0018a153537cd3005bf87fb5fec7b6dde17d3
parent4c4de0022f40e09c4db7665cc573a3cb94f753a3
view: escape ampersand in Message-IDs

We need to escape ampersands (and some other characters for href
attributes), so introduce a `mid_href' sub to do just that.

'<', '>' and '"'  were always escaped, so there's no risk of tag
or attribute injection, but creative Message-IDs could cause
confusion for some parsers and generate invalid URLs.

Start getting rid of the bloated, over-engineered OO Hval API
while we're at it, I only noticed this bug because I started
killing off Hval->new* callers.
lib/PublicInbox/ExtMsg.pm
lib/PublicInbox/Hval.pm
lib/PublicInbox/Linkify.pm
lib/PublicInbox/Reply.pm
lib/PublicInbox/SearchView.pm
lib/PublicInbox/View.pm
lib/PublicInbox/WwwAtomStream.pm
t/psgi_bad_mids.t