]> Sergey Matveev's repositories - public-inbox.git/commit
process_pipe: warn hackers off using it for bidirectional pipes
authorEric Wong <e@80x24.org>
Wed, 25 Jan 2023 10:18:33 +0000 (10:18 +0000)
committerEric Wong <e@80x24.org>
Thu, 26 Jan 2023 02:18:12 +0000 (02:18 +0000)
commit3a709083fd01cbe0c1f679e73e40e44b0e5e3840
tree0bfa586087d1c8f75e52b798f6b61cf9ec1a7dbd
parent24f55535e78be0f1fa394bcd1aebc8c027e937c7
process_pipe: warn hackers off using it for bidirectional pipes

While most uses of ->DESTROY happens in a predictable order in
long-lived daemons, process teardown on exit is chaotic and not
subject to ordering guarantees, so we must keep both ends of a
`git cat-file --batch*' pipe at the same level in the object
hierarchy.

Drop an old Carp import while I'm in the area.
lib/PublicInbox/Git.pm
lib/PublicInbox/ProcessPipe.pm