]> Sergey Matveev's repositories - public-inbox.git/commit
lei rediff: fix construction of git-diff options
authorKyle Meyer <kyle@kyleam.com>
Fri, 21 May 2021 04:38:16 +0000 (00:38 -0400)
committerEric Wong <e@80x24.org>
Fri, 21 May 2021 09:44:33 +0000 (09:44 +0000)
commit3c1d0da4d0608b5a87371e602a911964d7c1498c
tree69d3fcc1143dbefa58b9d9b9896c897590914e62
parent2f720902ed702b64d918165ba21a96dabbeeca26
lei rediff: fix construction of git-diff options

When generating git-diff options, lei-rediff extracts the single
character option from the lei option spec.  However, there's no check
that the regular expression actually matches, leading to an
unintentional git-diff option when there isn't a short option (e.g.,
--inter-hunk-context=1 maps to the invalid `git diff --color -w1').

Check for a match before trying to extract the single character
option.

Fixes: cf0c7ce3ce81b5c3 (lei rediff: regenerate diffs from stdin)
lib/PublicInbox/LeiRediff.pm