]> Sergey Matveev's repositories - public-inbox.git/commit
eml: fix leak workaround
authorEric Wong <e@80x24.org>
Sat, 16 Oct 2021 23:23:01 +0000 (23:23 +0000)
committerEric Wong <e@80x24.org>
Sat, 16 Oct 2021 23:53:20 +0000 (23:53 +0000)
commit4fbec2e6737e9b65f0287ad1ebd14e20dfc10a93
treee16247c7c15e21e868cd779e73a7054ccca1e9e7
parent828e79e86d144a234bfaac476c591a544a3b8373
eml: fix leak workaround

Our previous workaround didn't actually work around the leak in
<https://rt.cpan.org/Public/Bug/Display.html?id=139622> since
croak()-via-Perl was still invoked before the SV reference
count could be decremented.

Put in a proper workaround which saves warnings onto a temporary
variable and only croak after ->decode or ->encode returns; not
inside those methods.
lib/PublicInbox/Eml.pm