]> Sergey Matveev's repositories - public-inbox.git/commit
git: cap MAX_INFLIGHT value to POSIX minimum
authorEric Wong <e@80x24.org>
Wed, 21 Dec 2022 23:22:10 +0000 (23:22 +0000)
committerEric Wong <e@80x24.org>
Wed, 21 Dec 2022 23:28:19 +0000 (23:28 +0000)
commit56e6e587745ca2aa04c17352d8662098b68c596f
treeba3ee50644f680f8ac792d9c42fac16a965bb28f
parente683fa9ea41f44191e32be6af37069210c4593e2
git: cap MAX_INFLIGHT value to POSIX minimum

This ensures we get consistent pipelining behavior across
platforms.  Furthermore, a smaller value is probably more
reasonable since "git cat-file" can usually outpace indexing and
lower values allow us to react to user interaction (e.g. Ctrl-C)
more quickly.

The previous value based on Linux PIPE_BUF (4096) allowed a
value of 189 which worked fine on non-musl Linux systems, but
failed on musl-based Void and Alpine Linux.  Mysteriously, this
works on musl up to a value of 114 and starts locking up at 115.
The reason for this failure is currently unexplained and will
hopefully be discovered soon.

Regardless, capping the value to 23 based on the universal
PIPE_BUF minimum (512) seems reasonable, anyways.

Reported-by: Chris Brannon <chris@the-brannons.com>
Tested-by: Chris Brannon <chris@the-brannons.com>
Link: https://public-inbox.org/meta/87edssl7u0.fsf@the-brannons.com/T/
lib/PublicInbox/Git.pm