]> Sergey Matveev's repositories - public-inbox.git/commit
qspawn: shorten lifetime of environ and opts args
authorEric Wong <e@80x24.org>
Sun, 15 Sep 2019 02:25:34 +0000 (02:25 +0000)
committerEric Wong <e@80x24.org>
Sun, 15 Sep 2019 06:27:12 +0000 (06:27 +0000)
commit68b8b7924cfc445e8fcd8cc58d6628d8f377ac53
treeabfe751037a662c9139fe3bef57412c200852fc0
parent87189dac4ad8af93ffba00af47d12ad42fb6971e
qspawn: shorten lifetime of environ and opts args

We don't need to hold onto the subprocess environ and
redirects/options for popen_rd after spawning the child process.

I do not expect this to fix problem of leaking unlinked regular
file descriptors (which I still can't reproduce), and it
definitely does not fix the problem of leaking pipe descriptors
(which I also can't reproduce).

This will save an FD sooner on non-public-inbox-httpd servers
which give a non-FD $env->{'psgi.input'}, however

Regardless, it's good to free up memory resources in our own
process ASAP we're done using them.
lib/PublicInbox/Qspawn.pm