]> Sergey Matveev's repositories - public-inbox.git/commit
projects / public-inbox.git / commit
summary | shortlog | log | commit | commitdiff | tree
(parent: 466df3e) | patch
ProcessPipe.pm: Use read not sysread
authorEric W. Biederman <ebiederm@xmission.com>
Mon, 30 Jul 2018 05:04:45 +0000 (00:04 -0500)
committerEric Wong <e@80x24.org>
Mon, 30 Jul 2018 08:06:42 +0000 (08:06 +0000)
commit8e0e850859fc9572cf201111728eaa621eace451
treea0551ea7ecc6b0fd3c7b0ca25deafe6a1d33f546tree
parent466df3e029fecdabac373d73989c7fceebe6ae28commit | diff
ProcessPipe.pm: Use read not sysread

While playing with git fast export I discovered that mixing <> and
read would give inconsistent results.  I tracked the issue down to
using sysread in ProcessPipe instead of plain read.

If it is desirable to use readline I can't see how using sysread
can work as readline to be efficient needs to use buffered I/O.

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
lib/PublicInbox/ProcessPipe.pm diff | blob | history
My patches to https://public-inbox.org/public-inbox.git