]> Sergey Matveev's repositories - public-inbox.git/commit
www: do not obfuscate addresses in URLs
authorEric Wong <e@80x24.org>
Sun, 11 Apr 2021 05:32:55 +0000 (05:32 +0000)
committerEric Wong <e@80x24.org>
Sun, 11 Apr 2021 06:40:21 +0000 (06:40 +0000)
commite98c3f01267c810ee214be87d0ee1bd575b23b88
tree938f62dce4d4faa792b9f2813b0c6f155d10695b
parentea4e9025dd14f251996baf724e04fc478375b6a2
www: do not obfuscate addresses in URLs

As they are likely Message-IDs.   If an email address ends up in
a URL, then it's likely public, so there's even less reason to
obfuscate that particular address.

[km: add xt/perf-obfuscate.t]
[ew: modernize perf test (5.10.1), use diag instead of print]

This version of the patch avoids the massive slowdown noted by Kyle in
<https://public-inbox.org/meta/87wnt9or6t.fsf@kyleam.com/>.
Performance remains roughly the same, if not slightly faster
(which may be due to me testing this on a busy server).  Results
from xt/perf-obfuscate.t against 6078 messages on a local mirror
of <https://public-inbox.org/meta/>:

before: 6.67 usr + 0.04 sys = 6.71 CPU
 after: 6.64 usr + 0.04 sys = 6.68 CPU

Reported-by: Kyle Meyer <kyle@kyleam.com>
Helped-by: Kyle Meyer <kyle@kyleam.com>
Link: https://public-inbox.org/meta/87a6q8p5qa.fsf@kyleam.com/
MANIFEST
lib/PublicInbox/Hval.pm
t/hval.t
xt/perf-obfuscate.t [new file with mode: 0644]