From: Eric Wong Date: Sun, 5 Jul 2020 23:27:22 +0000 (+0000) Subject: www: need: use WwwStream::html_oneshot X-Git-Tag: v1.6.0~294 X-Git-Url: http://www.git.stargrave.org/?p=public-inbox.git;a=commitdiff_plain;h=dda6cc91f8fbaaac187366957be6b828496e12f8 www: need: use WwwStream::html_oneshot It'll give us a nicer HTML header and footer. --- diff --git a/lib/PublicInbox/WWW.pm b/lib/PublicInbox/WWW.pm index 289d0ce4..e4ad515a 100644 --- a/lib/PublicInbox/WWW.pm +++ b/lib/PublicInbox/WWW.pm @@ -322,12 +322,11 @@ sub get_altid_dump { sub need { my ($ctx, $extra) = @_; - my $msg = <$extra not available for this -public-inbox
$extra is not available for this public-inbox
-Return to index
+ require PublicInbox::WwwStream; + PublicInbox::WwwStream::html_oneshot($ctx, 501, \<$extra is not available for this public-inbox +Return to index EOF - [ 501, [ 'Content-Type' => 'text/html; charset=UTF-8' ], [ $msg ] ]; } # /$INBOX/$MESSAGE_ID/t.mbox -> thread as mbox diff --git a/t/plack.t b/t/plack.t index 37a6b394..4b830a21 100644 --- a/t/plack.t +++ b/t/plack.t @@ -209,6 +209,10 @@ test_psgi($app, sub { my $res = $cb->(GET($pfx . '/blah@example.com/raw')); is(200, $res->code, 'success response received for /*/raw'); like($res->content, qr!^From !sm, "mbox returned"); + + $res = $cb->(GET($pfx . '/blah@example.com/t.mbox.gz')); + is(501, $res->code, '501 when overview missing'); + like($res->content, qr!\bOverview\b!, 'overview omission noted'); }); # legacy redirects