]> Sergey Matveev's repositories - btrtrc.git/blobdiff - client.go
Use Option for cached Torrent length
[btrtrc.git] / client.go
index 4986424cd9d730f1e394b6038d3f920ac3b85bbe..28dbc8ed4466853a9be6abcc76276beab6d1ba3e 100644 (file)
--- a/client.go
+++ b/client.go
@@ -19,26 +19,24 @@ import (
        "strings"
        "time"
 
+       "github.com/davecgh/go-spew/spew"
+       "github.com/dustin/go-humanize"
+       gbtree "github.com/google/btree"
+       "github.com/pion/datachannel"
+       "golang.org/x/time/rate"
+
+       "github.com/anacrolix/chansync"
        "github.com/anacrolix/chansync/events"
        "github.com/anacrolix/dht/v2"
        "github.com/anacrolix/dht/v2/krpc"
        "github.com/anacrolix/generics"
+       . "github.com/anacrolix/generics"
        "github.com/anacrolix/log"
        "github.com/anacrolix/missinggo/perf"
-       "github.com/anacrolix/missinggo/pubsub"
        "github.com/anacrolix/missinggo/v2"
        "github.com/anacrolix/missinggo/v2/bitmap"
        "github.com/anacrolix/missinggo/v2/pproffd"
        "github.com/anacrolix/sync"
-       request_strategy "github.com/anacrolix/torrent/request-strategy"
-       "github.com/davecgh/go-spew/spew"
-       "github.com/dustin/go-humanize"
-       "github.com/google/btree"
-       "github.com/pion/datachannel"
-       "golang.org/x/time/rate"
-
-       "github.com/anacrolix/chansync"
-       . "github.com/anacrolix/generics"
 
        "github.com/anacrolix/torrent/bencode"
        "github.com/anacrolix/torrent/internal/limiter"
@@ -46,6 +44,7 @@ import (
        "github.com/anacrolix/torrent/metainfo"
        "github.com/anacrolix/torrent/mse"
        pp "github.com/anacrolix/torrent/peer_protocol"
+       request_strategy "github.com/anacrolix/torrent/request-strategy"
        "github.com/anacrolix/torrent/storage"
        "github.com/anacrolix/torrent/tracker"
        "github.com/anacrolix/torrent/webtorrent"
@@ -88,7 +87,7 @@ type Client struct {
        websocketTrackers websocketTrackers
 
        activeAnnounceLimiter limiter.Instance
-       webseedHttpClient     *http.Client
+       httpClient            *http.Client
 }
 
 type ipStr string
@@ -167,8 +166,8 @@ func (cl *Client) WriteStatus(_w io.Writer) {
                                w,
                                "%f%% of %d bytes (%s)",
                                100*(1-float64(t.bytesMissingLocked())/float64(t.info.TotalLength())),
-                               *t.length,
-                               humanize.Bytes(uint64(*t.length)))
+                               t.length(),
+                               humanize.Bytes(uint64(t.length())))
                } else {
                        w.WriteString("<missing metainfo>")
                }
@@ -202,9 +201,11 @@ func (cl *Client) init(cfg *ClientConfig) {
        cl.activeAnnounceLimiter.SlotsPerKey = 2
        cl.event.L = cl.locker()
        cl.ipBlockList = cfg.IPBlocklist
-       cl.webseedHttpClient = &http.Client{
+       cl.httpClient = &http.Client{
                Transport: &http.Transport{
-                       Proxy:           cfg.HTTPProxy,
+                       Proxy: cfg.HTTPProxy,
+                       // I think this value was observed from some webseeds. It seems reasonable to extend it
+                       // to other uses of HTTP from the client.
                        MaxConnsPerHost: 10,
                },
        }
@@ -250,7 +251,7 @@ func NewClient(cfg *ClientConfig) (cl *Client, err error) {
                }
        }
 
-       sockets, err := listenAll(cl.listenNetworks(), cl.config.ListenHost, cl.config.ListenPort, cl.firewallCallback)
+       sockets, err := listenAll(cl.listenNetworks(), cl.config.ListenHost, cl.config.ListenPort, cl.firewallCallback, cl.logger)
        if err != nil {
                return
        }
@@ -383,6 +384,7 @@ func (cl *Client) listenNetworks() (ns []network) {
 
 // Creates an anacrolix/dht Server, as would be done internally in NewClient, for the given conn.
 func (cl *Client) NewAnacrolixDhtServer(conn net.PacketConn) (s *dht.Server, err error) {
+       logger := cl.logger.WithNames("dht", conn.LocalAddr().String())
        cfg := dht.ServerConfig{
                IPBlocklist:    cl.ipBlockList,
                Conn:           conn,
@@ -395,7 +397,7 @@ func (cl *Client) NewAnacrolixDhtServer(conn net.PacketConn) (s *dht.Server, err
                }(),
                StartingNodes: cl.config.DhtStartingNodes(conn.LocalAddr().Network()),
                OnQuery:       cl.config.DHTOnQuery,
-               Logger:        cl.logger.WithContextText(fmt.Sprintf("dht server on %v", conn.LocalAddr().String())),
+               Logger:        logger,
        }
        if f := cl.config.ConfigureAnacrolixDhtServer; f != nil {
                f(&cfg)
@@ -405,9 +407,9 @@ func (cl *Client) NewAnacrolixDhtServer(conn net.PacketConn) (s *dht.Server, err
                go func() {
                        ts, err := s.Bootstrap()
                        if err != nil {
-                               cl.logger.Printf("error bootstrapping dht: %s", err)
+                               logger.Levelf(log.Warning, "error bootstrapping dht: %s", err)
                        }
-                       log.Fstr("%v completed bootstrap (%+v)", s, ts).AddValues(s, ts).Log(cl.logger)
+                       logger.Levelf(log.Debug, "completed bootstrap: %+v", ts)
                }()
        }
        return
@@ -770,7 +772,7 @@ func (cl *Client) outgoingConnection(t *Torrent, addr PeerRemoteAddr, ps PeerSou
        cl.noLongerHalfOpen(t, addr.String())
        if err != nil {
                if cl.config.Debug {
-                       cl.logger.Printf("error establishing outgoing connection to %v: %v", addr, err)
+                       cl.logger.Levelf(log.Debug, "error establishing outgoing connection to %v: %v", addr, err)
                }
                return
        }
@@ -989,7 +991,9 @@ func (p *Peer) initUpdateRequestsTimer() {
                        panic(p.updateRequestsTimer)
                }
        }
-       p.updateRequestsTimer = time.AfterFunc(math.MaxInt64, p.updateRequestsTimerFunc)
+       if enableUpdateRequestsTimer {
+               p.updateRequestsTimer = time.AfterFunc(math.MaxInt64, p.updateRequestsTimerFunc)
+       }
 }
 
 const peerUpdateRequestsTimerReason = "updateRequestsTimer"
@@ -1134,8 +1138,9 @@ func (cl *Client) badPeerAddr(addr PeerRemoteAddr) bool {
        return false
 }
 
+// Returns whether the IP address and port are considered "bad".
 func (cl *Client) badPeerIPPort(ip net.IP, port int) bool {
-       if port == 0 {
+       if port == 0 || ip == nil {
                return true
        }
        if cl.dopplegangerAddr(net.JoinHostPort(ip.String(), strconv.FormatInt(int64(port), 10))) {
@@ -1174,7 +1179,7 @@ func (cl *Client) newTorrentOpt(opts AddTorrentOpts) (t *Torrent) {
                cl:       cl,
                infoHash: opts.InfoHash,
                peers: prioritizedPeers{
-                       om: btree.New(32),
+                       om: gbtree.New(32),
                        getPrio: func(p PeerInfo) peerPriority {
                                ipPort := p.addr()
                                return bep40PriorityIgnoreError(cl.publicAddr(ipPort.IP), ipPort)
@@ -1182,8 +1187,7 @@ func (cl *Client) newTorrentOpt(opts AddTorrentOpts) (t *Torrent) {
                },
                conns: make(map[*PeerConn]struct{}, 2*cl.config.EstablishedConnsPerTorrent),
 
-               halfOpen:          make(map[string]PeerInfo),
-               pieceStateChanges: pubsub.NewPubSub(),
+               halfOpen: make(map[string]PeerInfo),
 
                storageOpener:       storageClient,
                maxEstablishedConns: cl.config.EstablishedConnsPerTorrent,
@@ -1198,6 +1202,7 @@ func (cl *Client) newTorrentOpt(opts AddTorrentOpts) (t *Torrent) {
        t.smartBanCache.Init()
        t.networkingEnabled.Set()
        t.logger = cl.logger.WithContextValue(t).WithNames("torrent", t.infoHash.HexString())
+       t.sourcesLogger = t.logger.WithNames("sources")
        if opts.ChunkSize == 0 {
                opts.ChunkSize = defaultChunkSize
        }
@@ -1311,7 +1316,6 @@ func (t *Torrent) MergeSpec(spec *TorrentSpec) error {
        if spec.DisplayName != "" {
                t.SetDisplayName(spec.DisplayName)
        }
-       t.initialPieceCheckDisabled = spec.DisableInitialPieceCheck
        if spec.InfoBytes != nil {
                err := t.SetInfoBytes(spec.InfoBytes)
                if err != nil {
@@ -1320,9 +1324,10 @@ func (t *Torrent) MergeSpec(spec *TorrentSpec) error {
        }
        cl := t.cl
        cl.AddDhtNodes(spec.DhtNodes)
+       t.UseSources(spec.Sources)
        cl.lock()
        defer cl.unlock()
-       useTorrentSources(spec.Sources, t)
+       t.initialPieceCheckDisabled = spec.DisableInitialPieceCheck
        for _, url := range spec.Webseeds {
                t.addWebSeed(url)
        }
@@ -1343,52 +1348,6 @@ func (t *Torrent) MergeSpec(spec *TorrentSpec) error {
        return nil
 }
 
-func useTorrentSources(sources []string, t *Torrent) {
-       // TODO: bind context to the lifetime of *Torrent so that it's cancelled if the torrent closes
-       ctx := context.Background()
-       for i := 0; i < len(sources); i += 1 {
-               s := sources[i]
-               go func() {
-                       if err := useTorrentSource(ctx, s, t); err != nil {
-                               t.logger.WithDefaultLevel(log.Warning).Printf("using torrent source %q: %v", s, err)
-                       } else {
-                               t.logger.Printf("successfully used source %q", s)
-                       }
-               }()
-       }
-}
-
-func useTorrentSource(ctx context.Context, source string, t *Torrent) (err error) {
-       ctx, cancel := context.WithCancel(ctx)
-       defer cancel()
-       go func() {
-               select {
-               case <-t.GotInfo():
-               case <-t.Closed():
-               case <-ctx.Done():
-               }
-               cancel()
-       }()
-       var req *http.Request
-       if req, err = http.NewRequestWithContext(ctx, http.MethodGet, source, nil); err != nil {
-               panic(err)
-       }
-       var resp *http.Response
-       if resp, err = http.DefaultClient.Do(req); err != nil {
-               return
-       }
-       var mi metainfo.MetaInfo
-       err = bencode.NewDecoder(resp.Body).Decode(&mi)
-       resp.Body.Close()
-       if err != nil {
-               if ctx.Err() != nil {
-                       return nil
-               }
-               return
-       }
-       return t.MergeSpec(TorrentSpecFromMetaInfo(&mi))
-}
-
 func (cl *Client) dropTorrent(infoHash metainfo.Hash, wg *sync.WaitGroup) (err error) {
        t, ok := cl.torrents[infoHash]
        if !ok {
@@ -1396,9 +1355,6 @@ func (cl *Client) dropTorrent(infoHash metainfo.Hash, wg *sync.WaitGroup) (err e
                return
        }
        err = t.close(wg)
-       if err != nil {
-               panic(err)
-       }
        delete(cl.torrents, infoHash)
        return
 }
@@ -1505,6 +1461,7 @@ func (cl *Client) banPeerIP(ip net.IP) {
                t.iterPeers(func(p *Peer) {
                        if p.remoteIp().Equal(ip) {
                                t.logger.Levelf(log.Warning, "dropping peer %v with banned ip %v", p, ip)
+                               // Should this be a close?
                                p.drop()
                        }
                })
@@ -1529,6 +1486,7 @@ func (cl *Client) newConnection(nc net.Conn, outgoing bool, remoteAddr PeerRemot
                connString: connString,
                conn:       nc,
        }
+       c.initRequestState()
        // TODO: Need to be much more explicit about this, including allowing non-IP bannable addresses.
        if remoteAddr != nil {
                netipAddrPort, err := netip.ParseAddrPort(remoteAddr.String())