fixup Plack-related requires

[public-inbox.git] / lib / PublicInbox / Config.pm

diff --git a/lib/PublicInbox/Config.pm b/lib/PublicInbox/Config.pm
index 844f666ef6a484f759cc445ba7047359823a713f..f84a9550b6c9a63f04477d8a2fee541c51e3382c 100644 (file)
--- a/lib/PublicInbox/Config.pm
+++ b/lib/PublicInbox/Config.pm
@@ -73,7 +73,7 @@ sub git_config_dump {
        my @cmd = (qw/git config/, "--file=$file", '-l');
        my $cmd = join(' ', @cmd);
        my $pid = open(my $fh, '-|', @cmd);
-       defined $pid or die "$cmd failed: $!\n";
+       defined $pid or die "$cmd failed: $!";
        my %rv;
        foreach my $line (<$fh>) {
                chomp $line;
@@ -90,8 +90,8 @@ sub git_config_dump {
                        $rv{$k} = $v;
                }
        }
-       close $fh or die "failed to close ($cmd) pipe: $!\n";
-       $? and warn "$$ $cmd exited with: ($pid) $?\n";
+       close $fh or die "failed to close ($cmd) pipe: $!";
+       $? and warn "$$ $cmd exited with: ($pid) $?";
        \%rv;
 }
 
@@ -101,7 +101,6 @@ sub try_cat {
        if (open(my $fh, '<', $path)) {
                local $/;
                $rv = <$fh>;
-               close $fh;
        }
        $rv;
 }