fixup Plack-related requires

[public-inbox.git] / lib / PublicInbox / Git.pm

diff --git a/lib/PublicInbox/Git.pm b/lib/PublicInbox/Git.pm
index 57d17d3382aaef9087eced1d10c34b90b5887f3f..0f92dd9a82f6e70bc5de58661fbfab0bce76bd47 100644 (file)
--- a/lib/PublicInbox/Git.pm
+++ b/lib/PublicInbox/Git.pm
@@ -29,8 +29,6 @@ sub _bidi_pipe {
        my @cmd = ('git', "--git-dir=$self->{git_dir}", qw(cat-file), $batch);
        my $redir = { 0 => fileno($out_r), 1 => fileno($in_w) };
        $self->{$pid} = spawn(\@cmd, undef, $redir);
-       close $out_r or fail($self, "close failed: $!");
-       close $in_w or fail($self, "close failed: $!");
        $out_w->autoflush(1);
        $self->{$out} = $out_w;
        $self->{$in} = $in_r;
@@ -100,13 +98,9 @@ sub check {
 
 sub _destroy {
        my ($self, $in, $out, $pid) = @_;
-       my $p = $self->{$pid} or return;
-       $self->{$pid} = undef;
+       my $p = delete $self->{$pid} or return;
        foreach my $f ($in, $out) {
-               my $fh = $self->{$f};
-               defined $fh or next;
-               close $fh;
-               $self->{$f} = undef;
+               delete $self->{$f};
        }
        waitpid $p, 0;
 }