git-http-backend: move real close to GetlineBody

[public-inbox.git] / lib / PublicInbox / GitHTTPBackend.pm

diff --git a/lib/PublicInbox/GitHTTPBackend.pm b/lib/PublicInbox/GitHTTPBackend.pm
index 9464cb499a3f0c4744b8b33eec1559e415da4887..18194441e888da321250b5ab3609cce544e515ac 100644 (file)
--- a/lib/PublicInbox/GitHTTPBackend.pm
+++ b/lib/PublicInbox/GitHTTPBackend.pm
@@ -186,7 +186,6 @@ sub serve_smart {
        my $x = PublicInbox::Qspawn->new([qw(git http-backend)], \%env, \%rdr);
        my ($fh, $rpipe);
        my $end = sub {
-               $rpipe = undef;
                if (my $err = $x->finish) {
                        err($env, "git http-backend ($git_dir): $err");
                        drop_client($env);
@@ -201,7 +200,7 @@ sub serve_smart {
                my $r = sysread($rpipe, $buf, 1024, length($buf));
                return if !defined($r) && ($!{EINTR} || $!{EAGAIN});
                return r(500, 'http-backend error') unless $r;
-               $r = parse_cgi_headers(\$buf) or return;
+               $r = parse_cgi_headers(\$buf) or return; # incomplete headers
                $r->[0] == 403 ? serve_dumb($cgi, $git, $path) : $r;
        };
        my $res;
@@ -220,13 +219,8 @@ sub serve_smart {
                }
 
                # for synchronous PSGI servers
-               $r->[2] = Plack::Util::inline_object(
-                       close => $end,
-                       getline => sub {
-                               my $ret = $buf;
-                               $buf = undef;
-                               defined $ret ? $ret : $rpipe->getline;
-                       });
+               require PublicInbox::GetlineBody;
+               $r->[2] = PublicInbox::GetlineBody->new($rpipe, $end, $buf);
                $res->($r);
        };
        sub {