use strict;
use warnings;
use Fcntl qw(:seek);
-use IO::File;
+use IO::Handle;
use HTTP::Date qw(time2str);
use HTTP::Status qw(status_message);
+use Plack::Util;
use PublicInbox::Qspawn;
+# 32 is same as the git-daemon connection limit
+my $default_limiter = PublicInbox::Qspawn::Limiter->new(32);
+
# n.b. serving "description" and "cloneurl" should be innocuous enough to
# not cause problems. serving "config" might...
my @text = qw[HEAD info/refs
my $f = (ref $git ? $git->{git_dir} : $git) . '/' . $path;
return r(404) unless -f $f && -r _; # just in case it's a FIFO :P
- my @st = stat(_);
- my $size = $st[7];
+ my $size = -s _;
# TODO: If-Modified-Since and Last-Modified?
open my $in, '<', $f or return r(404);
my $val = $env->{$name};
$env{$name} = $val if defined $val;
}
- my $git_dir = ref $git ? $git->{git_dir} : $git;
+ my ($git_dir, $limiter);
+ if (ref $git) {
+ $limiter = $git->{-httpbackend_limiter} || $default_limiter;
+ $git_dir = $git->{git_dir};
+ } else {
+ $limiter = $default_limiter;
+ $git_dir = $git;
+ }
$env{GIT_HTTP_EXPORT_ALL} = '1';
$env{PATH_TRANSLATED} = "$git_dir/$path";
- my %rdr = ( 0 => fileno($in) );
- my $x = PublicInbox::Qspawn->new([qw(git http-backend)], \%env, \%rdr);
+ my $rdr = { 0 => fileno($in) };
+ my $qsp = PublicInbox::Qspawn->new([qw(git http-backend)], \%env, $rdr);
my ($fh, $rpipe);
my $end = sub {
- if (my $err = $x->finish) {
+ if (my $err = $qsp->finish) {
err($env, "git http-backend ($git_dir): $err");
}
$fh->close if $fh; # async-only
$r->[0] == 403 ? serve_dumb($env, $git, $path) : $r;
};
my $res;
- my $async = $env->{'pi-httpd.async'};
+ my $async = $env->{'pi-httpd.async'}; # XXX unstable API
my $io = $env->{'psgix.io'};
my $cb = sub {
my $r = $rd_hdr->() or return;
# holding the input here is a waste of FDs and memory
$env->{'psgi.input'} = undef;
- $x->start(sub { # may run later, much later...
+ $qsp->start($limiter, sub { # may run later, much later...
($rpipe) = @_;
$in = undef;
if ($async) {
sub input_to_file {
my ($env) = @_;
- my $in = IO::File->new_tmpfile;
+ open(my $in, '+>', undef);
+ unless (defined $in) {
+ err($env, "could not open temporary file: $!");
+ return;
+ }
my $input = $env->{'psgi.input'};
my $buf;
while (1) {
err($env, "error reading input: $!");
return;
}
- last if ($r == 0);
- $in->write($buf);
+ my $off = 0;
+ while ($r > 0) {
+ my $w = syswrite($in, $buf, $r, $off);
+ if (defined $w) {
+ $r -= $w;
+ $off += $w;
+ } else {
+ err($env, "error writing temporary file: $!");
+ return;
+ }
+ }
+ }
+ unless (defined(sysseek($in, 0, SEEK_SET))) {
+ err($env, "error seeking temporary file: $!");
+ return;
}
- $in->flush;
- $in->sysseek(0, SEEK_SET);
return $in;
}