-# Copyright (C) 2016 all contributors <meta@public-inbox.org>
+# Copyright (C) 2016-2018 all contributors <meta@public-inbox.org>
# License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
# when no endpoints match, fallback to this and serve a static file
-# or smart HTTP
+# or smart HTTP. This is our wrapper for git-http-backend(1)
package PublicInbox::GitHTTPBackend;
use strict;
use warnings;
use Fcntl qw(:seek);
-use IO::File;
+use IO::Handle;
use HTTP::Date qw(time2str);
use HTTP::Status qw(status_message);
use Plack::Util;
sub serve {
my ($env, $git, $path) = @_;
+ # XXX compatibility... ugh, can we stop supporting this?
+ $git = PublicInbox::Git->new($git) unless ref($git);
+
# Documentation/technical/http-protocol.txt in git.git
# requires one and exactly one query parameter:
if ($env->{QUERY_STRING} =~ /\Aservice=git-\w+-pack\z/ ||
return r(404);
}
- my $f = (ref $git ? $git->{git_dir} : $git) . '/' . $path;
+ my $f = $git->{git_dir} . '/' . $path;
return r(404) unless -f $f && -r _; # just in case it's a FIFO :P
my $size = -s _;
# returns undef if 403 so it falls back to dumb HTTP
sub serve_smart {
my ($env, $git, $path) = @_;
- my $limiter = $default_limiter;
my $in = $env->{'psgi.input'};
my $fd = eval { fileno($in) };
unless (defined $fd && $fd >= 0) {
my $val = $env->{$name};
$env{$name} = $val if defined $val;
}
- my $git_dir = ref $git ? $git->{git_dir} : $git;
+ my $limiter = $git->{-httpbackend_limiter} || $default_limiter;
$env{GIT_HTTP_EXPORT_ALL} = '1';
- $env{PATH_TRANSLATED} = "$git_dir/$path";
- my %rdr = ( 0 => fileno($in) );
- my $x = PublicInbox::Qspawn->new([qw(git http-backend)], \%env, \%rdr);
- my ($fh, $rpipe);
- my $end = sub {
- if (my $err = $x->finish) {
- err($env, "git http-backend ($git_dir): $err");
- }
- $fh->close if $fh; # async-only
- };
-
- # Danga::Socket users, we queue up the read_enable callback to
- # fire after pending writes are complete:
- my $buf = '';
- my $rd_hdr = sub {
- my $r = sysread($rpipe, $buf, 1024, length($buf));
- return if !defined($r) && ($!{EINTR} || $!{EAGAIN});
- return r(500, 'http-backend error') unless $r;
- $r = parse_cgi_headers(\$buf) or return; # incomplete headers
+ $env{PATH_TRANSLATED} = "$git->{git_dir}/$path";
+ my $rdr = { 0 => fileno($in) };
+ my $qsp = PublicInbox::Qspawn->new([qw(git http-backend)], \%env, $rdr);
+ $qsp->psgi_return($env, $limiter, sub {
+ my ($r, $bref) = @_;
+ $r = parse_cgi_headers($bref) or return; # incomplete headers
$r->[0] == 403 ? serve_dumb($env, $git, $path) : $r;
- };
- my $res;
- my $async = $env->{'pi-httpd.async'};
- my $io = $env->{'psgix.io'};
- my $cb = sub {
- my $r = $rd_hdr->() or return;
- $rd_hdr = undef;
- if (scalar(@$r) == 3) { # error:
- if ($async) {
- $async->close; # calls rpipe->close
- } else {
- $rpipe->close;
- $end->();
- }
- return $res->($r);
- }
- if ($async) {
- $fh = $res->($r);
- return $async->async_pass($io, $fh, \$buf);
- }
-
- # for synchronous PSGI servers
- require PublicInbox::GetlineBody;
- $r->[2] = PublicInbox::GetlineBody->new($rpipe, $end, $buf);
- $res->($r);
- };
- sub {
- ($res) = @_;
-
- # hopefully this doesn't break any middlewares,
- # holding the input here is a waste of FDs and memory
- $env->{'psgi.input'} = undef;
-
- $x->start($limiter, sub { # may run later, much later...
- ($rpipe) = @_;
- $in = undef;
- if ($async) {
- $async = $async->($rpipe, $cb, $end);
- } else { # generic PSGI
- $cb->() while $rd_hdr;
- }
- });
- };
+ });
}
sub input_to_file {
my ($env) = @_;
- my $in = IO::File->new_tmpfile;
+ open(my $in, '+>', undef);
+ unless (defined $in) {
+ err($env, "could not open temporary file: $!");
+ return;
+ }
my $input = $env->{'psgi.input'};
my $buf;
while (1) {
err($env, "error reading input: $!");
return;
}
- last if ($r == 0);
- $in->write($buf);
+ last if $r == 0;
+ my $off = 0;
+ while ($r > 0) {
+ my $w = syswrite($in, $buf, $r, $off);
+ if (defined $w) {
+ $r -= $w;
+ $off += $w;
+ } else {
+ err($env, "error writing temporary file: $!");
+ return;
+ }
+ }
+ }
+ unless (defined(sysseek($in, 0, SEEK_SET))) {
+ err($env, "error seeking temporary file: $!");
+ return;
}
- $in->flush;
- $in->sysseek(0, SEEK_SET);
return $in;
}