lei add-external: completion for existing URL basenames

[public-inbox.git] / lib / PublicInbox / LeiDedupe.pm

diff --git a/lib/PublicInbox/LeiDedupe.pm b/lib/PublicInbox/LeiDedupe.pm
index 58eee53314777ecac2801762fd52e3bb274416b3..5c83fd8007ce55438f989ebd3a2bc835d05b7373 100644 (file)
--- a/lib/PublicInbox/LeiDedupe.pm
+++ b/lib/PublicInbox/LeiDedupe.pm
@@ -5,6 +5,7 @@ use strict;
 use v5.10.1;
 use PublicInbox::SharedKV;
 use PublicInbox::ContentHash qw(content_hash);
+use Digest::SHA ();
 
 # n.b. mutt sets most of these headers not sure about Bytes
 our @OID_IGNORE = qw(Status X-Status Content-Length Lines Bytes);
@@ -43,9 +44,9 @@ sub smsg_hash ($) {
 }
 
 # the paranoid option
-sub dedupe_oid () {
-       my $skv = PublicInbox::SharedKV->new;
-       ($skv, sub { # may be called in a child process
+sub dedupe_oid ($) {
+       my ($skv) = @_;
+       (sub { # may be called in a child process
                my ($eml, $oid) = @_;
                $skv->set_maybe(_oidbin($oid) // _regen_oid($eml), '');
        }, sub {
@@ -55,9 +56,9 @@ sub dedupe_oid () {
 }
 
 # dangerous if there's duplicate messages with different Message-IDs
-sub dedupe_mid () {
-       my $skv = PublicInbox::SharedKV->new;
-       ($skv, sub { # may be called in a child process
+sub dedupe_mid ($) {
+       my ($skv) = @_;
+       (sub { # may be called in a child process
                my ($eml, $oid) = @_;
                # TODO: lei will support non-public messages w/o Message-ID
                my $mid = $eml->header_raw('Message-ID') // _oidbin($oid) //
@@ -73,9 +74,9 @@ sub dedupe_mid () {
 }
 
 # our default deduplication strategy (used by v2, also)
-sub dedupe_content () {
-       my $skv = PublicInbox::SharedKV->new;
-       ($skv, sub { # may be called in a child process
+sub dedupe_content ($) {
+       my ($skv) = @_;
+       (sub { # may be called in a child process
                my ($eml) = @_; # oid = $_[1], ignored
                $skv->set_maybe(content_hash($eml), '');
        }, sub {
@@ -86,22 +87,25 @@ sub dedupe_content () {
 
 # no deduplication at all
 sub true { 1 }
-sub dedupe_none () { (undef, \&true, \&true) }
+sub dedupe_none ($) { (\&true, \&true) }
 
 sub new {
-       my ($cls, $lei, $dst) = @_;
+       my ($cls, $lei) = @_;
        my $dd = $lei->{opt}->{dedupe} // 'content';
+       my $dst = $lei->{ovv}->{dst};
 
        # allow "none" to bypass Eml->new if writing to directory:
        return if ($dd eq 'none' && substr($dst // '', -1) eq '/');
+       my $m = "dedupe_$dd";
+       $cls->can($m) or die "unsupported dedupe strategy: $dd\n";
+       my $skv = $dd eq 'none' ? undef : PublicInbox::SharedKV->new;
 
-       my $dd_new = $cls->can("dedupe_$dd") //
-                       die "unsupported dedupe strategy: $dd\n";
-       bless [ $dd_new->() ], $cls; # [ $skv, $cb ]
+       # [ $skv, $eml_cb, $smsg_cb, "dedupe_$dd" ]
+       bless [ $skv, undef, undef, $m ], $cls;
 }
 
-# returns true on unseen messages according to the deduplication strategy,
-# returns false if seen
+# returns true on seen messages according to the deduplication strategy,
+# returns false if unseen
 sub is_dup {
        my ($self, $eml, $oid) = @_;
        !$self->[1]->($eml, $oid);
@@ -115,12 +119,14 @@ sub is_smsg_dup {
 sub prepare_dedupe {
        my ($self) = @_;
        my $skv = $self->[0];
+       $self->[1] or @$self[1,2] = $self->can($self->[3])->($skv);
        $skv ? $skv->dbh : undef;
 }
 
 sub pause_dedupe {
        my ($self) = @_;
        my $skv = $self->[0];
+       $skv->dbh_release;
        delete($skv->{dbh}) if $skv;
 }