lei add-external: completion for existing URL basenames

[public-inbox.git] / lib / PublicInbox / LeiDedupe.pm

diff --git a/lib/PublicInbox/LeiDedupe.pm b/lib/PublicInbox/LeiDedupe.pm
index 81754361292e533cf6acec44259262796646a994..5c83fd8007ce55438f989ebd3a2bc835d05b7373 100644 (file)
--- a/lib/PublicInbox/LeiDedupe.pm
+++ b/lib/PublicInbox/LeiDedupe.pm
@@ -5,6 +5,7 @@ use strict;
 use v5.10.1;
 use PublicInbox::SharedKV;
 use PublicInbox::ContentHash qw(content_hash);
+use Digest::SHA ();
 
 # n.b. mutt sets most of these headers not sure about Bytes
 our @OID_IGNORE = qw(Status X-Status Content-Length Lines Bytes);
@@ -89,8 +90,9 @@ sub true { 1 }
 sub dedupe_none ($) { (\&true, \&true) }
 
 sub new {
-       my ($cls, $lei, $dst) = @_;
+       my ($cls, $lei) = @_;
        my $dd = $lei->{opt}->{dedupe} // 'content';
+       my $dst = $lei->{ovv}->{dst};
 
        # allow "none" to bypass Eml->new if writing to directory:
        return if ($dd eq 'none' && substr($dst // '', -1) eq '/');
@@ -102,8 +104,8 @@ sub new {
        bless [ $skv, undef, undef, $m ], $cls;
 }
 
-# returns true on unseen messages according to the deduplication strategy,
-# returns false if seen
+# returns true on seen messages according to the deduplication strategy,
+# returns false if unseen
 sub is_dup {
        my ($self, $eml, $oid) = @_;
        !$self->[1]->($eml, $oid);
@@ -124,6 +126,7 @@ sub prepare_dedupe {
 sub pause_dedupe {
        my ($self) = @_;
        my $skv = $self->[0];
+       $skv->dbh_release;
        delete($skv->{dbh}) if $skv;
 }