lei q: avoid redundant default setting for sort with l2m

[public-inbox.git] / lib / PublicInbox / LeiOverview.pm

diff --git a/lib/PublicInbox/LeiOverview.pm b/lib/PublicInbox/LeiOverview.pm
index 8e26cba48c02d1020800600bf34b636c7610e215..cdd9ee04766978b0151d5769a89f38d4ac294c6c 100644 (file)
--- a/lib/PublicInbox/LeiOverview.pm
+++ b/lib/PublicInbox/LeiOverview.pm
@@ -26,7 +26,7 @@ sub _iso8601 ($) { strftime('%Y-%m-%dT%H:%M:%SZ', gmtime($_[0])) }
 # we open this in the parent process before ->wq_io_do handoff
 sub ovv_out_lk_init ($) {
        my ($self) = @_;
-       my $tmp = File::Temp->new("lei-ovv.dst.$$.lock-XXXXXX",
+       my $tmp = File::Temp->new("lei-ovv.dst.$$.lock-XXXX",
                                        TMPDIR => 1, UNLINK => 0);
        $self->{"lk_id.$self.$$"} = $self->{lock_path} = $tmp->filename;
 }
@@ -101,8 +101,6 @@ sub new {
        if ($json) {
                $lei->{dedupe} //= PublicInbox::LeiDedupe->new($lei);
        } else {
-               # default to the cheapest sort since MUA usually resorts
-               $opt->{'sort'} //= 'docid' if $devfd < 0;
                $lei->{l2m} = eval { PublicInbox::LeiToMail->new($lei) };
                return $lei->fail($@) if $@;
                if ($opt->{mua} && $lei->{l2m}->lock_free) {