]> Sergey Matveev's repositories - public-inbox.git/blobdiff - lib/PublicInbox/LeiOverview.pm
lei_overview: avoid unnecessary {l2m} delete
[public-inbox.git] / lib / PublicInbox / LeiOverview.pm
index 538d6bd56cbf1d1bb530a8ca07f846f82dba0f1f..ff15d2951c0c52375336e396e739174ce04faddb 100644 (file)
@@ -26,16 +26,28 @@ sub _iso8601 ($) { strftime('%Y-%m-%dT%H:%M:%SZ', gmtime($_[0])) }
 # we open this in the parent process before ->wq_do handoff
 sub ovv_out_lk_init ($) {
        my ($self) = @_;
-       $self->{tmp_lk_id} = "$self.$$";
        my $tmp = File::Temp->new("lei-ovv.dst.$$.lock-XXXXXX",
                                        TMPDIR => 1, UNLINK => 0);
-       $self->{lock_path} = $tmp->filename;
+       $self->{"lk_id.$self.$$"} = $self->{lock_path} = $tmp->filename;
 }
 
 sub ovv_out_lk_cancel ($) {
        my ($self) = @_;
-       ($self->{tmp_lk_id}//'') eq "$self.$$" and
-               unlink(delete($self->{lock_path}));
+       my $lock_path = delete $self->{"lk_id.$self.$$"} or return;
+       unlink($lock_path);
+}
+
+sub detect_fmt ($$) {
+       my ($lei, $dst) = @_;
+       if ($dst =~ m!\A([:/]+://)!) {
+               $lei->fail("$1 support not implemented, yet\n");
+       } elsif (!-e $dst || -d _) {
+               'maildir'; # the default TODO: MH?
+       } elsif (-f _ || -p _) {
+               $lei->fail("unable to determine mbox family of $dst\n");
+       } else {
+               $lei->fail("unable to determine format of $dst\n");
+       }
 }
 
 sub new {
@@ -54,7 +66,7 @@ sub new {
 
        }
        $fmt //= 'json' if $dst eq '/dev/stdout';
-       $fmt //= 'maildir';
+       $fmt //= detect_fmt($lei, $dst) or return;
 
        if (index($dst, '://') < 0) { # not a URL, so assume path
                 $dst = File::Spec->canonpath($dst);
@@ -79,12 +91,14 @@ sub new {
                        ovv_out_lk_init($self);
                }
        }
-       if (!$json) {
+       if ($json) {
+               $lei->{dedupe} //= PublicInbox::LeiDedupe->new($lei);
+       } else {
                # default to the cheapest sort since MUA usually resorts
                $lei->{opt}->{'sort'} //= 'docid' if $dst ne '/dev/stdout';
-               $lei->{l2m} = PublicInbox::LeiToMail->new($lei);
+               $lei->{l2m} = eval { PublicInbox::LeiToMail->new($lei) };
+               return $lei->fail($@) if $@;
        }
-       $lei->{dedupe} //= PublicInbox::LeiDedupe->new($lei);
        $self;
 }
 
@@ -92,7 +106,7 @@ sub new {
 sub ovv_begin {
        my ($self, $lei) = @_;
        if ($self->{fmt} eq 'json') {
-               print { $lei->{1} } '[';
+               $lei->out('[');
        } # TODO HTML/Atom/...
 }
 
@@ -102,17 +116,12 @@ sub ovv_end {
        if ($self->{fmt} eq 'json') {
                # JSON doesn't allow trailing commas, and preventing
                # trailing commas is a PITA when parallelizing outputs
-               print { $lei->{1} } "null]\n";
+               $lei->out("null]\n");
        } elsif ($self->{fmt} eq 'concatjson') {
-               print { $lei->{1} } "\n";
+               $lei->out("\n");
        }
 }
 
-sub ovv_atfork_child {
-       my ($self) = @_;
-       # reopen dedupe here
-}
-
 # prepares an smsg for JSON
 sub _unbless_smsg {
        my ($smsg, $mitem) = @_;
@@ -120,11 +129,9 @@ sub _unbless_smsg {
        delete @$smsg{qw(lines bytes num tid)};
        $smsg->{rt} = _iso8601(delete $smsg->{ts}); # JMAP receivedAt
        $smsg->{dt} = _iso8601(delete $smsg->{ds}); # JMAP UTCDate
-       $smsg->{relevance} = get_pct($mitem) if $mitem;
-
+       $smsg->{pct} = get_pct($mitem) if $mitem;
        if (my $r = delete $smsg->{references}) {
-               $smsg->{refs} = [
-                               map { "<$_>" } ($r =~ m/$MID_EXTRACT/go) ];
+               $smsg->{refs} = [ map { "<$_>" } ($r =~ m/$MID_EXTRACT/go) ];
        }
        if (my $m = delete($smsg->{mid})) {
                $smsg->{'m'} = "<$m>";
@@ -140,10 +147,8 @@ sub _unbless_smsg {
 
 sub ovv_atexit_child {
        my ($self, $lei) = @_;
-       if (my $l2m = delete $lei->{l2m}) {
-               # gracefully stop lei2mail processes after all
-               # ->write_mail work is complete
-               delete $l2m->{-wq_s1};
+       if (my $l2m = $lei->{l2m}) {
+               # wait for ->write_mail work we submitted to lei2mail
                if (my $rd = delete $l2m->{each_smsg_done}) {
                        read($rd, my $buf, 1); # wait for EOF
                }
@@ -154,9 +159,8 @@ sub ovv_atexit_child {
                $git->async_wait_all;
        }
        if (my $bref = delete $lei->{ovv_buf}) {
-               my $out = $lei->{1} or return;
                my $lk = $self->lock_for_scope;
-               print $out $$bref;
+               $lei->out($$bref);
        }
 }
 
@@ -188,7 +192,7 @@ sub _json_pretty {
 
 sub ovv_each_smsg_cb { # runs in wq worker usually
        my ($self, $lei, $ibxish) = @_;
-       my $json;
+       my ($json, $dedupe);
        $lei->{1}->autoflush(1);
        if (my $pkg = $self->{json}) {
                $json = $pkg->new;
@@ -196,24 +200,36 @@ sub ovv_each_smsg_cb { # runs in wq worker usually
                $json->ascii(1) if $lei->{opt}->{ascii};
        }
        my $l2m = $lei->{l2m};
-       if ($l2m && $l2m->{-wq_s1}) {
+       if (!$l2m) {
+               $dedupe = $lei->{dedupe} // die 'BUG: {dedupe} missing';
+               $dedupe->prepare_dedupe;
+       }
+       $lei->{ovv_buf} = \(my $buf = '') if !$l2m;
+       if ($l2m && !$ibxish) { # remote https?:// mboxrd
+               delete $l2m->{-wq_s1};
+               my $g2m = $l2m->can('git_to_mail');
+               my $wcb = $l2m->write_cb($lei);
+               sub {
+                       my ($smsg, undef, $eml) = @_; # no mitem in $_[1]
+                       $wcb->(undef, $smsg, $eml);
+               };
+       } elsif ($l2m && $l2m->{-wq_s1}) {
                my ($lei_ipc, @io) = $lei->atfork_parent_wq($l2m);
-               # n.b. $io[0] = qry_status_wr, $io[1] = mbox|stdout,
-               # $io[4] becomes a notification pipe that triggers EOF
+               # $io[-1] becomes a notification pipe that triggers EOF
                # in this wq worker when all outstanding ->write_mail
                # calls are complete
-               die "BUG: \$io[4] $io[4] unexpected" if $io[4];
-               pipe($l2m->{each_smsg_done}, $io[4]) or die "pipe: $!";
-               fcntl($io[4], 1031, 4096) if $^O eq 'linux';
+               pipe($l2m->{each_smsg_done}, $io[$#io + 1]) or die "pipe: $!";
+               fcntl($io[-1], 1031, 4096) if $^O eq 'linux'; # F_SETPIPE_SZ
                delete @$lei_ipc{qw(l2m opt mset_opt cmd)};
+               $lei_ipc->{each_smsg_not_done} = $#io;
                my $git = $ibxish->git; # (LeiXSearch|Inbox|ExtSearch)->git
                $self->{git} = $git;
                my $git_dir = $git->{git_dir};
                sub {
                        my ($smsg, $mitem) = @_;
-                       my $kw = []; # TODO get from mitem
-                       $l2m->wq_do('write_mail', \@io, $git_dir,
-                                       $smsg->{blob}, $lei_ipc, $kw)
+                       $smsg->{pct} = get_pct($mitem) if $mitem;
+                       $l2m->wq_do('write_mail', \@io, $git_dir, $smsg,
+                                       $lei_ipc);
                }
        } elsif ($l2m) {
                my $wcb = $l2m->write_cb($lei);
@@ -222,14 +238,14 @@ sub ovv_each_smsg_cb { # runs in wq worker usually
                my $g2m = $l2m->can('git_to_mail');
                sub {
                        my ($smsg, $mitem) = @_;
-                       my $kw = []; # TODO get from mitem
-                       $git->cat_async($smsg->{blob}, $g2m, [ $wcb, $kw ]);
+                       $smsg->{pct} = get_pct($mitem) if $mitem;
+                       $git->cat_async($smsg->{blob}, $g2m, [ $wcb, $smsg ]);
                };
        } elsif ($self->{fmt} =~ /\A(concat)?json\z/ && $lei->{opt}->{pretty}) {
                my $EOR = ($1//'') eq 'concat' ? "\n}" : "\n},";
-               $lei->{ovv_buf} = \(my $buf = '');
                sub { # DIY prettiness :P
                        my ($smsg, $mitem) = @_;
+                       return if $dedupe->is_smsg_dup($smsg);
                        $smsg = _unbless_smsg($smsg, $mitem);
                        $buf .= "{\n";
                        $buf .= join(",\n", map {
@@ -242,28 +258,21 @@ sub ovv_each_smsg_cb { # runs in wq worker usually
                                }
                        } sort keys %$smsg);
                        $buf .= $EOR;
-                       if (length($buf) > 65536) {
-                               my $lk = $self->lock_for_scope;
-                               print { $lei->{1} } $buf;
-                               $buf = '';
-                       }
+                       return if length($buf) < 65536;
+                       my $lk = $self->lock_for_scope;
+                       $lei->out($buf);
+                       $buf = '';
                }
        } elsif ($json) {
                my $ORS = $self->{fmt} eq 'json' ? ",\n" : "\n"; # JSONL
-               $lei->{ovv_buf} = \(my $buf = '');
                sub {
                        my ($smsg, $mitem) = @_;
-                       delete @$smsg{qw(tid num)};
+                       return if $dedupe->is_smsg_dup($smsg);
                        $buf .= $json->encode(_unbless_smsg(@_)) . $ORS;
-                       if (length($buf) > 65536) {
-                               my $lk = $self->lock_for_scope;
-                               print { $lei->{1} } $buf;
-                               $buf = '';
-                       }
-               }
-       } elsif ($self->{fmt} eq 'oid') {
-               sub {
-                       my ($smsg, $mitem) = @_;
+                       return if length($buf) < 65536;
+                       my $lk = $self->lock_for_scope;
+                       $lei->out($buf);
+                       $buf = '';
                }
        } # else { ...
 }