view: always compress Message-IDs for anchors

[public-inbox.git] / lib / PublicInbox / MID.pm

diff --git a/lib/PublicInbox/MID.pm b/lib/PublicInbox/MID.pm
index e5a30a1b0924c04ed721837f47ba49b2f411ddcb..2f0c09fb843e770b9307fcca31405ec4fd362275 100644 (file)
--- a/lib/PublicInbox/MID.pm
+++ b/lib/PublicInbox/MID.pm
@@ -4,7 +4,7 @@ package PublicInbox::MID;
 use strict;
 use warnings;
 use base qw/Exporter/;
-our @EXPORT_OK = qw/mid_clean mid_compressed/;
+our @EXPORT_OK = qw/mid_clean mid_compressed mid2path/;
 use Digest::SHA qw/sha1_hex/;
 use constant MID_MAX => 40; # SHA-1 hex length
 
@@ -19,9 +19,29 @@ sub mid_clean {
 
 # this is idempotent
 sub mid_compressed {
-       my ($mid) = @_;
-       return $mid if (length($mid) <= MID_MAX);
+       my ($mid, $force) = @_;
+
+       # XXX dirty hack! FIXME!
+       # Some HTTP servers (apache2 2.2.22-13+deb7u5 on my system)
+       # apparently do not handle "%25" in the URL path component correctly.
+       # I'm not yet sure if it's something weird with my rewrite rules
+       # or what; will need to debug...
+       return sha1_hex($mid) if (index($mid, '%') >= 0);
+
+       return $mid if (!$force && length($mid) <= MID_MAX);
        sha1_hex($mid);
 }
 
+sub mid2path {
+       my ($mid) = @_;
+       my ($x2, $x38) = ($mid =~ /\A([a-f0-9]{2})([a-f0-9]{38})\z/);
+
+       unless (defined $x38) {
+               # compatibility with old links (or short Message-IDs :)
+               $mid = sha1_hex($mid);
+               ($x2, $x38) = ($mid =~ /\A([a-f0-9]{2})([a-f0-9]{38})\z/);
+       }
+       "$x2/$x38";
+}
+
 1;