sub dbh_new {
my ($self, $rw) = @_;
- my $f = $self->{filename};
- if ($rw && !-f $f) { # SQLite defaults mode to 0644, we want 0666
- open my $fh, '+>>', $f or die "failed to open $f: $!";
+ my $f = delete $self->{filename};
+ if (!-f $f) { # SQLite defaults mode to 0644, we want 0666
+ if ($rw) {
+ require PublicInbox::Spawn;
+ open my $fh, '+>>', $f or die "failed to open $f: $!";
+ PublicInbox::Spawn::set_nodatacow(fileno($fh));
+ my $j = "$f-journal";
+ open $fh, '+>>', $j or die "failed to open $j: $!";
+ PublicInbox::Spawn::set_nodatacow(fileno($fh));
+ } else {
+ $self->{filename} = $f; # die on stat() below:
+ }
}
my (@st, $st, $dbh);
my $tries = 0;
$st = pack('dd', $st[0], $st[1]);
} while ($st ne $self->{st} && $tries++ < 3);
warn "W: $f: .st_dev, .st_ino unstable\n" if $st ne $self->{st};
+ $dbh->do('PRAGMA synchronous = OFF') if ($rw // 0) > 1;
$dbh;
}
bless { filename => $f }, $class;
}
-sub disconnect { $_[0]->{dbh} = undef }
+sub disconnect {
+ my ($self) = @_;
+ if (my $dbh = delete $self->{dbh}) {
+ $self->{filename} = $dbh->sqlite_db_filename;
+ }
+}
-sub connect { $_[0]->{dbh} ||= $_[0]->dbh_new }
+sub connect { $_[0]->{dbh} //= $_[0]->dbh_new }
sub load_from_row ($;$) {
my ($smsg, $cull) = @_;
sub check_inodes {
my ($self) = @_;
- if (my @st = stat($self->{filename})) { # did st_dev, st_ino change?
+ my $dbh = $self->{dbh} or return;
+ my $f = $dbh->sqlite_db_filename;
+ if (my @st = stat($f)) { # did st_dev, st_ino change?
my $st = pack('dd', $st[0], $st[1]);
# don't actually reopen, just let {dbh} be recreated later
- delete($self->{dbh}) if ($st ne ($self->{st} // $st));
+ if ($st ne ($self->{st} // $st)) {
+ delete($self->{dbh});
+ $self->{filename} = $f;
+ }
} else {
- warn "W: stat $self->{filename}: $!\n";
+ warn "W: stat $f: $!\n";
}
}