# are denoted by a negative NNTP article number.
package PublicInbox::OverIdx;
use strict;
-use warnings;
-use base qw(PublicInbox::Over);
+use v5.10.1;
+use parent qw(PublicInbox::Over);
use IO::Handle;
use DBI qw(:sql_types); # SQL_BLOB
use PublicInbox::MID qw/id_compress mids_for_index references/;
use PublicInbox::Smsg qw(subject_normalized);
use Compress::Zlib qw(compress);
-use PublicInbox::Search;
use Carp qw(croak);
sub dbh_new {
my ($self) = @_;
my $dbh = $self->SUPER::dbh_new($self->{-no_fsync} ? 2 : 1);
- # TRUNCATE reduces I/O compared to the default (DELETE)
- # We do not use WAL since we're optimized for read-only ops,
- # (and read-only requires SQLite 3.22.0 (2018-01-22)).
- $dbh->do('PRAGMA journal_mode = TRUNCATE');
-
# 80000 pages (80MiB on SQLite <3.12.0, 320MiB on 3.12.0+)
# was found to be good in 2018 during the large LKML import
# at the time. This ought to be configurable based on HW
if (my $del = delete $self->{-ghosts_to_delete}) {
delete_by_num($self, $_) for @$del;
}
- $tid // create_ghost($self, $mid);
-}
-
-sub create_ghost {
- my ($self, $mid) = @_;
- my $id = mid2id($self, $mid);
- my $num = next_ghost_num($self);
- $num < 0 or die "ghost num is non-negative: $num\n";
- my $tid = next_tid($self);
- my $dbh = $self->{dbh};
- $dbh->prepare_cached(<<'')->execute($num, $tid);
+ $tid // do { # create a new ghost
+ my $id = mid2id($self, $mid);
+ my $num = next_ghost_num($self);
+ $num < 0 or die "ghost num is non-negative: $num\n";
+ $tid = next_tid($self);
+ my $dbh = $self->{dbh};
+ $dbh->prepare_cached(<<'')->execute($num, $tid);
INSERT INTO over (num, tid) VALUES (?,?)
- $dbh->prepare_cached(<<'')->execute($id, $num);
+ $dbh->prepare_cached(<<'')->execute($id, $num);
INSERT INTO id2num (id, num) VALUES (?,?)
- $tid;
+ $tid;
+ };
}
sub merge_threads {
$dbh->do(<<'');
CREATE TABLE IF NOT EXISTS over (
- num INTEGER NOT NULL,
- tid INTEGER NOT NULL,
- sid INTEGER,
- ts INTEGER,
- ds INTEGER,
- ddd VARBINARY, /* doc-data-deflated */
+ num INTEGER NOT NULL, /* NNTP article number == IMAP UID */
+ tid INTEGER NOT NULL, /* THREADID (IMAP REFERENCES threading, JMAP) */
+ sid INTEGER, /* Subject ID (IMAP ORDEREDSUBJECT "threading") */
+ ts INTEGER, /* IMAP INTERNALDATE (Received: header, git commit time) */
+ ds INTEGER, /* RFC-2822 sent Date: header, git author time */
+ ddd VARBINARY, /* doc-data-deflated (->to_doc_data, ->load_from_data) */
UNIQUE (num)
)
$dbh->do(<<'');
CREATE TABLE IF NOT EXISTS subject (
sid INTEGER PRIMARY KEY AUTOINCREMENT,
- path VARCHAR(40) NOT NULL,
+ path VARCHAR(40) NOT NULL, /* SHA-1 of normalized subject */
UNIQUE (path)
)
$dbh->do(<<'');
CREATE TABLE IF NOT EXISTS id2num (
- id INTEGER NOT NULL,
+ id INTEGER NOT NULL, /* <=> msgid.id */
num INTEGER NOT NULL,
UNIQUE (id, num)
)
$dbh->do(<<'');
CREATE TABLE IF NOT EXISTS msgid (
- id INTEGER PRIMARY KEY AUTOINCREMENT,
+ id INTEGER PRIMARY KEY AUTOINCREMENT, /* <=> id2num.id */
mid VARCHAR(244) NOT NULL,
UNIQUE (mid)
)
sub begin_lazy {
my ($self) = @_;
return if $self->{txn};
- my $dbh = $self->connect or return;
+ my $dbh = $self->dbh or return;
$dbh->begin_work;
# $dbh->{Profile} = 2;
$self->{txn} = 1;
$self->{dbh}->rollback;
}
-sub disconnect {
+sub dbh_close {
my ($self) = @_;
die "in transaction" if $self->{txn};
- $self->SUPER::disconnect;
+ $self->SUPER::dbh_close;
}
sub create {
File::Path::mkpath(File::Basename::dirname($self->{filename}));
}
# create the DB:
- PublicInbox::Over::connect($self);
- $self->disconnect;
+ PublicInbox::Over::dbh($self);
+ $self->dbh_close;
}
sub rethread_prepare {