use warnings;
sub thread {
- my ($messages, $ordersub, $ibx) = @_;
+ my ($msgs, $ordersub, $ibx) = @_;
my $id_table = {};
- _add_message($id_table, $_) foreach @$messages;
+
+ # Sadly, we sort here anyways since the fill-in-the-blanks References:
+ # can be shakier if somebody used In-Reply-To with multiple, disparate
+ # messages. So, take the client Date: into account since we can't
+ # alway determine ordering when somebody uses multiple In-Reply-To.
+ # We'll trust the client Date: header here instead of the Received:
+ # time since this is for display (and not retrieval)
+ _add_message($id_table, $_) for sort { $a->{ds} <=> $b->{ds} } @$msgs;
my $rootset = [ grep {
!delete($_->{parent}) && $_->visible($ibx)
} values %$id_table ];
my $this = _get_cont_for_id($id_table, $smsg->{mid});
$this->{smsg} = $smsg;
+ # saves around 4K across 1K messages
+ # TODO: move this to a more appropriate place, breaks tests
+ # if we do it during psgi_cull
+ delete $smsg->{num};
+
# B. For each element in the message's References field:
defined(my $refs = $smsg->{references}) or return;
# C. Set the parent of this message to be the last element in
# References.
- $prev->add_child($this) if defined $prev;
+ if (defined $prev && !$this->has_descendent($prev)) { # would loop
+ $prev->add_child($this);
+ }
}
package PublicInbox::SearchThread::Msg;