-# Copyright (C) 2014, Eric Wong <normalperson@yhbt.net> and all contributors
-# License: AGPLv3 or later (https://www.gnu.org/licenses/agpl-3.0.txt)
+# Copyright (C) 2014-2018 all contributors <meta@public-inbox.org>
+# License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
use strict;
use warnings;
use Test::More;
use PublicInbox::Config;
use File::Temp qw/tempdir/;
-my $tmpdir = tempdir(CLEANUP => 1);
+my $tmpdir = tempdir('pi-config-XXXXXX', TMPDIR => 1, CLEANUP => 1);
{
is(system(qw(git init -q --bare), $tmpdir), 0, "git init successful");
- {
- local $ENV{GIT_DIR} = $tmpdir;
- is(system(qw(git config foo.bar hihi)), 0, "set config");
- }
+ my @cmd = ('git', "--git-dir=$tmpdir", qw(config foo.bar hihi));
+ is(system(@cmd), 0, "set config");
my $tmp = PublicInbox::Config->new("$tmpdir/config");
ok(-r $f, "$f is readable");
my $cfg = PublicInbox::Config->new($f);
- is_deeply($cfg->lookup('bugs@public-inbox.org'), {
- 'failrepo' => '/home/pi/bugs-fail.git',
- 'mainrepo' => '/home/pi/bugs-main.git',
- 'address' => 'bugs@public-inbox.org',
- 'description' => 'development discussion'
+ is_deeply($cfg->lookup('meta@public-inbox.org'), {
+ 'mainrepo' => '/home/pi/meta-main.git',
+ 'address' => [ 'meta@public-inbox.org' ],
+ 'domain' => 'public-inbox.org',
+ 'url' => 'http://example.com/meta',
+ -primary_address => 'meta@public-inbox.org',
+ 'name' => 'meta',
+ feedmax => 25,
+ -httpbackend_limiter => undef,
+ nntpserver => undef,
}, "lookup matches expected output");
is($cfg->lookup('blah@example.com'), undef,
"non-existent lookup returns undef");
+
+ my $test = $cfg->lookup('test@public-inbox.org');
+ is_deeply($test, {
+ 'address' => ['try@public-inbox.org',
+ 'sandbox@public-inbox.org',
+ 'test@public-inbox.org'],
+ -primary_address => 'try@public-inbox.org',
+ 'mainrepo' => '/home/pi/test-main.git',
+ 'domain' => 'public-inbox.org',
+ 'name' => 'test',
+ feedmax => 25,
+ 'url' => 'http://example.com/test',
+ -httpbackend_limiter => undef,
+ nntpserver => undef,
+ }, "lookup matches expected output for test");
+}
+
+
+{
+ my $cfgpfx = "publicinbox.test";
+ my @altid = qw(serial:gmane:file=a serial:enamg:file=b);
+ my $config = PublicInbox::Config->new({
+ "$cfgpfx.address" => 'test@example.com',
+ "$cfgpfx.mainrepo" => '/path/to/non/existent',
+ "$cfgpfx.altid" => [ @altid ],
+ });
+ my $ibx = $config->lookup_name('test');
+ is_deeply($ibx->{altid}, [ @altid ]);
+}
+
+{
+ my $pfx = "publicinbox.test";
+ my %h = (
+ "$pfx.address" => 'test@example.com',
+ "$pfx.mainrepo" => '/path/to/non/existent',
+ "publicinbox.nntpserver" => 'news.example.com',
+ );
+ my %tmp = %h;
+ my $cfg = PublicInbox::Config->new(\%tmp);
+ my $ibx = $cfg->lookup_name('test');
+ is($ibx->{nntpserver}, 'news.example.com', 'global NNTP server');
+
+ delete $h{'publicinbox.nntpserver'};
+ $h{"$pfx.nntpserver"} = 'news.alt.example.com';
+ $cfg = PublicInbox::Config->new(\%h);
+ $ibx = $cfg->lookup_name('test');
+ is($ibx->{nntpserver}, 'news.alt.example.com','per-inbox NNTP server');
+}
+
+# no obfuscate domains
+{
+ my $pfx = "publicinbox.test";
+ my $pfx2 = "publicinbox.foo";
+ my %h = (
+ "$pfx.address" => 'test@example.com',
+ "$pfx.mainrepo" => '/path/to/non/existent',
+ "$pfx2.address" => 'foo@example.com',
+ "$pfx2.mainrepo" => '/path/to/foo',
+ lc("publicinbox.noObfuscate") =>
+ 'public-inbox.org @example.com z@EXAMPLE.com',
+ "$pfx.obfuscate" => 'true', # :<
+ );
+ my %tmp = %h;
+ my $cfg = PublicInbox::Config->new(\%tmp);
+ my $ibx = $cfg->lookup_name('test');
+ my $re = $ibx->{-no_obfuscate_re};
+ like('meta@public-inbox.org', $re,
+ 'public-inbox.org address not to be obfuscated');
+ like('t@example.com', $re, 'example.com address not to be obfuscated');
+ unlike('t@example.comM', $re, 'example.comM address does not match');
+ is_deeply($ibx->{-no_obfuscate}, {
+ 'test@example.com' => 1,
+ 'foo@example.com' => 1,
+ 'z@example.com' => 1,
+ }, 'known addresses populated');
+}
+
+my @invalid = (
+ # git rejects this because it locks refnames, but we don't have
+ # this problem with inbox names:
+ # 'inbox.lock',
+
+ # git rejects these:
+ '', '..', '.', 'stash@{9}', 'inbox.', '^caret', '~tilde',
+ '*asterisk', 's p a c e s', ' leading-space', 'trailing-space ',
+ 'question?', 'colon:', '[square-brace]', "\fformfeed",
+ "\0zero", "\bbackspace",
+
+);
+
+require Data::Dumper;
+for my $s (@invalid) {
+ my $d = Data::Dumper->new([$s])->Terse(1)->Indent(0)->Dump;
+ ok(!PublicInbox::Config::valid_inbox_name($s), "$d name rejected");
+}
+
+# obviously-valid examples
+my @valid = qw(a a@example a@example.com);
+
+# Rejecting more was considered, but then it dawned on me that
+# people may intentionally use inbox names which are not URL-friendly
+# to prevent the PSGI interface from displaying them...
+# URL-unfriendly
+# '<', '>', '%', '#', '?', '&', '(', ')',
+
+# maybe these aren't so bad, they're common in Message-IDs, even:
+# '!', '$', '=', '+'
+push @valid, qw[bang! ca$h less< more> 1% (parens) &more eql= +plus], '#hash';
+for my $s (@valid) {
+ my $d = Data::Dumper->new([$s])->Terse(1)->Indent(0)->Dump;
+ ok(PublicInbox::Config::valid_inbox_name($s), "$d name accepted");
+}
+
+{
+ my $f = "$tmpdir/ordered";
+ open my $fh, '>', $f or die "open: $!";
+ my @expect;
+ foreach my $i (0..3) {
+ push @expect, "$i";
+ print $fh <<"" or die "print: $!";
+[publicinbox "$i"]
+ mainrepo = /path/to/$i.git
+ address = $i\@example.com
+
+ }
+ close $fh or die "close: $!";
+ my $cfg = PublicInbox::Config->new($f);
+ my @result;
+ $cfg->each_inbox(sub { push @result, $_[0]->{name} });
+ is_deeply(\@result, \@expect);
+}
+
+{
+ my $pfx1 = "publicinbox.test1";
+ my $pfx2 = "publicinbox.test2";
+ my $h = {
+ "$pfx1.address" => 'test@example.com',
+ "$pfx1.mainrepo" => '/path/to/non/existent',
+ "$pfx2.address" => 'foo@example.com',
+ "$pfx2.mainrepo" => '/path/to/foo',
+ "$pfx1.coderepo" => 'project',
+ "$pfx2.coderepo" => 'project',
+ "coderepo.project.dir" => '/path/to/project.git',
+ };
+ my $cfg = PublicInbox::Config->new($h);
+ my $t1 = $cfg->lookup_name('test1');
+ my $t2 = $cfg->lookup_name('test2');
+ is($t1->{-repo_objs}->[0], $t2->{-repo_objs}->[0],
+ 'inboxes share ::Git object');
}
done_testing();