This appears to significantly improve header caching behavior
with mutt. With the current public-inbox.org/git mirror(*),
mutt will only re-FETCH the last ~300 or so messages in the
final "inbox.comp.version-control.git.7" mailbox, instead of
~49,000 messages every time.
It's not perfect, but a 500ms query is better than a >10s query
and mutt itself spends as much time loading its header cache.
(*) there are many gaps in NNTP article numbers (UIDs) due to
spam removal from public-inbox-learn.
$self->requeue if $new_size == 1;
}
$self->requeue if $new_size == 1;
}
-# my ($uid_base, $UID) = @_;
-sub fetch_msn_uid ($$) { '* '.($_[1] - $_[0]).' FETCH (UID '.$_[1] }
+# my ($msn, $UID) = @_;
+sub fetch_msn_uid ($$) { '* '.(${$_[0]}++).' FETCH (UID '.$_[1] }
- my ($self, $uid_base, $smsg, $bref, $ops, $partial) = @_;
- $self->msg_more(fetch_msn_uid($uid_base, $smsg->{num}));
+ my ($self, $msn, $smsg, $bref, $ops, $partial) = @_;
+ $self->msg_more(fetch_msn_uid($msn, $smsg->{num}));
my ($eml, $k);
for (my $i = 0; $i < @$ops;) {
$k = $ops->[$i++];
my ($eml, $k);
for (my $i = 0; $i < @$ops;) {
$k = $ops->[$i++];
sub fetch_blob_cb { # called by git->cat_async via git_async_cat
my ($bref, $oid, $type, $size, $fetch_arg) = @_;
sub fetch_blob_cb { # called by git->cat_async via git_async_cat
my ($bref, $oid, $type, $size, $fetch_arg) = @_;
- my ($self, undef, $msgs, undef, $ops, $partial) = @$fetch_arg;
+ my ($self, undef, $msgs, $range_info, $ops, $partial) = @$fetch_arg;
my $smsg = shift @$msgs or die 'BUG: no smsg';
if (!defined($oid)) {
# it's possible to have TOCTOU if an admin runs
my $smsg = shift @$msgs or die 'BUG: no smsg';
if (!defined($oid)) {
# it's possible to have TOCTOU if an admin runs
} else {
$smsg->{blob} eq $oid or die "BUG: $smsg->{blob} != $oid";
}
} else {
$smsg->{blob} eq $oid or die "BUG: $smsg->{blob} != $oid";
}
- fetch_run_ops($self, $self->{uid_base}, $smsg, $bref, $ops, $partial);
+ fetch_run_ops($self, $range_info->[3], $smsg, $bref, $ops, $partial);
return 'BAD fetch range';
}
uid_clamp($self, \$beg, \$end) if defined($range);
return 'BAD fetch range';
}
uid_clamp($self, \$beg, \$end) if defined($range);
- [ $beg, $end, $$range_csv ];
+ my $msn = $beg - $self->{uid_base};
+ [ $beg, $end, $$range_csv, \$msn ];
}
sub refill_range ($$$) {
}
sub refill_range ($$$) {
- my $uid_base = $self->{uid_base};
- fetch_run_ops($self, $uid_base, $_, undef, $ops) for @$msgs;
+ fetch_run_ops($self, $range_info->[3], $_, undef, $ops) for @$msgs;
- my $uid_base = $self->{uid_base};
+ my $msn = $range_info->[3];
- $self->msg_more(fetch_msn_uid($uid_base, $_));
+ $self->msg_more(fetch_msn_uid($msn, $_));
for ($i = 0; $i < @$ops;) {
$k = $ops->[$i++];
$ops->[$i++]->($self, $k);
for ($i = 0; $i < @$ops;) {
$k = $ops->[$i++];
$ops->[$i++]->($self, $k);
}
my $r2 = $mic->fetch_hash('1:*', 'BODY.PEEK[]') or BAIL_OUT "FETCH $@";
is(scalar keys %$r2, 2, 'did not get all 3 messages');
}
my $r2 = $mic->fetch_hash('1:*', 'BODY.PEEK[]') or BAIL_OUT "FETCH $@";
is(scalar keys %$r2, 2, 'did not get all 3 messages');
-is($r2->{2}->{'BODY[]'}, $ret->{2}->{RFC822}, 'message 2 unchanged');
-is($r2->{3}->{'BODY[]'}, $ret->{3}->{RFC822}, 'message 3 unchanged');
+is($r2->{1}->{'BODY[]'}, $ret->{2}->{RFC822}, 'message 2 unchanged');
+is($r2->{2}->{'BODY[]'}, $ret->{3}->{RFC822}, 'message 3 unchanged');
$r2 = $mic->fetch_hash(2, 'BODY.PEEK[HEADER.FIELDS (message-id)]')
or BAIL_OUT "FETCH $@";
is($r2->{2}->{'BODY[HEADER.FIELDS (MESSAGE-ID)]'},
$r2 = $mic->fetch_hash(2, 'BODY.PEEK[HEADER.FIELDS (message-id)]')
or BAIL_OUT "FETCH $@";
is($r2->{2}->{'BODY[HEADER.FIELDS (MESSAGE-ID)]'},