]> Sergey Matveev's repositories - btrtrc.git/commitdiff
Add a bunch of TODOs
authorMatt Joiner <anacrolix@gmail.com>
Tue, 13 Feb 2018 00:18:23 +0000 (11:18 +1100)
committerMatt Joiner <anacrolix@gmail.com>
Tue, 13 Feb 2018 00:18:23 +0000 (11:18 +1100)
tracker/http.go
tracker/tracker.go
tracker/udp.go

index 6c9dcafc96157beaf586fbbff9fe98d609983425..36cfa30313a8b9297a44cef1e532bc1db9340451 100644 (file)
@@ -78,7 +78,8 @@ func setAnnounceParams(_url *url.URL, ar *AnnounceRequest) {
        }
        // http://stackoverflow.com/questions/17418004/why-does-tracker-server-not-understand-my-request-bittorrent-protocol
        q.Set("compact", "1")
-       // According to https://wiki.vuze.com/w/Message_Stream_Encryption.
+       // According to https://wiki.vuze.com/w/Message_Stream_Encryption. TODO:
+       // Take EncryptionPolicy or something like it as a parameter.
        q.Set("supportcrypto", "1")
 
        _url.RawQuery = q.Encode()
index 9ee824c0db0603d450c09626491459f4bc60da2c..f2cea82e9d852a980f62a6873c6b6205f5484b0a 100644 (file)
@@ -47,6 +47,8 @@ var (
        ErrBadScheme = errors.New("unknown scheme")
 )
 
+// TODO: Just split udp/http announcing completely, to support various different options they have.
+
 func Announce(cl *http.Client, userAgent string, urlStr string, req *AnnounceRequest) (res AnnounceResponse, err error) {
        return AnnounceHost(cl, userAgent, urlStr, req, "")
 }
index 0302a4e8a8be963b6e89673d7ec4086c91629a9e..8c3b632d422cbe9e61570fa44e23596c5493db6f 100644 (file)
@@ -257,6 +257,8 @@ func (c *udpAnnounce) connect() (err error) {
        return
 }
 
+// TODO: Split on IPv6, as BEP 15 says response peer decoding depends on
+// network in use.
 func announceUDP(ar *AnnounceRequest, _url *url.URL) (AnnounceResponse, error) {
        ua := udpAnnounce{
                url: *_url,