]> Sergey Matveev's repositories - btrtrc.git/commitdiff
Lower log level for peer upload read errors when Torrent is closed
authorMatt Joiner <anacrolix@gmail.com>
Tue, 6 May 2025 02:17:36 +0000 (12:17 +1000)
committerMatt Joiner <anacrolix@gmail.com>
Tue, 6 May 2025 02:17:36 +0000 (12:17 +1000)
Fixes #980.

peerconn.go

index 2a3fd94720068b5ca03393b9b56f0905da58d65a..27fa820f4e0f5b7b715730522fb23a3fd5adc5bb 100644 (file)
@@ -673,9 +673,11 @@ func (c *PeerConn) peerRequestDataReader(r Request, prs *peerRequestState) {
 func (c *PeerConn) peerRequestDataReadFailed(err error, r Request) {
        torrent.Add("peer request data read failures", 1)
        logLevel := log.Warning
-       if c.t.hasStorageCap() {
+       if c.t.hasStorageCap() || c.t.closed.IsSet() {
                // It's expected that pieces might drop. See
-               // https://github.com/anacrolix/torrent/issues/702#issuecomment-1000953313.
+               // https://github.com/anacrolix/torrent/issues/702#issuecomment-1000953313. Also the torrent
+               // may have been Dropped, and the user expects to own the files, see
+               // https://github.com/anacrolix/torrent/issues/980.
                logLevel = log.Debug
        }
        c.logger.Levelf(logLevel, "error reading chunk for peer Request %v: %v", r, err)