lei q: only start pager if output is to stdout

No need to be starting a pager if we're writing to a regular file.

diff --git a/lib/PublicInbox/LeiOverview.pm b/lib/PublicInbox/LeiOverview.pm
index e6bf4f2a95d0cc1788986bcd05602a9ebef5d4cd..3125f015499e5e7833f3f0036129293623e19b31 100644 (file)
--- a/lib/PublicInbox/LeiOverview.pm
+++ b/lib/PublicInbox/LeiOverview.pm
@@ -78,9 +78,8 @@ sub new {
        if ($fmt =~ /\A($JSONL|(?:concat)?json)\z/) {
                $json = $self->{json} = ref(PublicInbox::Config->json);
        }
-       my ($isatty, $seekable);
        if ($dst eq '/dev/stdout') {
-               $isatty = -t $lei->{1};
+               my $isatty = $lei->{need_pager} = -t $lei->{1};
                $opt->{pretty} //= $isatty;
                if (!$isatty && -f _) {
                        my $fl = fcntl($lei->{1}, F_GETFL, 0) //

diff --git a/lib/PublicInbox/LeiXSearch.pm b/lib/PublicInbox/LeiXSearch.pm
index e41d899e7040da916a759dbcea4a2fbe13f9c933..0ca871ea8542e635bef78a65d387c2c9dfe0de45 100644 (file)
--- a/lib/PublicInbox/LeiXSearch.pm
+++ b/lib/PublicInbox/LeiXSearch.pm
@@ -414,7 +414,7 @@ sub do_query {
        };
        ($lei->{pkt_op_c}, $lei->{pkt_op_p}) = PublicInbox::PktOp->pair($ops);
        $lei->{1}->autoflush(1);
-       $lei->start_pager if -t $lei->{1};
+       $lei->start_pager if delete $lei->{need_pager};
        $lei->{ovv}->ovv_begin($lei);
        my $l2m = $lei->{l2m};
        if ($l2m) {