lib/PublicInbox/View.pm | 4 ++--
lib/PublicInbox/ViewVCS.pm | 6 +++---
lib/PublicInbox/WWW.pm | 2 +-
lib/PublicInbox/WwwAltId.pm | 6 +++---
lib/PublicInbox/WwwStream.pm | 7 +++----
lib/PublicInbox/WwwText.pm | 2 +-
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 158feb6ab3d5a6a933e04c41bf44dd1dd9a82aaf..5fbdd1fa88cbd9aca73deca28c3b0cb5a9f75552 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -64,7 +64,7 @@ $$obuf .= '
';
}
delete $ctx->{obuf};
eval { $$obuf .= html_footer($ctx, $eml) };
- html_oneshot($ctx, 200, $obuf);
+ html_oneshot($ctx, 200, $$obuf);
}
# public functions: (unstable)
@@ -1222,7 +1222,7 @@ if ($prev) { # aligned padding for: 'next (older) | '
$next = $next ? "$next | " : ' | ';
$prev .= qq[ | latest];
}
- ($next || $prev) ? \"
page: $next$prev
" : \'';
+ ($next || $prev) ? "
page: $next$prev
" : '';
}
sub paginate_recent ($$) {
diff --git a/lib/PublicInbox/ViewVCS.pm b/lib/PublicInbox/ViewVCS.pm
index b04a5672028e226ad66a2c50bd89687092b27387..23524ac00b7e1a937b8924ba868adaa83f0c58d1 100644
--- a/lib/PublicInbox/ViewVCS.pm
+++ b/lib/PublicInbox/ViewVCS.pm
@@ -36,11 +36,11 @@ my $BIN_DETECT = 8000; # same as git
my $SHOW_FMT = '--pretty=format:'.join('%n', '%P', '%p', '%H', '%T', '%s',
'%an <%ae> %ai', '%cn <%ce> %ci', '%b%x00');
-sub html_page ($$$) {
- my ($ctx, $code, $str) = @_;
+sub html_page ($$;@) {
+ my ($ctx, $code) = @_[0, 1];
my $wcb = delete $ctx->{-wcb};
$ctx->{-upfx} = '../../'; # from "/$INBOX/$OID/s/"
- my $res = html_oneshot($ctx, $code, \$str);
+ my $res = html_oneshot($ctx, $code, @_[2..$#_]);
$wcb ? $wcb->($res) : $res;
}
diff --git a/lib/PublicInbox/WWW.pm b/lib/PublicInbox/WWW.pm
index 77f463d37ee5f7a1b0e774f2593b41f91524583c..1df5572db61c8a82b217090cbc8e9c27efd9f841 100644
--- a/lib/PublicInbox/WWW.pm
+++ b/lib/PublicInbox/WWW.pm
@@ -320,7 +320,7 @@
sub need {
my ($ctx, $extra) = @_;
require PublicInbox::WwwStream;
- PublicInbox::WwwStream::html_oneshot($ctx, 501, \<$extra is not available for this public-inbox
Return to index
EOF
diff --git a/lib/PublicInbox/WwwAltId.pm b/lib/PublicInbox/WwwAltId.pm
index e107dfe06eafb3cbcc3183b73399210c36ea4781..470561608f5df47b746cd5bab5680d23b47f3c33 100644
--- a/lib/PublicInbox/WwwAltId.pm
+++ b/lib/PublicInbox/WwwAltId.pm
@@ -33,14 +33,14 @@ my $ibx = $ctx->{ibx};
my $altid_map = $ibx->altid_map;
my $fn = $altid_map->{$altid_pfx};
unless (defined $fn) {
- return html_oneshot($ctx, 404, \<`$altid_pfx' is not a valid altid for this inbox
EOF
}
if ($env->{REQUEST_METHOD} ne 'POST') {
my $url = $ibx->base_url($ctx->{env}) . "$altid_pfx.sql.gz";
- return html_oneshot($ctx, 405, \<A POST request is required to retrieve $altid_pfx.sql.gz
curl -d '' -O $url
@@ -54,7 +54,7 @@
EOF
}
- $sqlite3 //= which('sqlite3') // return html_oneshot($ctx, 501, \<sqlite3 not available
The administrator needs to install the sqlite3(1) binary
diff --git a/lib/PublicInbox/WwwStream.pm b/lib/PublicInbox/WwwStream.pm
index ab006c40509dc336a4c6bfa2a12fa5136a0131fd..f2777fdc64f8a33fdaa945db9f7eded819514dc2 100644
--- a/lib/PublicInbox/WwwStream.pm
+++ b/lib/PublicInbox/WwwStream.pm
@@ -164,8 +164,8 @@ delete $ctx->{cb};
$ctx->zflush(_html_end($ctx));
}
-sub html_oneshot ($$;$) {
- my ($ctx, $code, $sref) = @_;
+sub html_oneshot ($$;@) {
+ my ($ctx, $code) = @_[0, 1];
my $res_hdr = [ 'Content-Type' => 'text/html; charset=UTF-8',
'Content-Length' => undef ];
bless $ctx, __PACKAGE__;
@@ -174,8 +174,7 @@ $ctx->{base_url} // do {
$ctx->zmore(html_top($ctx));
$ctx->{base_url} = base_url($ctx);
};
- $ctx->zmore($$sref) if $sref;
- my $bdy = $ctx->zflush(_html_end($ctx));
+ my $bdy = $ctx->zflush(@_[2..$#_], _html_end($ctx));
$res_hdr->[3] = length($bdy);
[ $code, $res_hdr, [ $bdy ] ]
}
diff --git a/lib/PublicInbox/WwwText.pm b/lib/PublicInbox/WwwText.pm
index c6957e813229c01c5c217f5a0c65bb0025afe8f0..3f840c447fdf37c3dc3cec8eae518840524d1a76 100644
--- a/lib/PublicInbox/WwwText.pm
+++ b/lib/PublicInbox/WwwText.pm
@@ -70,7 +70,7 @@ $txt = '' . $l->linkify_2($txt) . '
';
$txt =~ s!\bPOP3\b!POP3!;
$txt =~ s!\b(Newsgroups?)\b!$1!;
$txt =~ s!\bIMAP\b!IMAP!;
- PublicInbox::WwwStream::html_oneshot($ctx, $code, \$txt);
+ PublicInbox::WwwStream::html_oneshot($ctx, $code, $txt);
}
sub _srch_prefix ($$) {