]> Sergey Matveev's repositories - btrtrc.git/commitdiff
Fix sync.Mutex copy by value
authorMatt Joiner <anacrolix@gmail.com>
Fri, 25 Aug 2017 06:36:34 +0000 (16:36 +1000)
committerMatt Joiner <anacrolix@gmail.com>
Fri, 25 Aug 2017 06:36:34 +0000 (16:36 +1000)
Found by go vet, per https://github.com/anacrolix/torrent/issues/179.

connection.go

index d496f0c70032e66330df72cc1b6bd0d3850952c0..a893ccb81ad6296f4ffe466b6791c266b2dba4bb 100644 (file)
@@ -488,7 +488,7 @@ func nextRequestState(
        networkingEnabled bool,
        currentRequests map[request]struct{},
        peerChoking bool,
-       nextPieces prioritybitmap.PriorityBitmap,
+       nextPieces *prioritybitmap.PriorityBitmap,
        pendingChunks func(piece int, f func(chunkSpec) bool) bool,
        requestsLowWater int,
        requestsHighWater int,
@@ -524,7 +524,7 @@ func (cn *connection) updateRequests() {
                cn.t.networkingEnabled,
                cn.Requests,
                cn.PeerChoked,
-               cn.pieceRequestOrder,
+               &cn.pieceRequestOrder,
                func(piece int, f func(chunkSpec) bool) bool {
                        return undirtiedChunks(piece, cn.t, f)
                },