Eric Wong [Wed, 30 Dec 2015 22:31:49 +0000 (22:31 +0000)]
view: "thread" in per-message view goes back to /t/
Linking to the expanded thread page probably makes more sense
as it avoid unnecessary scanning for the thread summary.
Eric Wong [Wed, 30 Dec 2015 21:56:56 +0000 (21:56 +0000)]
view: avoid excessive indentation in thread summary
We already use "` " (backtick + space) to denote one indentation
level, so do not excessively indent and always pad with one
level less of spaces.
The 'x' operator in Perl handles negative values, so subtracting
one from level=0 will result in an empty string without spaces.
Eric Wong [Wed, 30 Dec 2015 21:34:10 +0000 (21:34 +0000)]
view: thread using <ul> instead of <table>
On second viewing, this does render small cues which makes the
output more pleasant for lynx users. We avoid injecting the
root (level=0) message into a list since it still wastes
precious horizontal whitespace on small displays.
This also results in small reductions in bandwidth usage as
it takes fewer tags/whitespace to render unordered lists.
Eric Wong [Sat, 26 Dec 2015 23:56:15 +0000 (23:56 +0000)]
t/plack.t: fix test *with* plack installed... oops
Fixes commit
83fedde4cde6539386c9d3ecf37fb99d74af8d93
("tests: fixup requirements for tests")
e@80x24.org [Sat, 26 Dec 2015 23:38:17 +0000 (23:38 +0000)]
tests: fixup requirements for tests
We should be able to run tests on bare bones systems more easily.
Eric Wong [Sat, 26 Dec 2015 22:01:16 +0000 (22:01 +0000)]
doc: minor updates to trim down the README
We'll continue developing and supporting ssoma, but it's unlikely to
gain much adoption in its current form; so stop cluttering up our
own README with it.
Eric Wong [Sat, 26 Dec 2015 22:00:07 +0000 (22:00 +0000)]
doc: use ".html" instead of ".txt.html" for website
Shorter URLs are easier to read, remember, and more efficient.
Eric Wong [Sat, 26 Dec 2015 01:26:40 +0000 (01:26 +0000)]
use "Atom feed" consistently in headers/footers
While having the extra " feed" is noisy in the main topic
landing page, it is useful in headers/footers which have
plenty of space to be more descriptive.
Eric Wong [Sat, 26 Dec 2015 01:14:27 +0000 (01:14 +0000)]
searchview: fix unclosed tags in threaded search results
Oops, we've had this forever and we also lacked a space
between the this was noticed while adding an extra
line between the "Search results ordered by" header
and actual messages.
Eric Wong [Sat, 26 Dec 2015 01:11:15 +0000 (01:11 +0000)]
view: reduce main landing page weight
Hopefully, "mbox.gz" is sufficiently understandabe that
we can get rid of the "title" attribute in <a> tags
(we already omitted the title in other pages).
Additionally, drop the '@' in front of the date.
The date should be obvious and is not necessary for
headers without author attribution.
Eric Wong [Sat, 26 Dec 2015 01:01:52 +0000 (01:01 +0000)]
searchview: fix up Atom feed in search results
Oops :x We need better testing...
Fixes: commit 4c2c2325d2948ec5340e2fcafbee798cf568f5fd
("rename 'GitCatFile' package to 'Git'")
Eric Wong [Sat, 26 Dec 2015 00:46:32 +0000 (00:46 +0000)]
searchview: fixup stupid syntax error
Fixes: commit 398e29344ecc43548a7d3998bb5d2fcee62d66cd
("view: favor whitespace wrap in <head>")
Oops.
Eric Wong [Fri, 25 Dec 2015 11:48:27 +0000 (11:48 +0000)]
view: favor whitespace wrap in <head>
If we bite the bullet and rely on inline CSS, we might as well
only specify it once per page instead of inline in every <pre>
tag which may handle UGC. So this actually saves us a small
amount of bandwith on most pages which have multiple <pre>
start tags.
Eric Wong [Fri, 25 Dec 2015 11:21:40 +0000 (11:21 +0000)]
examples/public-inbox.psgi: make output chunky by default
HTTP/1.1 clients will want persistent connections and
need to know response terminations.
Eric Wong [Fri, 25 Dec 2015 10:55:58 +0000 (10:55 +0000)]
view: fixup ghost message errors from threading tweaks
Ghost message links didn't show up too well after
commit
bc067a7562a586bed92401fe1084bbe423b9451a
("view: move thread info near top of single view")
Additionally, attribution lacked a space when subjects changed
mid-thread.
Eric Wong [Fri, 25 Dec 2015 10:53:15 +0000 (10:53 +0000)]
extmsg: fixup comparison for unknown message types
Fixes commit
4c2c2325d2948ec5340e2fcafbee798cf568f5fd
("rename 'GitCatFile' package to 'Git'")
Eric Wong [Fri, 25 Dec 2015 09:35:38 +0000 (09:35 +0000)]
view: move thread info near top of single view
Most framed mail viewing software has message ancestry
information near the top instead of bottom (mutt, gmane,
sylpheed, thunderbird) as it can help improve context.
Traditional netiquette also favors writing replies below
quoted (older) text for this reason; so move the thread
summary to the top of the message for context.
Since threads may be long, add a "skip" anchor link to jump to
the message body quickly, and align the date to the left column
so it's easier to tell the relative age of messages.
While we're at it, remove quotes from "id" attributes to
improve ease-of-grep-ability.
Eric Wong [Wed, 23 Dec 2015 04:15:30 +0000 (04:15 +0000)]
view: fix wording for empty topics display
Users may be iterating through lists and come up with nothing
Eric Wong [Tue, 22 Dec 2015 00:17:33 +0000 (00:17 +0000)]
rename 'GitCatFile' package to 'Git'
We'll be using it for more than just cat-file.
Adding a `popen' API for internal use allows us to save a bunch
of code in other places.
Eric Wong [Thu, 17 Dec 2015 05:37:31 +0000 (05:37 +0000)]
git: cat-file wrapper enhancements
The "cat_file" sub now allows a block to be passed for partial
processing. Additionally, a new "check" method is added to
retrieve only object metadata: (SHA-1 identifier, type, size)
Eric Wong [Tue, 15 Dec 2015 20:58:50 +0000 (20:58 +0000)]
hval: move PRE constant for wrapping UGC here
User-generated content (UGC) may have excessively long lines
which screw up rendering. This is the only bit of CSS we use.
Eric Wong [Thu, 10 Dec 2015 04:16:43 +0000 (04:16 +0000)]
config: hoist out common functions
These will be reused elsewhere.
Eric Wong [Tue, 8 Dec 2015 05:31:23 +0000 (05:31 +0000)]
extmsg: try to fixup common errors
Sometimes users (me :x) blindly append "raw" to a /t/ URL...
Eric Wong [Sun, 6 Dec 2015 03:14:03 +0000 (03:14 +0000)]
view: fix message truncation logic
Avoid truncating messages if we requested the root anchor.
This regression appeared in
commit
62ee3cb36dd08f17e444e96dc80108464ee10cba
("view: do not shorten top-level messages in thread view")
Also, make the "More..." link more prominent, as readers
should be made aware they're not reading the full message.
Eric Wong [Sat, 5 Dec 2015 02:08:01 +0000 (02:08 +0000)]
*view: avoid leading zero in time display of the hour
Avoid the visual noise entirely by using a space instead.
I sometimes have difficulty distinguishing '0' from '8' while
other users may mistake it for an 'O' character. Most digital
clocks I've seen will omit displaying a leading zero for the
hour, too.
This may also save transfer time by allowing better compression
(since there is a space between the date and time anyways) and
perhaps reduce client rendering time on some displays.
We'll leave the leading zero for minutes since that seems pretty
standard for digital clocks.
Eric Wong [Fri, 4 Dec 2015 01:02:24 +0000 (01:02 +0000)]
view: avoid truncating topic at 30 chars
It's potentially unsafe (leading to hidden messages) at any level.
Eric Wong [Wed, 2 Dec 2015 02:47:00 +0000 (02:47 +0000)]
view: consistent links for per-message views
Just because a message is currently alone does not mean
the links won't be valid in the future when more messages
show up.
Eric Wong [Wed, 2 Dec 2015 02:28:01 +0000 (02:28 +0000)]
view: don't kill topic summarization for level==0
Unlinked threads with similar (but not identical) subjects
could be hidden as a result.
Eric Wong [Sat, 21 Nov 2015 01:42:17 +0000 (01:42 +0000)]
config: allow underscore in section names
Apparently git allows them, and they're definitely alright
in email addresses.
Eric Wong [Fri, 20 Nov 2015 01:02:40 +0000 (01:02 +0000)]
various internal documentation updates
Hopefully this gives new hackers a better overview of
how the components relate to each other.
Eric Wong [Wed, 18 Nov 2015 22:56:23 +0000 (22:56 +0000)]
nntp: fix printf warnings
Error messages and request lines may contain '%' which would
throw off Perl printf.
Eric Wong [Wed, 18 Nov 2015 21:18:41 +0000 (21:18 +0000)]
feed: capitalize "Atom" consistently
This is the official name of the spec, so refer to it
as such despite the file extension being lower-cased
Eric Wong [Wed, 18 Nov 2015 19:40:22 +0000 (19:40 +0000)]
view: further reduce size of attribution/timestamp
The "by" on the message page and "-" in the index are
unnecessary and readers should have no trouble figuring out
what the attribution/timestamp line means.
Eric Wong [Wed, 18 Nov 2015 01:42:50 +0000 (01:42 +0000)]
TODO: updates for done stuff, and add item for message threading
Of course, we need to figure out if RFC 4685 is supported anywhere,
first.
Eric Wong [Wed, 18 Nov 2015 01:36:55 +0000 (01:36 +0000)]
view: remove "created" and "updated" noise words
They increase HTML size and add to visual noise without telling
enough useful information.
Eric Wong [Thu, 15 Oct 2015 18:31:50 +0000 (18:31 +0000)]
filter: fix handling of bad attachments
Improve error messages and use a better regexp for detecting
printable characters in attachments.
Eric Wong [Thu, 8 Oct 2015 20:08:47 +0000 (20:08 +0000)]
view: fixup bad comparison
Oops, there is no longer a 3rd element.
Fixes: 759efc037728a766ee80f1b0d3c1fd7b8c76a05f
("view: remove attribution for topics in top-level view")
Eric Wong [Thu, 8 Oct 2015 00:49:04 +0000 (00:49 +0000)]
view: remove attribution for topics in top-level view
It clutters up the page unnecessarily, as identity of the topic
starter/updater probably doesn't matter if there's no exact
message to attribute the message to.
Eric Wong [Mon, 5 Oct 2015 04:44:28 +0000 (04:44 +0000)]
README: add OpenSSL exception
Network connections may use OpenSSL for TLS (as other libraries,
such as GNUTLS do not appear well-supported under Perl). So
give this exception in case somebody needs TLS support for NNTP.
Eric Wong [Sun, 4 Oct 2015 00:47:20 +0000 (00:47 +0000)]
mbox: generate Archived-At, List-Post, List-Archive headers
Downloaded mboxen can be archived/stored indefinitely, try to
make it easy for future archaelogists to find the online
archive location.
Eric Wong [Sun, 4 Oct 2015 00:28:20 +0000 (00:28 +0000)]
mbox: kill Bytes meta-header, too
It may be present in messages imported from NNTP.
Eric Wong [Sun, 4 Oct 2015 00:13:47 +0000 (00:13 +0000)]
view: add links for mbox and atom feeds in homepage
Having per-thread Atom feeds and downloadable mboxen is powerful
and should be more easily visible/accessible to casual readers.
Eric Wong [Sat, 3 Oct 2015 10:18:07 +0000 (10:18 +0000)]
mda: support a 'filter=scrub' option for external lists
For list where we are not the primary archival entry point,
defaulting to filter=scrub makes sense since their list
conventions may be more tolerant of HTML and other crap
than we are.
Eric Wong [Sat, 3 Oct 2015 10:02:33 +0000 (10:02 +0000)]
drop Message-IDs longer than 244 bytes
Xapian has this limit for terms, and there are likely no
legitimate Message-IDs (or single header lines) this long; so
there's no need to workaround this limit.
Eric Wong [Fri, 2 Oct 2015 21:15:07 +0000 (21:15 +0000)]
rename mid_compress to id_compress
We use it as a general compressor for identifiers such as
subject paths, so using the "mid_" prefix probably is not
appropriate.
Eric Wong [Fri, 2 Oct 2015 20:43:38 +0000 (20:43 +0000)]
nntpd: executable permission
Ensure we are executable for consistency and documentation.
MakeMaker already makes this executable, but we might as
well do the same...
Eric Wong [Fri, 2 Oct 2015 18:35:12 +0000 (18:35 +0000)]
Msgmap: pass ReadOnly DBI flag for non-writable opens
This doesn't seem to do anything on my older system, but maybe it
will in newer or future versions of DBD::SQLite. Anyways it can
be helpful for documentation purposes, too.
Eric Wong [Thu, 1 Oct 2015 23:53:25 +0000 (23:53 +0000)]
searchidx: subject is not a term
Sometimes subjects are excessively long and hit Xapian's 245-byte
term limit. We can still perform subject-only searches with
a probabilistic prefix.
Eric Wong [Thu, 1 Oct 2015 23:31:13 +0000 (23:31 +0000)]
nntp: better delimit error message
It may be hard to tell what command triggered an error,
otherwise.
Eric Wong [Thu, 1 Oct 2015 22:38:04 +0000 (22:38 +0000)]
nntp: remove reference to non-existent function
Oops
Eric Wong [Thu, 1 Oct 2015 22:10:31 +0000 (22:10 +0000)]
nntp: implement idle time expiration
We don't want to waste precious server memory on clients which
have been idle for longer than 3 minutes.
Eric Wong [Thu, 1 Oct 2015 20:44:27 +0000 (20:44 +0000)]
filter: more consistent labeling of rejections
While we're at it, reject non-plain-text top-level messages,
too. They probably do not exist in practice, but we cannot
afford to scrub given policies implemented by overzealous
mail providers.
While we're at it, update the comment for strip_multipart.
Eric Wong [Thu, 1 Oct 2015 20:16:35 +0000 (20:16 +0000)]
searchview: fix syntax error
Oops, I forgot to run the syntax check for this.
Eric Wong [Thu, 1 Oct 2015 20:04:30 +0000 (20:04 +0000)]
filter: do not strip Reply-To
It's often part of idiotic policies to prevent mailing lists
from working at all.
Eric Wong [Thu, 1 Oct 2015 19:20:03 +0000 (19:20 +0000)]
mda: keep DKIM crap
This is probably unsafe
Eric Wong [Thu, 1 Oct 2015 05:57:19 +0000 (05:57 +0000)]
view: correctly pick latest in index anchor links
The last message in a thread _display_ is not necessarily the
latest message in the thread. We must go by the Date: header
on the messages themselves as a best-guess. Of course Date:
headers may lie, but most mail clients trust them by default,
so we will, too.
Eric Wong [Wed, 30 Sep 2015 21:25:51 +0000 (21:25 +0000)]
README: document NNTP access
That's right, we now have our NNTP server running and are
self-hosting a read-only news gateway at:
nntp://news.public-inbox.org/inbox.comp.mail.public-inbox.meta
Eric Wong [Wed, 30 Sep 2015 21:17:14 +0000 (21:17 +0000)]
view: use '+' instead of '%20' to escape spaces in mailto:
'+' is more shoter and more readable in query parameters than '%20'
Eric Wong [Wed, 30 Sep 2015 21:00:27 +0000 (21:00 +0000)]
t/nntpd.t: additional tests for XHDR/HDR
More testing is good, especially since clients I use
don't implement all the commands.
Eric Wong [Wed, 30 Sep 2015 21:00:26 +0000 (21:00 +0000)]
t/nntpd.t: simplify condition for response termination
Multiline responses must end with "\r\n.\r\n", so we won't
break out early in case the OS doesn't support MSG_MORE.
Eric Wong [Wed, 30 Sep 2015 21:00:25 +0000 (21:00 +0000)]
nntp: implement OVER/XOVER summary in search document
The document data of a search message already contains a good chunk
of the information needed to respond to OVER/XOVER commands quickly.
Expand on that and use the document data to implement OVER/XOVER
quickly.
This adds a dependency on Xapian being available for nntpd usage,
but is probably alright since nntpd is esoteric enough that anybody
willing to run nntpd will also want search functionality offered
by Xapian.
This also speeds up XHDR/HDR with the To: and Cc: headers and
:bytes/:lines article metadata used by some clients for header
displays and marking messages as read/unread.
Eric Wong [Wed, 30 Sep 2015 21:00:24 +0000 (21:00 +0000)]
nntp: implement LIST HEADERS
We shall remove slow, unoptimized headers in XHDR/HDR to avoid
becoming an easy DoS target.
Eric Wong [Wed, 30 Sep 2015 21:00:23 +0000 (21:00 +0000)]
nntp: MODE READER denies posting
Redundantly confirm to clients we do not accept posting with the
MODE READER command.
ref: RFC 3977 5.3.1
Eric Wong [Wed, 30 Sep 2015 21:00:22 +0000 (21:00 +0000)]
INSTALL: document Danga::Socket dependency for nntpd
We don't have something like CGI or Plack to build an NNTP
server on top on, so we implemented one using Danga::Socket
for epoll/kqueue abstraction.
Eric Wong [Wed, 30 Sep 2015 21:00:21 +0000 (21:00 +0000)]
nntpd: avoid lazy require
We cannot avoid requiring ::Config, so do not hide it.
Eric Wong [Wed, 30 Sep 2015 21:00:20 +0000 (21:00 +0000)]
daemon: always autoflush stdout/stderr
Users may log output to a pipe, so ensure these outputs are
unbuffered in userspace and go to the operating system ASAP
for other processes to pick up.
Eric Wong [Wed, 30 Sep 2015 21:00:19 +0000 (21:00 +0000)]
remove unnecessary fields usage
It doesn't actually give performance improvements unless we
use types with "my", but we don't do that. We'll only continue
using fields with Danga::Socket-derived classes where they're
required.
Eric Wong [Wed, 30 Sep 2015 21:00:18 +0000 (21:00 +0000)]
nntp: reduce syscalls for LIST OVERVIEW.FMT
No point in sending such a short, bounded response with
multiple syscalls.
Eric Wong [Wed, 30 Sep 2015 21:00:17 +0000 (21:00 +0000)]
nntp: HDR returns 225, not 224
This is stipulated by RFC 3977 8.5.1, but apparently I misread it.
Eric Wong [Wed, 30 Sep 2015 21:00:16 +0000 (21:00 +0000)]
search: remove get_subject_path
We probably won't be supporting this in the public API
Eric Wong [Fri, 25 Sep 2015 08:21:43 +0000 (08:21 +0000)]
daemon: fix various permissions + daemon issues
When using user-switching in a single process, we must be
careful to not inadvertantly create new Msgmap sqlite3 files.
We must also ensure we set proper permissions on any files
we create.
Additionally, our refactoring was broken as we failed to
actually daemonize or preserve the parent FD in a worker
process.
Finally, default to one worker process since our code may
be fatally broken and it's nice to be able to scale to multiple
cores via SIGTTIN if needed.
Eric Wong [Fri, 25 Sep 2015 02:27:57 +0000 (02:27 +0000)]
nntp: avoid signals for long responses
Using a signal-based timer can hurt throughput on a machine that's
overloaded. Ensure there's always forward progress and reduce the
number of syscalls we make, too.
Eric Wong [Fri, 25 Sep 2015 02:27:56 +0000 (02:27 +0000)]
git: use fields for GitCatFile
Micro-optimization, but it make using Danga::Socket for watching
pipe readability easier at some point.
Eric Wong [Fri, 25 Sep 2015 02:27:55 +0000 (02:27 +0000)]
git: signal-safety for pipe writes
I've yet to hit it, but syswrite has chance of returning EINTR
on a blocking pipe.
Eric Wong [Fri, 25 Sep 2015 02:27:54 +0000 (02:27 +0000)]
nntp: prefix FD on every log line
This can help us track down what request patterns clients
will perform when we have multiple clients.
Eric Wong [Fri, 25 Sep 2015 02:27:53 +0000 (02:27 +0000)]
nntp: do not repeat result on blocked write
Oops, we must increment our range even if we yield or
get blocked on output buffering.
Eric Wong [Fri, 25 Sep 2015 02:27:52 +0000 (02:27 +0000)]
searchidx: remove unused sub: next_doc_id
It seems like it was never used
Eric Wong [Fri, 25 Sep 2015 02:27:51 +0000 (02:27 +0000)]
nntp: consistently use 501 for unsupported LIST
This is required by RFC 3977, section 3.2.1
Eric Wong [Fri, 25 Sep 2015 02:27:50 +0000 (02:27 +0000)]
nntp: HDR allows metadata prefixed with ':'
RFC 3977, section 8.5.2 states metadata lookups can be done
with HDR.
Eric Wong [Thu, 24 Sep 2015 21:28:51 +0000 (21:28 +0000)]
nntpd: hoist out daemon management code
We'll probably be supporting read-only IMAP, or maybe
we'll just implement a custom HTTP server so users can
manage/upgrade the same way as the nntpd while being
immune to slow clients.
Eric Wong [Thu, 24 Sep 2015 03:37:21 +0000 (03:37 +0000)]
nntpd: support SIGUSR2 in single-process mode, too
We may support SIGUSR2 in single-process mode as long
as permissions aren't wonky.
Eric Wong [Thu, 24 Sep 2015 03:37:20 +0000 (03:37 +0000)]
nntpd: better encapsulation for shutdown
We can use the UNIVERSAL::can to better encapsulate the shutdown
process, in case we need to implement a gopher or HTTP daemon.
Eric Wong [Thu, 24 Sep 2015 03:37:19 +0000 (03:37 +0000)]
nntp: avoid infinite loop on partial read
Oops :x
Eric Wong [Thu, 24 Sep 2015 03:37:18 +0000 (03:37 +0000)]
nntpd: move busy check to NNTP package
This is better encapsulated and hopefully more readable.
While we're at it, check for being inside a long response, too.
Eric Wong [Thu, 24 Sep 2015 03:37:17 +0000 (03:37 +0000)]
nntpd: hard quit after 30s
We don't want clients hogging server resources and preventing
us from shutting down, so give them 30s to finish whatever
request they're getting.
Eric Wong [Thu, 24 Sep 2015 03:37:16 +0000 (03:37 +0000)]
nntpd: additional daemonization options
This should fully support the signals used by nginx and starman,
so scripts used by nginx can be used to manage our nntpd daemon,
too.
Eric Wong [Thu, 24 Sep 2015 03:37:15 +0000 (03:37 +0000)]
nntp: fix XOVER command
Oops, we need to test commands more closely :x
Add a missing prototype while we're at it for extra
checking.
Eric Wong [Wed, 23 Sep 2015 02:21:24 +0000 (02:21 +0000)]
nntp: support HDR command from RFC 3977
This is similar to XHDR, but differs in how it handles Message-ID
lookups.
Eric Wong [Tue, 22 Sep 2015 10:09:48 +0000 (10:09 +0000)]
nntp: XHDR lookups by Message-ID may cross groups
This is allowed by RFC 2980 and HDR (to-be-implemented) in
RFC 3977 supports it, too.
Eric Wong [Tue, 22 Sep 2015 10:09:47 +0000 (10:09 +0000)]
nntp: XHDR fixes for Message-ID lookups
We'll require some modifications for HDR support, though.
Eric Wong [Tue, 22 Sep 2015 10:09:46 +0000 (10:09 +0000)]
nntp: implement OVER from RFC 3977
This is just like the XOVER command, but allows a single Message-ID
to be given.
Eric Wong [Tue, 22 Sep 2015 10:09:45 +0000 (10:09 +0000)]
nntp: avoid setting Bytes and Lines headers
These are internal metadata should be calculated, so avoid
leaking it into the header.
Eric Wong [Tue, 22 Sep 2015 10:09:44 +0000 (10:09 +0000)]
nntp: ensure body lines end with CRLF
It's common for mail bodies to end with LF-only, so end them with
CRLF to avoid triggering errors in clients.
Eric Wong [Tue, 22 Sep 2015 10:09:43 +0000 (10:09 +0000)]
nntp: support YYYYMMDD dates for commands
RFC 3977 supports YYYYMMDD dates while retaining backwards
compatibility for old YYMMDD dates.
Eric Wong [Tue, 22 Sep 2015 10:09:42 +0000 (10:09 +0000)]
t/nntpd.t: fix fcntl test to ensure no failures
We need to run the syscall before testing for its failure :x
Eric Wong [Mon, 21 Sep 2015 11:11:12 +0000 (11:11 +0000)]
nntp: proper UTF-8 support (hopefully?)
RFC 3977 stipulates the use of UTF-8 as the default charset,
so we shall try using that and hopefully not mangle things.
Eric Wong [Mon, 21 Sep 2015 11:11:11 +0000 (11:11 +0000)]
remove bytes:: for length checks
Apparently, my mental model of Perl internals is still incorrect
after all these years. I am but a simple *nix programmer:
everything is a bag of bytes to me.
This fixes a problem with UTF-8 headers from Xapian (via
"XHDR Subject [range]") triggering partial writes and writing an
extra newline to the outputs.
Eric Wong [Mon, 21 Sep 2015 11:11:10 +0000 (11:11 +0000)]
t/nntpd.t: improve test runnability
The created socket FD number may not be 3 in the test,
force it to be so inside the child process.
Eric Wong [Mon, 21 Sep 2015 11:11:09 +0000 (11:11 +0000)]
nntp: speed up xover slightly
Reserializing the message to a string to check size wastes
considerable time and should be able to get by with slightly
less accuracy.
Eric Wong [Mon, 21 Sep 2015 11:11:08 +0000 (11:11 +0000)]
nntp: speed up XHDR Xref for rtin
We could also start displaying Xref in XOVER as rtin seems to
prefer it. Anyways this is nearly 100 times faster now and
requires no DB changes.