Eric Wong [Wed, 30 Sep 2015 21:00:18 +0000 (21:00 +0000)]
nntp: reduce syscalls for LIST OVERVIEW.FMT
No point in sending such a short, bounded response with
multiple syscalls.
Eric Wong [Wed, 30 Sep 2015 21:00:17 +0000 (21:00 +0000)]
nntp: HDR returns 225, not 224
This is stipulated by RFC 3977 8.5.1, but apparently I misread it.
Eric Wong [Wed, 30 Sep 2015 21:00:16 +0000 (21:00 +0000)]
search: remove get_subject_path
We probably won't be supporting this in the public API
Eric Wong [Fri, 25 Sep 2015 08:21:43 +0000 (08:21 +0000)]
daemon: fix various permissions + daemon issues
When using user-switching in a single process, we must be
careful to not inadvertantly create new Msgmap sqlite3 files.
We must also ensure we set proper permissions on any files
we create.
Additionally, our refactoring was broken as we failed to
actually daemonize or preserve the parent FD in a worker
process.
Finally, default to one worker process since our code may
be fatally broken and it's nice to be able to scale to multiple
cores via SIGTTIN if needed.
Eric Wong [Fri, 25 Sep 2015 02:27:57 +0000 (02:27 +0000)]
nntp: avoid signals for long responses
Using a signal-based timer can hurt throughput on a machine that's
overloaded. Ensure there's always forward progress and reduce the
number of syscalls we make, too.
Eric Wong [Fri, 25 Sep 2015 02:27:56 +0000 (02:27 +0000)]
git: use fields for GitCatFile
Micro-optimization, but it make using Danga::Socket for watching
pipe readability easier at some point.
Eric Wong [Fri, 25 Sep 2015 02:27:55 +0000 (02:27 +0000)]
git: signal-safety for pipe writes
I've yet to hit it, but syswrite has chance of returning EINTR
on a blocking pipe.
Eric Wong [Fri, 25 Sep 2015 02:27:54 +0000 (02:27 +0000)]
nntp: prefix FD on every log line
This can help us track down what request patterns clients
will perform when we have multiple clients.
Eric Wong [Fri, 25 Sep 2015 02:27:53 +0000 (02:27 +0000)]
nntp: do not repeat result on blocked write
Oops, we must increment our range even if we yield or
get blocked on output buffering.
Eric Wong [Fri, 25 Sep 2015 02:27:52 +0000 (02:27 +0000)]
searchidx: remove unused sub: next_doc_id
It seems like it was never used
Eric Wong [Fri, 25 Sep 2015 02:27:51 +0000 (02:27 +0000)]
nntp: consistently use 501 for unsupported LIST
This is required by RFC 3977, section 3.2.1
Eric Wong [Fri, 25 Sep 2015 02:27:50 +0000 (02:27 +0000)]
nntp: HDR allows metadata prefixed with ':'
RFC 3977, section 8.5.2 states metadata lookups can be done
with HDR.
Eric Wong [Thu, 24 Sep 2015 21:28:51 +0000 (21:28 +0000)]
nntpd: hoist out daemon management code
We'll probably be supporting read-only IMAP, or maybe
we'll just implement a custom HTTP server so users can
manage/upgrade the same way as the nntpd while being
immune to slow clients.
Eric Wong [Thu, 24 Sep 2015 03:37:21 +0000 (03:37 +0000)]
nntpd: support SIGUSR2 in single-process mode, too
We may support SIGUSR2 in single-process mode as long
as permissions aren't wonky.
Eric Wong [Thu, 24 Sep 2015 03:37:20 +0000 (03:37 +0000)]
nntpd: better encapsulation for shutdown
We can use the UNIVERSAL::can to better encapsulate the shutdown
process, in case we need to implement a gopher or HTTP daemon.
Eric Wong [Thu, 24 Sep 2015 03:37:19 +0000 (03:37 +0000)]
nntp: avoid infinite loop on partial read
Oops :x
Eric Wong [Thu, 24 Sep 2015 03:37:18 +0000 (03:37 +0000)]
nntpd: move busy check to NNTP package
This is better encapsulated and hopefully more readable.
While we're at it, check for being inside a long response, too.
Eric Wong [Thu, 24 Sep 2015 03:37:17 +0000 (03:37 +0000)]
nntpd: hard quit after 30s
We don't want clients hogging server resources and preventing
us from shutting down, so give them 30s to finish whatever
request they're getting.
Eric Wong [Thu, 24 Sep 2015 03:37:16 +0000 (03:37 +0000)]
nntpd: additional daemonization options
This should fully support the signals used by nginx and starman,
so scripts used by nginx can be used to manage our nntpd daemon,
too.
Eric Wong [Thu, 24 Sep 2015 03:37:15 +0000 (03:37 +0000)]
nntp: fix XOVER command
Oops, we need to test commands more closely :x
Add a missing prototype while we're at it for extra
checking.
Eric Wong [Wed, 23 Sep 2015 02:21:24 +0000 (02:21 +0000)]
nntp: support HDR command from RFC 3977
This is similar to XHDR, but differs in how it handles Message-ID
lookups.
Eric Wong [Tue, 22 Sep 2015 10:09:48 +0000 (10:09 +0000)]
nntp: XHDR lookups by Message-ID may cross groups
This is allowed by RFC 2980 and HDR (to-be-implemented) in
RFC 3977 supports it, too.
Eric Wong [Tue, 22 Sep 2015 10:09:47 +0000 (10:09 +0000)]
nntp: XHDR fixes for Message-ID lookups
We'll require some modifications for HDR support, though.
Eric Wong [Tue, 22 Sep 2015 10:09:46 +0000 (10:09 +0000)]
nntp: implement OVER from RFC 3977
This is just like the XOVER command, but allows a single Message-ID
to be given.
Eric Wong [Tue, 22 Sep 2015 10:09:45 +0000 (10:09 +0000)]
nntp: avoid setting Bytes and Lines headers
These are internal metadata should be calculated, so avoid
leaking it into the header.
Eric Wong [Tue, 22 Sep 2015 10:09:44 +0000 (10:09 +0000)]
nntp: ensure body lines end with CRLF
It's common for mail bodies to end with LF-only, so end them with
CRLF to avoid triggering errors in clients.
Eric Wong [Tue, 22 Sep 2015 10:09:43 +0000 (10:09 +0000)]
nntp: support YYYYMMDD dates for commands
RFC 3977 supports YYYYMMDD dates while retaining backwards
compatibility for old YYMMDD dates.
Eric Wong [Tue, 22 Sep 2015 10:09:42 +0000 (10:09 +0000)]
t/nntpd.t: fix fcntl test to ensure no failures
We need to run the syscall before testing for its failure :x
Eric Wong [Mon, 21 Sep 2015 11:11:12 +0000 (11:11 +0000)]
nntp: proper UTF-8 support (hopefully?)
RFC 3977 stipulates the use of UTF-8 as the default charset,
so we shall try using that and hopefully not mangle things.
Eric Wong [Mon, 21 Sep 2015 11:11:11 +0000 (11:11 +0000)]
remove bytes:: for length checks
Apparently, my mental model of Perl internals is still incorrect
after all these years. I am but a simple *nix programmer:
everything is a bag of bytes to me.
This fixes a problem with UTF-8 headers from Xapian (via
"XHDR Subject [range]") triggering partial writes and writing an
extra newline to the outputs.
Eric Wong [Mon, 21 Sep 2015 11:11:10 +0000 (11:11 +0000)]
t/nntpd.t: improve test runnability
The created socket FD number may not be 3 in the test,
force it to be so inside the child process.
Eric Wong [Mon, 21 Sep 2015 11:11:09 +0000 (11:11 +0000)]
nntp: speed up xover slightly
Reserializing the message to a string to check size wastes
considerable time and should be able to get by with slightly
less accuracy.
Eric Wong [Mon, 21 Sep 2015 11:11:08 +0000 (11:11 +0000)]
nntp: speed up XHDR Xref for rtin
We could also start displaying Xref in XOVER as rtin seems to
prefer it. Anyways this is nearly 100 times faster now and
requires no DB changes.
Eric Wong [Mon, 21 Sep 2015 11:11:07 +0000 (11:11 +0000)]
msgmap: minor cleanup to move constant declaration
This doesn't actually change anything as the constant is still
usable in other subroutines, but helps with consistency and
readability IMHO.
Eric Wong [Sun, 20 Sep 2015 09:34:52 +0000 (09:34 +0000)]
nntp: add "newsgroup" parameter and sort grouplist
Using non-hierarchical mailing list names for newsgroups
might confuse traditional newsreader software and perhaps
some humans. Allow administrators to configure newsgroups
names and hierarchies to their liking.
Sorting the grouplist alphabetically should probably be
done anyways to improve usability for some clients which
won't sort themselves.
Eric Wong [Sun, 20 Sep 2015 09:33:45 +0000 (09:33 +0000)]
newsgroup: use only the first address
public-inboxen may be aliased to multiple email addresses,
and we have always favored the first.
Eric Wong [Sun, 20 Sep 2015 03:36:11 +0000 (03:36 +0000)]
nntp: fix handling of trickled responses
We cannot use the push_back_read functionality of Danga::Socket
since it will trigger event_read on buffered data. This would
allow a malicious (or badly implemented) client to burn CPU
without actually sending us anything.
So we still do buffering ourselves and play some tricks with
timers re-enable readability.
Eric Wong [Sun, 20 Sep 2015 03:11:09 +0000 (03:11 +0000)]
nntp: do not re-enable reads during long responses
Long responses may leave the buffer momentarily empty,
but we must prevent read events from firing at that point.
Eric Wong [Sat, 19 Sep 2015 08:42:58 +0000 (08:42 +0000)]
nntpd: support systemd FD inheritance + signals
Avoid depending on IO::Socket::INET if we can help it,
we do not need to bloat ourselves with lot of that
functionality.
Eric Wong [Sat, 19 Sep 2015 02:03:40 +0000 (02:03 +0000)]
nntp: article lookups by Message-ID may cross newsgroups
Lynx seems to rely on this behavior for "ARTICLE <message-id>"
Tested with Lynx Version 2.8.8dev.12 (22 Feb 2012) on Debian wheezy.
Eric Wong [Sat, 19 Sep 2015 02:03:39 +0000 (02:03 +0000)]
nntp: log to FDs given by the Nntpd module
This will allow us to redirect stdout/stderr more easily
for logging.
Eric Wong [Sat, 19 Sep 2015 02:03:38 +0000 (02:03 +0000)]
nntp: fix ARTICLE/HEAD/BODY/STAT
Article number is optional, but we need to update the
article number of the client connection if it was specified
(but not if it was given a Message-ID) as stipulated by
RFC 977
Eric Wong [Sat, 19 Sep 2015 02:03:37 +0000 (02:03 +0000)]
nntp: fix logging of long responses
It's misleading to show short times on long responses.
Instead, show the long response as a separate entry on
completion or failure.
Eric Wong [Sat, 19 Sep 2015 02:03:36 +0000 (02:03 +0000)]
nntp: implement XPATH
This may be helpful for sorting out duplicates.
Eric Wong [Sat, 19 Sep 2015 02:03:35 +0000 (02:03 +0000)]
nntp: implement XROVER, speed up XHDR for some cases
Using Xapian allows us to implement XROVER without forking
new processes.
Eric Wong [Sat, 19 Sep 2015 02:03:34 +0000 (02:03 +0000)]
nntp: speed up XHDR for the Message-ID case
We can use our msgmap database to implement "XHDR Message-ID [range]"
commands quickly. This helps immensely with slrnpull, which prefers
XHDR to LISTGROUP for some reason...
Eric Wong [Sat, 19 Sep 2015 02:03:33 +0000 (02:03 +0000)]
nntp: XOVER does not require range
XOVER uses the current article if no range is given as
stipulated in RFC 2980.
Eric Wong [Sat, 19 Sep 2015 02:03:32 +0000 (02:03 +0000)]
nntp: implement command argument checking
Validate commands to make sure we do not accidentally screw up
some things or leave out some argument checking.
Eric Wong [Sat, 19 Sep 2015 02:03:31 +0000 (02:03 +0000)]
nntp: use long response API for LISTGROUP
LISTGROUP can be expensive for giant groups, too. Use the
long response API to improve fairness and prevent excessive
buffering.
Eric Wong [Sat, 19 Sep 2015 02:03:30 +0000 (02:03 +0000)]
nntp: introduce long response API for streaming
XOVER, NEWNEWS, XHDR responses may be arbitrarily long and cause
memory usage via buffering. This problem would exist even if we
were to optimize them by caching headers for fast retrieval and
search.
Introduce a generic API to handle all of these commands fairly
without triggering excessive buffering and unfairness of the
existing implementation.
Generating these responses is still expensive for now, but at least
the implementation is fair to other clients and prevents one client
from using one of these commands to monopolize resources away from
other clients.
Eric Wong [Sat, 19 Sep 2015 02:03:29 +0000 (02:03 +0000)]
nntp: use write_buf_size instead write_buf
It is shorter code and probably faster than checking an
array.
Eric Wong [Fri, 18 Sep 2015 01:37:53 +0000 (01:37 +0000)]
read-only NNTP server
Implementing NEWNEWS, XHDR, XOVER efficiently will require
additional caching on top of msgmap.
This seems to work with lynx and slrnpull, haven't tried clients.
DO NOT run in production, yet, denial-of-service vulnerabilities
await!
Eric Wong [Wed, 16 Sep 2015 10:05:13 +0000 (10:05 +0000)]
view: do not shorten top-level messages in thread view
The thread root is usually the most important, and should
be displayed in full.
Eric Wong [Tue, 15 Sep 2015 22:01:37 +0000 (22:01 +0000)]
add cgit commit-filter example
public-inbox has search functionality, so take advantage of
good commit messages with proper titles to lookup discussion.
Eric Wong [Tue, 15 Sep 2015 01:08:04 +0000 (01:08 +0000)]
INSTALL: document DBD::SQLite and DBI dependencies
They're optional, but probably highly useful.
Eric Wong [Tue, 15 Sep 2015 01:08:03 +0000 (01:08 +0000)]
extmsg: wire up to use msgmap for prefixes
DBI + DBD::SQLite has much better handling of prefix lookups
than Xapian. While we're at it, avoid linking blatantly wrong
Message-IDs to external services.
Eric Wong [Tue, 15 Sep 2015 01:08:02 +0000 (01:08 +0000)]
searchidx: sync Msgmap database along with Xapian
We can avoid duplicating work of extracting messages from git if we
tie this to Xapian. Of course, this ties the two features together,
but it's probably reasonable to expect that anybody who wants to use
public-inbox to serve messages to front-end users will have both.
Eric Wong [Tue, 15 Sep 2015 01:08:01 +0000 (01:08 +0000)]
searchidx: hoist out rlog code
We'll be reusing this for loading msgmap.
Eric Wong [Tue, 15 Sep 2015 01:08:00 +0000 (01:08 +0000)]
msgmap: add message mapping via SQLite
This will allow us to maintain stable article numbers for an
NNTP server independently of Xapian.
Eric Wong [Mon, 14 Sep 2015 00:04:30 +0000 (00:04 +0000)]
searchview: do not link Atom feed by relevance
Atom feeds only make sense when sorted by time, not when our
search indexing rules change and affect relevance. So do not
include the relevance option when linking to Atom feeds.
However, we shall still honor the 'r' query parameter in case
somebody wants to manually include that in the URL for
testing/experimental purposes. We simply will not advertise
it.
Eric Wong [Sun, 13 Sep 2015 23:31:58 +0000 (23:31 +0000)]
view: jump to anchor of current message on References
Otherwise it could be a bit disorienting to jump to the
first message in the thread without navigation context.
Eric Wong [Sun, 13 Sep 2015 23:29:54 +0000 (23:29 +0000)]
view: do not show References unless a message has them
It's a waste of space and potentially confusing.
Eric Wong [Sun, 13 Sep 2015 23:28:53 +0000 (23:28 +0000)]
view: use header_obj to avoid extra method calls
Email::MIME will call the header_obj each time anyways, avoid
the extra method lookups and hit header_obj directly for the
header lookup.
Eric Wong [Sun, 13 Sep 2015 23:25:05 +0000 (23:25 +0000)]
view: extra Atom feed link in standalone message view
It might be helpful if user agents do not display the <link>
element in <head>.
Eric Wong [Sun, 13 Sep 2015 22:35:47 +0000 (22:35 +0000)]
view: add Atom links in headers for per-message links
Some user agents will advertise the presence of a feed this
way for users to subscribe to individual topics.
Eric Wong [Sun, 13 Sep 2015 22:35:46 +0000 (22:35 +0000)]
searchview: implement Atom feed for search results
This can be helpful for folks who want to subscribe
to a particular topic or keyword.
Eric Wong [Sun, 13 Sep 2015 22:35:45 +0000 (22:35 +0000)]
feed: consolidate updated tag generation
We'll be reusing this code further in the next commit.
Eric Wong [Sat, 12 Sep 2015 01:23:32 +0000 (01:23 +0000)]
searchview: support displaying entire threads
This hopefully makes it easy to perform queries to display
an entire thread. Raise the limit in the threaded view to
display more results and hopefully improve the output of
thread display.
Eric Wong [Sat, 12 Sep 2015 01:23:31 +0000 (01:23 +0000)]
searchview: hoist out subroutines for clarity
We'll be expanding the search view to handle expanded views.
Eric Wong [Sat, 12 Sep 2015 01:23:30 +0000 (01:23 +0000)]
view: more consistent prefix for ghost links
This will be reused for search views.
Eric Wong [Fri, 11 Sep 2015 05:42:40 +0000 (05:42 +0000)]
examples/public-inbox.psgi: optional deflater
The deflater middleware isn't standard Plack, so don't require
potential users install it.
Eric Wong [Thu, 10 Sep 2015 00:59:08 +0000 (00:59 +0000)]
constent X?HTML MIME type filtering
Filter and View should reject X?HTML the same way.
Eric Wong [Mon, 7 Sep 2015 07:02:20 +0000 (07:02 +0000)]
view: change References link to expand thread
The expanded thread view is generally more useful. Having links
to more links at the bottom seems to a waste of navigation time.
However, keep the '#r' anchor in case people rely on it for
links.
Eric Wong [Sun, 6 Sep 2015 07:15:26 +0000 (07:15 +0000)]
public-inbox-init: use absolute path
We actually have no business expanding (e.g. translating ~ to
$HOME) paths from the command-line argument, the shell does
that.
However, we need to make the path absolute instead.
Eric Wong [Sun, 6 Sep 2015 06:59:13 +0000 (06:59 +0000)]
update copyright headers and email addresses
In the future, it should be possible to use this:
git ls-files | UPDATE_COPYRIGHT_HOLDER='all contributors' \
UPDATE_COPYRIGHT_USE_INTERVALS=2 \
xargs /path/to/gnulib/build-aux/update-copyright
Eric Wong [Sun, 6 Sep 2015 06:51:44 +0000 (06:51 +0000)]
Makefile.PL: conform to naming conventions
Not that we actually have a bare PublicInbox module, yet.
Maybe MID can be it.
Eric Wong [Sat, 5 Sep 2015 09:16:19 +0000 (09:16 +0000)]
extmsg: add note about the deficiency of the implementation
ref: http://public-inbox.org/meta/
20150905091457.GA27857@dcvr.yhbt.net/
Eric Wong [Sat, 5 Sep 2015 09:04:53 +0000 (09:04 +0000)]
searchview: link users to permalink instead of thread
The permalink should load faster if the user had a good query
and users can easily find the rest of the message in the thread.
Eric Wong [Sat, 5 Sep 2015 08:56:54 +0000 (08:56 +0000)]
extmsg: fall back to partial Message-ID matching
In case a URL gets truncated (as is common with long URLs),
we can rely on Xapian for partial matches and bring the user
to their destination.
Eric Wong [Sat, 5 Sep 2015 08:00:12 +0000 (08:00 +0000)]
search: tweak parsing for internal queries
We should not need to use QueryParser for internal queries,
but rather for external ones.
We'll also be exposing searching Message-IDs with the "mid:" prefix
for broken mids on some servers, and enabling partial searching
with 'm' to help with URL truncations.
Since thread IDs may be volatile, they cannot be exposed to the
public, there's no reason to expose them to the query parser,
either.
Also, add 's:' as an alternative probabilistic prefix to 'subject'
as it is shorter.
Eric Wong [Sat, 5 Sep 2015 07:42:44 +0000 (07:42 +0000)]
search: note why we do not support FLAG_PURE_NOT
Perhaps this can be optionally enabled in the future for smaller
sites.
Eric Wong [Sat, 5 Sep 2015 07:23:43 +0000 (07:23 +0000)]
searchview: error description for invalid queries
Xapian may raise exceptions on some queries. Pass the error
along to the user so they can read Xapian documentation.
Eric Wong [Sat, 5 Sep 2015 07:22:55 +0000 (07:22 +0000)]
search: use relevance as secondary sort by default
Might as well give relevance some weight if the timestamp is tied.
Eric Wong [Sat, 5 Sep 2015 07:02:14 +0000 (07:02 +0000)]
searchview: factor out dump_mset subroutine
We'll be moving atom and thread display support inline
and reducing endpoints. Maybe it makes sense, maybe not.
Eric Wong [Sat, 5 Sep 2015 05:54:26 +0000 (05:54 +0000)]
searchview: improve footer navigation
Aallow navigating backwards and forwards, as some pages will be
bookmarked or some browsers may not have history. Also add a
link back to the index where they presumably came from.
While we're at it, limit the number of results we have to 25
for now to avoid making the page too big and wasting clients
memory for irrelevant results.
Eric Wong [Sat, 5 Sep 2015 02:52:47 +0000 (02:52 +0000)]
view: preliminary HTML search interface
This hopefully makes it easier to find things without resorting
to proprietary external services.
Eric Wong [Fri, 4 Sep 2015 08:56:30 +0000 (08:56 +0000)]
view: fix broken link to ghost fallback
Once again, the regression was introduced in
commit
16ca6b7a57266fcb466ffff005bc1d644bad14c1
(view: avoid attempting to find "subject dummy")
Eric Wong [Fri, 4 Sep 2015 08:49:29 +0000 (08:49 +0000)]
www: extra redirects for the '/'-challenged
Omitting a slash should not be fatal if unambiguous. Add
fallbacks so users who expect a directory structure-like
experience can have it at the cost of one extra HTTP
request/response pair.
This matches behavior of static sites.
Eric Wong [Fri, 4 Sep 2015 08:27:45 +0000 (08:27 +0000)]
view: thread view expands focused message
Non-top-level messages still deserve to be shown in full
if they're the message in the URL.
Eric Wong [Fri, 4 Sep 2015 05:59:59 +0000 (05:59 +0000)]
view: indentation adjustments for collapsed headers
This makes the layout between the permalink threads and
index threads more consistent; hopefully.
Eric Wong [Fri, 4 Sep 2015 05:33:17 +0000 (05:33 +0000)]
view: reduce redundant attributions in permalink refs
No point in repeating authorship when PATCH messages are
threaded and it's obvious from the top message who the author
is of the series:
[this message] - John Smith @ 2015-09-04 00:04:20 UTC
` [PATCH 1/4] view: eliminate redundant [threaded|flat] link
` [PATCH 2/4] view: one line for thread subjects
` [PATCH 3/4] view: adjust spacing and indentation of index threads
` [PATCH 4/4] view: add missing newline to inline dump
Eric Wong [Fri, 4 Sep 2015 05:19:26 +0000 (05:19 +0000)]
view: add missing newline to inline dump
This fixes a regression introduced in
commit
16ca6b7a57266fcb466ffff005bc1d644bad14c1
(view: avoid attempting to find "subject dummy")
Eric Wong [Fri, 4 Sep 2015 05:06:03 +0000 (05:06 +0000)]
view: adjust spacing and indentation of index threads
Avoid wasting precious horizontal space by indenting children
excessively relative to the top-level parent.
Eric Wong [Fri, 4 Sep 2015 04:58:42 +0000 (04:58 +0000)]
view: one line for thread subjects
We truncate subjects in the Xapian document anyways,
so lines should not be too long and it hopefully won't
throw off the vertical display.
Eric Wong [Fri, 4 Sep 2015 03:53:52 +0000 (03:53 +0000)]
view: eliminate redundant [threaded|flat] link
We do not need to waste space with that link when
we have it conveniently placed where every message
is located.
Eric Wong [Fri, 4 Sep 2015 02:18:11 +0000 (02:18 +0000)]
view: do not generate anchors in thread views
They're unused, and they can have namespace conflicts if
there's multiple full messages in the thread view.
Eric Wong [Fri, 4 Sep 2015 02:18:10 +0000 (02:18 +0000)]
SearchMsg: avoid encoding Message-IDs
Spaces may be added when using header_str with Email::MIME->create,
so use the normal "header" parameter when setting Message-IDs
and References.
Eric Wong [Fri, 4 Sep 2015 02:18:09 +0000 (02:18 +0000)]
view: avoid attempting to find "subject dummy"
This is an internal Message-ID used by Mail::Thread, to group
messages with identical subjects but common parent. Don't
attempt to redirect users to external sites when we cannot
find it.
Eric Wong [Fri, 4 Sep 2015 02:18:08 +0000 (02:18 +0000)]
extmsg: close HTML tag in response
Oops, browsers normally render this fine, though.
Eric Wong [Fri, 4 Sep 2015 02:18:07 +0000 (02:18 +0000)]
consolidate thread sorting in view
This is a display subroutine so it should not be in our thread
monkey-patching package, but instead in the view package.
Hopefully one day in the future, Mail::Thread will be maintained
again and we'll no longer need PublicInbox::Thread at all.