view: html_footer: remove obuf dependency

[public-inbox.git] / lib / PublicInbox / View.pm

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index b27523b240e7e95fd26f3c35ad756dc0e567a738..40b4bf360213dddc1c8a021a66154d0c127ed2a2 100644 (file)
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -774,11 +774,12 @@ sub thread_skel ($$$) {
        $ctx->{parent_msg} = $parent;
 }
 
-# appends to obuf
+# writes to zbuf
 sub html_footer {
        my ($ctx, $hdr) = @_;
        my $upfx = '../';
        my ($related, $skel);
+       my $foot = '<pre>';
        my $qry = delete $ctx->{-qry};
        if ($qry && $ctx->{ibx}->isrch) {
                my $q = ''; # search for either ancestor or descendent patches
@@ -836,15 +837,14 @@ EOF
                } elsif ($u) { # unlikely
                        $parent = " <a\nhref=\"$u\"\nrel=prev>parent</a>";
                }
-               ${$ctx->{obuf}} .= "<pre>$next $prev$parent ";
+               $foot .= "$next $prev$parent ";
        } else { # unindexed inboxes w/o over
-               ${$ctx->{obuf}} .= '<pre>';
                $skel = qq( <a\nhref="$upfx">latest</a>);
        }
-       ${$ctx->{obuf}} .= qq(<a\nhref="#R">reply</a>);
-       # $skel may be big for big threads, don't append it to obuf
+       $foot .= qq(<a\nhref="#R">reply</a>);
+       # $skel may be big for big threads, don't append it to $foot
        $skel .= '</pre>' . ($related // '');
-       $ctx->zmore($skel .= msg_reply($ctx, $hdr)); # flushes obuf
+       $ctx->zmore($foot, $skel .= msg_reply($ctx, $hdr)); # flushes obuf
 }
 
 sub ghost_parent {